diff mbox series

[U-Boot] initcall.h: initcall_run_list(): Improve debug output

Message ID 20190925111054.5238-1-ovidiu.panait@windriver.com
State Accepted
Commit fa840f13f5444cc0f3a435e3d2d48b1b1b6d63b9
Delegated to: Tom Rini
Headers show
Series [U-Boot] initcall.h: initcall_run_list(): Improve debug output | expand

Commit Message

Ovidiu Panait Sept. 25, 2019, 11:10 a.m. UTC 
From: Ovidiu Panait <ovpanait@gmail.com>

Existing debug output is mixed with the function name:
initcall_run_list() initcall: 25263initcall_run_list()  (relocated to 425263)

Turn it to:
initcall_run_list() initcall: 25263 (relocated to 425263)

Signed-off-by: Ovidiu Panait <ovpanait@gmail.com>
---
 include/initcall.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Tom Rini Oct. 6, 2019, 12:08 a.m. UTC | #1 
On Wed, Sep 25, 2019 at 02:10:54PM +0300, Ovidiu Panait wrote:

> From: Ovidiu Panait <ovpanait@gmail.com>
> 
> Existing debug output is mixed with the function name:
> initcall_run_list() initcall: 25263initcall_run_list()  (relocated to 425263)
> 
> Turn it to:
> initcall_run_list() initcall: 25263 (relocated to 425263)
> 
> Signed-off-by: Ovidiu Panait <ovpanait@gmail.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/initcall.h b/include/initcall.h
index 78d15afe69..b5acdd01bd 100644
--- a/include/initcall.h
+++ b/include/initcall.h
@@ -30,11 +30,13 @@  static inline int initcall_run_list(const init_fnc_t init_sequence[])
 #ifdef CONFIG_EFI_APP
 		reloc_ofs = (unsigned long)image_base;
 #endif
-		debug("initcall: %p", (char *)*init_fnc_ptr - reloc_ofs);
 		if (reloc_ofs)
-			debug(" (relocated to %p)\n", (char *)*init_fnc_ptr);
+			debug("initcall: %p (relocated to %p)\n",
+					(char *)*init_fnc_ptr - reloc_ofs,
+					(char *)*init_fnc_ptr);
 		else
-			debug("\n");
+			debug("initcall: %p\n", (char *)*init_fnc_ptr - reloc_ofs);
+
 		ret = (*init_fnc_ptr)();
 		if (ret) {
 			printf("initcall sequence %p failed at call %p (err=%d)\n",