diff mbox series

[U-Boot,v3,2/8] dm: cache: Add enable and disable ops for sandbox and test

Message ID 20190821080942.13724-3-uboot@andestech.com
State Superseded
Delegated to: Andes
Headers show
Series Support Andes RISC-V l2cache on AE350 platform | expand

Commit Message

Andes Aug. 21, 2019, 8:09 a.m. UTC 
From: Rick Chen <rick@andestech.com>

Add L2 cache enable and disable ops for test coverage.

Signed-off-by: Rick Chen <rick@andestech.com>
Cc: KC Lin <kclin@andestech.com>
---
 drivers/cache/sandbox_cache.c | 13 +++++++++++++
 test/dm/cache.c               |  2 ++
 2 files changed, 15 insertions(+)

Comments

Bin Meng Aug. 22, 2019, 6:52 a.m. UTC | #1 
Hi Rick,

On Wed, Aug 21, 2019 at 4:16 PM Andes <uboot@andestech.com> wrote:
>
> From: Rick Chen <rick@andestech.com>
>
> Add L2 cache enable and disable ops for test coverage.

It's not L2 cache for Sandbox. Please rewrite the commit message.

>
> Signed-off-by: Rick Chen <rick@andestech.com>
> Cc: KC Lin <kclin@andestech.com>
> ---
>  drivers/cache/sandbox_cache.c | 13 +++++++++++++
>  test/dm/cache.c               |  2 ++
>  2 files changed, 15 insertions(+)
>

Other than that,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin
Rick Chen Aug. 22, 2019, 7:33 a.m. UTC | #2 
Hi Bin

> Hi Rick,
>
> On Wed, Aug 21, 2019 at 4:16 PM Andes <uboot@andestech.com> wrote:
> >
> > From: Rick Chen <rick@andestech.com>
> >
> > Add L2 cache enable and disable ops for test coverage.
>
> It's not L2 cache for Sandbox. Please rewrite the commit message.

I will remove L2 and rewrite as "cache for Sandbox" .

Thanks,
Rick

>
> >
> > Signed-off-by: Rick Chen <rick@andestech.com>
> > Cc: KC Lin <kclin@andestech.com>
> > ---
> >  drivers/cache/sandbox_cache.c | 13 +++++++++++++
> >  test/dm/cache.c               |  2 ++
> >  2 files changed, 15 insertions(+)
> >
>
> Other than that,
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>
> Regards,
> Bin
diff mbox series

Patch

diff --git a/drivers/cache/sandbox_cache.c b/drivers/cache/sandbox_cache.c
index 14cc6b0..9050c4c 100644
--- a/drivers/cache/sandbox_cache.c
+++ b/drivers/cache/sandbox_cache.c
@@ -17,8 +17,21 @@  static int sandbox_get_info(struct udevice *dev, struct cache_info *info)
 	return 0;
 }
 
+static int sandbox_enable(struct udevice *dev)
+{
+	return 0;
+}
+
+static int snadbox_disable(struct udevice *dev)
+{
+	return 0;
+}
+
+
 static const struct cache_ops sandbox_cache_ops = {
 	.get_info	= sandbox_get_info,
+	.enable 	= sandbox_enable,
+	.disable	= snadbox_disable,
 };
 
 static const struct udevice_id sandbox_cache_ids[] = {
diff --git a/test/dm/cache.c b/test/dm/cache.c
index d4144aa..2e244b1 100644
--- a/test/dm/cache.c
+++ b/test/dm/cache.c
@@ -14,6 +14,8 @@  static int dm_test_reset(struct unit_test_state *uts)
 
 	ut_assertok(uclass_get_device(UCLASS_CACHE, 0, &dev_cache));
 	ut_assertok(cache_get_info(dev, &info));
+	ut_assertok(cache_enable(dev));
+	ut_assertok(cache_disable(dev));
 
 	return 0;
 }