diff mbox series

[U-Boot] power: domain: ti-sci-power-domain: Add device ID info to get/set_device failure

Message ID 20190801133824.30434-1-lokeshvutla@ti.com
State Accepted
Commit 71cd80af863945e81f468c22e5e1afb06eba75cd
Delegated to: Tom Rini
Headers show
Series [U-Boot] power: domain: ti-sci-power-domain: Add device ID info to get/set_device failure | expand

Commit Message

Lokesh Vutla Aug. 1, 2019, 1:38 p.m. UTC 
From: Nishanth Menon <nm@ti.com>

Failure log for ti_sci_power_domain_on/off is as below:
"ti_sci_power_domain_on: get/set_device failed (-19)"

The above information is useless for debug without information
on what specific device access failed. So add that information as well.

Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 drivers/power/domain/ti-sci-power-domain.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Tom Rini Aug. 13, 2019, 4:51 p.m. UTC | #1 
On Thu, Aug 01, 2019 at 07:08:24PM +0530, Lokesh Vutla wrote:

> From: Nishanth Menon <nm@ti.com>
> 
> Failure log for ti_sci_power_domain_on/off is as below:
> "ti_sci_power_domain_on: get/set_device failed (-19)"
> 
> The above information is useless for debug without information
> on what specific device access failed. So add that information as well.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/power/domain/ti-sci-power-domain.c b/drivers/power/domain/ti-sci-power-domain.c
index b9cd37b612..4c4351d2d9 100644
--- a/drivers/power/domain/ti-sci-power-domain.c
+++ b/drivers/power/domain/ti-sci-power-domain.c
@@ -68,8 +68,8 @@  static int ti_sci_power_domain_on(struct power_domain *pd)
 		ret = dops->get_device(sci, pd->id);
 
 	if (ret)
-		dev_err(power_domain->dev, "%s: get_device failed (%d)\n",
-			__func__, ret);
+		dev_err(pd->dev, "%s: get_device(%lu) failed (%d)\n",
+			__func__, pd->id, ret);
 
 	return ret;
 }
@@ -85,8 +85,8 @@  static int ti_sci_power_domain_off(struct power_domain *pd)
 
 	ret = dops->put_device(sci, pd->id);
 	if (ret)
-		dev_err(power_domain->dev, "%s: put_device failed (%d)\n",
-			__func__, ret);
+		dev_err(pd->dev, "%s: put_device(%lu) failed (%d)\n",
+			__func__, pd->id, ret);
 
 	return ret;
 }