| Message ID | 20190615223442.12246-3-lukma@denx.de |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | DM: Convert i.MX28 gpio, pinmux, spi and eth drivers to DM/DTS | expand |
On 6/16/19 12:34 AM, Lukasz Majewski wrote: > The fec_mxc.c driver can be reused by i.MX28 when DM_ETH is enabled. > One only needs to add proper compatible and dependency on FEC_MXC in the > Kconfig. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > --- > > Changes in v3: > - Set more apropriate tags > > Changes in v2: None > > drivers/net/Kconfig | 2 +- > drivers/net/fec_mxc.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index e6a4fdf30e..04f886fe86 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -190,7 +190,7 @@ config FEC_MXC_MDIO_BASE > > config FEC_MXC > bool "FEC Ethernet controller" > - depends on MX5 || MX6 || MX7 || IMX8 || VF610 > + depends on MX5 || MX6 || MX7 || IMX8 || VF610 || MX28 Keep the list sorted -- IMX28 goes at the beginning > help > This driver supports the 10/100 Fast Ethernet controller for > NXP i.MX processors. > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index d7c080943a..4042dcf9ca 100644 > --- a/drivers/net/fec_mxc.c > +++ b/drivers/net/fec_mxc.c > @@ -1492,6 +1492,7 @@ static const struct udevice_id fecmxc_ids[] = { > { .compatible = "fsl,imx53-fec" }, > { .compatible = "fsl,imx7d-fec" }, > { .compatible = "fsl,mvf600-fec" }, > + { .compatible = "fsl,imx28-fec" }, Keep this list sorted too. > { } > }; > >
Hi Marek, > On 6/16/19 12:34 AM, Lukasz Majewski wrote: > > The fec_mxc.c driver can be reused by i.MX28 when DM_ETH is enabled. > > One only needs to add proper compatible and dependency on FEC_MXC > > in the Kconfig. > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > > --- > > > > Changes in v3: > > - Set more apropriate tags > > > > Changes in v2: None > > > > drivers/net/Kconfig | 2 +- > > drivers/net/fec_mxc.c | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > > index e6a4fdf30e..04f886fe86 100644 > > --- a/drivers/net/Kconfig > > +++ b/drivers/net/Kconfig > > @@ -190,7 +190,7 @@ config FEC_MXC_MDIO_BASE > > > > config FEC_MXC > > bool "FEC Ethernet controller" > > - depends on MX5 || MX6 || MX7 || IMX8 || VF610 > > + depends on MX5 || MX6 || MX7 || IMX8 || VF610 || MX28 > > Keep the list sorted -- IMX28 goes at the beginning Ok. > > > help > > This driver supports the 10/100 Fast Ethernet controller > > for NXP i.MX processors. > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > > index d7c080943a..4042dcf9ca 100644 > > --- a/drivers/net/fec_mxc.c > > +++ b/drivers/net/fec_mxc.c > > @@ -1492,6 +1492,7 @@ static const struct udevice_id fecmxc_ids[] = > > { { .compatible = "fsl,imx53-fec" }, > > { .compatible = "fsl,imx7d-fec" }, > > { .compatible = "fsl,mvf600-fec" }, > > + { .compatible = "fsl,imx28-fec" }, > > Keep this list sorted too. Ok. > > > { } > > }; > > > > > > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index e6a4fdf30e..04f886fe86 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -190,7 +190,7 @@ config FEC_MXC_MDIO_BASE config FEC_MXC bool "FEC Ethernet controller" - depends on MX5 || MX6 || MX7 || IMX8 || VF610 + depends on MX5 || MX6 || MX7 || IMX8 || VF610 || MX28 help This driver supports the 10/100 Fast Ethernet controller for NXP i.MX processors. diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index d7c080943a..4042dcf9ca 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -1492,6 +1492,7 @@ static const struct udevice_id fecmxc_ids[] = { { .compatible = "fsl,imx53-fec" }, { .compatible = "fsl,imx7d-fec" }, { .compatible = "fsl,mvf600-fec" }, + { .compatible = "fsl,imx28-fec" }, { } };
The fec_mxc.c driver can be reused by i.MX28 when DM_ETH is enabled. One only needs to add proper compatible and dependency on FEC_MXC in the Kconfig. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- Changes in v3: - Set more apropriate tags Changes in v2: None drivers/net/Kconfig | 2 +- drivers/net/fec_mxc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)