diff mbox series

[U-Boot,v1,03/11] ARM: display5: Fix CS check after moving some SPI related CONFIGs to Kconfig

Message ID 20190609205447.11212-4-lukma@denx.de
State Accepted
Commit ad31f656ae879cf655b911cae2203a1f0721c4c4
Delegated to: Stefano Babic
Headers show
Series DM: display5: Convert display5 board to DM/DTS (including 'factory' setup) | expand

Commit Message

Lukasz Majewski June 9, 2019, 8:54 p.m. UTC 
After commit 14453fbfadc2 ("Convert CONFIG_SF_DEFAULT_* to Kconfig")
and commit abe66b1b5dec ("Convert CONFIG_ENV_SPI_* to Kconfig") ,which
moved some SPI related CONFIG_* defines to Kconfig the display5 board has
become unbootable as the SPI CS check condition had wrong value.

This commit fixes this check and allows proper SPI NOR flash operation in
SPL.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---

 board/liebherr/display5/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic July 20, 2019, 8:46 a.m. UTC | #1 
> After commit 14453fbfadc2 ("Convert CONFIG_SF_DEFAULT_* to Kconfig")
> and commit abe66b1b5dec ("Convert CONFIG_ENV_SPI_* to Kconfig") ,which
> moved some SPI related CONFIG_* defines to Kconfig the display5 board has
> become unbootable as the SPI CS check condition had wrong value.
> This commit fixes this check and allows proper SPI NOR flash operation in
> SPL.
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/liebherr/display5/common.c b/board/liebherr/display5/common.c
index 4eb86d8c5d..48b5c1a6f5 100644
--- a/board/liebherr/display5/common.c
+++ b/board/liebherr/display5/common.c
@@ -68,7 +68,7 @@  iomux_v3_cfg_t const ecspi2_pads[] = {
 
 int board_spi_cs_gpio(unsigned int bus, unsigned int cs)
 {
-	if (bus != 1 || cs != (IMX_GPIO_NR(5, 29) << 8))
+	if (bus != 1 || cs != 0)
 		return -EINVAL;
 
 	return IMX_GPIO_NR(5, 29);