diff mbox series

[U-Boot,v1,02/10] mmc: fsl_esdhc: annotate endifs

Message ID 20190520004502.8924-3-marcel@ziswiler.com
State Deferred
Delegated to: Peng Fan
Headers show
Series arm: pxa: mmc: add driver model support | expand

Commit Message

Marcel Ziswiler May 20, 2019, 12:44 a.m. UTC
Annotate endifs to make CONFIG_IS_ENABLED(DM_MMC) or not more obvious.

Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>

---

 drivers/mmc/fsl_esdhc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Fabio Estevam May 20, 2019, 2:17 a.m. UTC | #1
On Sun, May 19, 2019 at 9:45 PM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> Annotate endifs to make CONFIG_IS_ENABLED(DM_MMC) or not more obvious.
>
> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thanks
Peng Fan May 20, 2019, 7:07 a.m. UTC | #2
> Subject: [PATCH v1 02/10] mmc: fsl_esdhc: annotate endifs
> 
> Annotate endifs to make CONFIG_IS_ENABLED(DM_MMC) or not more
> obvious.
> 
> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
> 
> ---
> 
>  drivers/mmc/fsl_esdhc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index
> 1b7de74a72..0742cd64e1 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -1372,7 +1372,7 @@ int fsl_esdhc_mmc_init(bd_t *bis)
>  	cfg->sdhc_clk = gd->arch.sdhc_clk;
>  	return fsl_esdhc_initialize(bis, cfg);  } -#endif
> +#endif /* !CONFIG_IS_ENABLED(DM_MMC) */
> 
>  #ifdef CONFIG_FSL_ESDHC_ADAPTER_IDENT
>  void mmc_adapter_card_type_ident(void)
> @@ -1635,7 +1635,7 @@ static const struct dm_mmc_ops fsl_esdhc_ops = {
>  	.execute_tuning	= fsl_esdhc_execute_tuning,
>  #endif
>  };
> -#endif
> +#endif /* CONFIG_IS_ENABLED(DM_MMC) */
> 
>  static struct esdhc_soc_data usdhc_imx7d_data = {
>  	.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> --
> 2.21.0
Igor Opaniuk May 20, 2019, 1:51 p.m. UTC | #3
On Mon, May 20, 2019 at 3:46 AM Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> Annotate endifs to make CONFIG_IS_ENABLED(DM_MMC) or not more obvious.
>
> Signed-off-by: Marcel Ziswiler <marcel@ziswiler.com>
>
> ---
>
>  drivers/mmc/fsl_esdhc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index 1b7de74a72..0742cd64e1 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -1372,7 +1372,7 @@ int fsl_esdhc_mmc_init(bd_t *bis)
>         cfg->sdhc_clk = gd->arch.sdhc_clk;
>         return fsl_esdhc_initialize(bis, cfg);
>  }
> -#endif
> +#endif /* !CONFIG_IS_ENABLED(DM_MMC) */
>
>  #ifdef CONFIG_FSL_ESDHC_ADAPTER_IDENT
>  void mmc_adapter_card_type_ident(void)
> @@ -1635,7 +1635,7 @@ static const struct dm_mmc_ops fsl_esdhc_ops = {
>         .execute_tuning = fsl_esdhc_execute_tuning,
>  #endif
>  };
> -#endif
> +#endif /* CONFIG_IS_ENABLED(DM_MMC) */
>
>  static struct esdhc_soc_data usdhc_imx7d_data = {
>         .flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
> --
> 2.21.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot

Reviewed-by: Igor Opaniuk <igor.opaniuk@toradex.com>
diff mbox series

Patch

diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
index 1b7de74a72..0742cd64e1 100644
--- a/drivers/mmc/fsl_esdhc.c
+++ b/drivers/mmc/fsl_esdhc.c
@@ -1372,7 +1372,7 @@  int fsl_esdhc_mmc_init(bd_t *bis)
 	cfg->sdhc_clk = gd->arch.sdhc_clk;
 	return fsl_esdhc_initialize(bis, cfg);
 }
-#endif
+#endif /* !CONFIG_IS_ENABLED(DM_MMC) */
 
 #ifdef CONFIG_FSL_ESDHC_ADAPTER_IDENT
 void mmc_adapter_card_type_ident(void)
@@ -1635,7 +1635,7 @@  static const struct dm_mmc_ops fsl_esdhc_ops = {
 	.execute_tuning	= fsl_esdhc_execute_tuning,
 #endif
 };
-#endif
+#endif /* CONFIG_IS_ENABLED(DM_MMC) */
 
 static struct esdhc_soc_data usdhc_imx7d_data = {
 	.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING