diff mbox series

[U-Boot,v4,05/13] clk: Extend struct clk to provide clocktype agnostic flags

Message ID 20190516221042.3583-6-lukma@denx.de
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series clk: Port Linux common clock framework[CCF] to U-boot (tag: 5.0-rc3) | expand

Commit Message

Lukasz Majewski May 16, 2019, 10:10 p.m. UTC
This commit extends the struct clk to provide information regarding the
flags related to this devices.

Those flags are clk device agnostic and indicate generic features
(like e.g. CLK_GET_RATE_NOCACHE - the need to always recalculate the rate).

Signed-off-by: Lukasz Majewski <lukma@denx.de>

---

Changes in v4:
- New patch

Changes in v3: None

 include/clk.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Peng Fan May 17, 2019, 5:54 a.m. UTC | #1
> Subject: [PATCH v4 05/13] clk: Extend struct clk to provide clock type agnostic
> flags
> 
> This commit extends the struct clk to provide information regarding the flags
> related to this devices.
> 
> Those flags are clk device agnostic and indicate generic features (like e.g.
> CLK_GET_RATE_NOCACHE - the need to always recalculate the rate).
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> 
> ---
> 
> Changes in v4:
> - New patch
> 
> Changes in v3: None
> 
>  include/clk.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/clk.h b/include/clk.h index 1f2fd15bb5..89dc64bfaf 100644
> --- a/include/clk.h
> +++ b/include/clk.h
> @@ -41,6 +41,9 @@ struct udevice;
>   *
>   * @dev: The device which implements the clock signal.
>   * @rate: The clock rate (in HZ).
> + * @flags: Flags used across common clock structure (e.g. CLK_)
> + *         Clock IP blocks specific flags (i.e. mux, div, gate, etc) are defined
> + *         in struct's for those devices (e.g. struct clk_mux).
>   * @id: The clock signal ID within the provider.
>   * @data: An optional data field for scenarios where a single integer ID is
> not
>   *	  sufficient. If used, it can be populated through an .of_xlate op and
> @@ -57,6 +60,7 @@ struct udevice;
>  struct clk {
>  	struct udevice *dev;
>  	unsigned long rate;	/* in HZ */
> +	uint32_t flags;
>  	/*
>  	 * Written by of_xlate. In the future, we might add more fields here.
>  	 */

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> --
> 2.11.0
Stefano Babic June 8, 2019, 3:22 p.m. UTC | #2
On 17/05/19 00:10, Lukasz Majewski wrote:
> This commit extends the struct clk to provide information regarding the
> flags related to this devices.
> 
> Those flags are clk device agnostic and indicate generic features
> (like e.g. CLK_GET_RATE_NOCACHE - the need to always recalculate the rate).
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> 
> ---
> 
> Changes in v4:
> - New patch
> 
> Changes in v3: None
> 
>  include/clk.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/clk.h b/include/clk.h
> index 1f2fd15bb5..89dc64bfaf 100644
> --- a/include/clk.h
> +++ b/include/clk.h
> @@ -41,6 +41,9 @@ struct udevice;
>   *
>   * @dev: The device which implements the clock signal.
>   * @rate: The clock rate (in HZ).
> + * @flags: Flags used across common clock structure (e.g. CLK_)
> + *         Clock IP blocks specific flags (i.e. mux, div, gate, etc) are defined
> + *         in struct's for those devices (e.g. struct clk_mux).
>   * @id: The clock signal ID within the provider.
>   * @data: An optional data field for scenarios where a single integer ID is not
>   *	  sufficient. If used, it can be populated through an .of_xlate op and
> @@ -57,6 +60,7 @@ struct udevice;
>  struct clk {
>  	struct udevice *dev;
>  	unsigned long rate;	/* in HZ */
> +	uint32_t flags;
>  	/*
>  	 * Written by of_xlate. In the future, we might add more fields here.
>  	 */
> 


Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Stefano Babic June 10, 2019, 9:40 a.m. UTC | #3
> This commit extends the struct clk to provide information regarding the
> flags related to this devices.
> Those flags are clk device agnostic and indicate generic features
> (like e.g. CLK_GET_RATE_NOCACHE - the need to always recalculate the rate).
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Reviewed-by: Stefano Babic <sbabic@denx.de>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/include/clk.h b/include/clk.h
index 1f2fd15bb5..89dc64bfaf 100644
--- a/include/clk.h
+++ b/include/clk.h
@@ -41,6 +41,9 @@  struct udevice;
  *
  * @dev: The device which implements the clock signal.
  * @rate: The clock rate (in HZ).
+ * @flags: Flags used across common clock structure (e.g. CLK_)
+ *         Clock IP blocks specific flags (i.e. mux, div, gate, etc) are defined
+ *         in struct's for those devices (e.g. struct clk_mux).
  * @id: The clock signal ID within the provider.
  * @data: An optional data field for scenarios where a single integer ID is not
  *	  sufficient. If used, it can be populated through an .of_xlate op and
@@ -57,6 +60,7 @@  struct udevice;
 struct clk {
 	struct udevice *dev;
 	unsigned long rate;	/* in HZ */
+	uint32_t flags;
 	/*
 	 * Written by of_xlate. In the future, we might add more fields here.
 	 */