| Message ID | 20190429231230.27406-3-vagrant@debian.org |
|---|---|
| State | Accepted |
| Commit | 88471ca344570cf3b31026174044bccb45689119 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Finish support for enabling BeagleBoard.org PocketBeagle. | expand |
On Mon, Apr 29, 2019 at 04:12:30PM -0700, Vagrant Cascadian wrote: > Add am335x-pocketbeagle to CONFIG_OF_LIST in am335x_evm_defconfig. > > Signed-off-by: Vagrant Cascadian <vagrant@debian.org> We need to update include/configs/am335x_evm.h too so that it detects this variant and loads the right dtb.
On 2019-04-30, Tom Rini wrote: > On Mon, Apr 29, 2019 at 04:12:30PM -0700, Vagrant Cascadian wrote: > >> Add am335x-pocketbeagle to CONFIG_OF_LIST in am335x_evm_defconfig. >> >> Signed-off-by: Vagrant Cascadian <vagrant@debian.org> > > We need to update include/configs/am335x_evm.h too so that it detects > this variant and loads the right dtb. I believe this was already added in the original commit that added partial support: "findfdt="\ ... "if test $board_name = A335PBGL; then " \ "setenv fdtfile am335x-pocketbeagle.dtb; fi; " \ In my tests, it loaded the correct .dtb file; Is there something I'm missing? live well, vagrant
On Tue, Apr 30, 2019 at 10:02:11AM -0700, Vagrant Cascadian wrote: > On 2019-04-30, Tom Rini wrote: > > On Mon, Apr 29, 2019 at 04:12:30PM -0700, Vagrant Cascadian wrote: > > > >> Add am335x-pocketbeagle to CONFIG_OF_LIST in am335x_evm_defconfig. > >> > >> Signed-off-by: Vagrant Cascadian <vagrant@debian.org> > > > > We need to update include/configs/am335x_evm.h too so that it detects > > this variant and loads the right dtb. > > I believe this was already added in the original commit that added > partial support: > > "findfdt="\ > ... > "if test $board_name = A335PBGL; then " \ > "setenv fdtfile am335x-pocketbeagle.dtb; fi; " \ > > > In my tests, it loaded the correct .dtb file; Is there something I'm > missing? Nope, I missed that it was there, thanks!
On Mon, Apr 29, 2019 at 04:12:30PM -0700, Vagrant Cascadian wrote: > Add am335x-pocketbeagle to CONFIG_OF_LIST in am335x_evm_defconfig. > > Signed-off-by: Vagrant Cascadian <vagrant@debian.org> Reviewed-by: Tom Rini <trini@konsulko.com>
On Mon, Apr 29, 2019 at 04:12:30PM -0700, Vagrant Cascadian wrote: > Add am335x-pocketbeagle to CONFIG_OF_LIST in am335x_evm_defconfig. > > Signed-off-by: Vagrant Cascadian <vagrant@debian.org> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig index 105ff01d14..967ee82bca 100644 --- a/configs/am335x_evm_defconfig +++ b/configs/am335x_evm_defconfig @@ -31,7 +31,7 @@ CONFIG_MTDPARTS_DEFAULT="mtdparts=nand.0:128k(NAND.SPL),128k(NAND.SPL.backup1),1 # CONFIG_SPL_EFI_PARTITION is not set CONFIG_OF_CONTROL=y CONFIG_DEFAULT_DEVICE_TREE="am335x-evm" -CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2" +CONFIG_OF_LIST="am335x-evm am335x-bone am335x-boneblack am335x-evmsk am335x-bonegreen am335x-icev2 am335x-pocketbeagle" CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y CONFIG_SPL_ENV_IS_NOWHERE=y CONFIG_BOOTCOUNT_LIMIT=y
Add am335x-pocketbeagle to CONFIG_OF_LIST in am335x_evm_defconfig. Signed-off-by: Vagrant Cascadian <vagrant@debian.org> --- configs/am335x_evm_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)