| Message ID | 20190417124205.7484-1-christian.gmeiner@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | [U-Boot] x86: coreboot: make it possible to process unhandled tags | expand |
On Wed, Apr 17, 2019 at 8:42 PM Christian Gmeiner <christian.gmeiner@gmail.com> wrote: > > coreboot makes it possible to add own entries into coreboot's > table at a per mainboard basis. As there might be some custom > ones it makes sense to provide a way to process them. > > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> > --- > arch/x86/cpu/coreboot/tables.c | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > diff --git a/arch/x86/cpu/coreboot/tables.c b/arch/x86/cpu/coreboot/tables.c > index bc18b710c9..a7c55c7dd1 100644 > --- a/arch/x86/cpu/coreboot/tables.c > +++ b/arch/x86/cpu/coreboot/tables.c > @@ -109,6 +109,8 @@ static void cb_parse_string(unsigned char *ptr, char **info) > *info = (char *)((struct cb_string *)ptr)->string; > } > > +__weak void cb_parse_unhandled(u32 tag, unsigned char *ptr) {} > + nits: I would prefer to have {} in sparate lines. I can fix this when applying. > static int cb_parse_header(void *addr, int len, struct sysinfo_t *info) > { > struct cb_header *header; > @@ -211,6 +213,9 @@ static int cb_parse_header(void *addr, int len, struct sysinfo_t *info) > case CB_TAG_VBNV: > cb_parse_vbnv(ptr, info); > break; > + default: > + cb_parse_unhandled(rec->tag, ptr); > + break; > } > > ptr += rec->size; > --
On Thu, May 16, 2019 at 9:18 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Wed, Apr 17, 2019 at 8:42 PM Christian Gmeiner > <christian.gmeiner@gmail.com> wrote: > > > > coreboot makes it possible to add own entries into coreboot's > > table at a per mainboard basis. As there might be some custom > > ones it makes sense to provide a way to process them. > > > > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> > > --- > > arch/x86/cpu/coreboot/tables.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > > diff --git a/arch/x86/cpu/coreboot/tables.c b/arch/x86/cpu/coreboot/tables.c > > index bc18b710c9..a7c55c7dd1 100644 > > --- a/arch/x86/cpu/coreboot/tables.c > > +++ b/arch/x86/cpu/coreboot/tables.c > > @@ -109,6 +109,8 @@ static void cb_parse_string(unsigned char *ptr, char **info) > > *info = (char *)((struct cb_string *)ptr)->string; > > } > > > > +__weak void cb_parse_unhandled(u32 tag, unsigned char *ptr) {} > > + > > nits: I would prefer to have {} in sparate lines. > > I can fix this when applying. Fixed the nits and applied to u-boot-x86, thanks!
diff --git a/arch/x86/cpu/coreboot/tables.c b/arch/x86/cpu/coreboot/tables.c index bc18b710c9..a7c55c7dd1 100644 --- a/arch/x86/cpu/coreboot/tables.c +++ b/arch/x86/cpu/coreboot/tables.c @@ -109,6 +109,8 @@ static void cb_parse_string(unsigned char *ptr, char **info) *info = (char *)((struct cb_string *)ptr)->string; } +__weak void cb_parse_unhandled(u32 tag, unsigned char *ptr) {} + static int cb_parse_header(void *addr, int len, struct sysinfo_t *info) { struct cb_header *header; @@ -211,6 +213,9 @@ static int cb_parse_header(void *addr, int len, struct sysinfo_t *info) case CB_TAG_VBNV: cb_parse_vbnv(ptr, info); break; + default: + cb_parse_unhandled(rec->tag, ptr); + break; } ptr += rec->size;
coreboot makes it possible to add own entries into coreboot's table at a per mainboard basis. As there might be some custom ones it makes sense to provide a way to process them. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> --- arch/x86/cpu/coreboot/tables.c | 5 +++++ 1 file changed, 5 insertions(+)