| Message ID | 20190325163803.9583-1-marcel@ziswiler.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot,v1] apalis/colibri_imx6: add device trees to makefile | expand |
Hi Marcel, Could you please provide steps to reproduce this issue? I've double checked on the latest master of u-boot-imx, and can sucessfully build U-boot for Colibri iMX6DL (as an example). Thanks On Mon, Mar 25, 2019 at 6:38 PM Marcel Ziswiler <marcel@ziswiler.com> wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > Add device trees to Makefile to avoid newly introduced error: > > Device Tree Source is not correctly specified. > Please define 'CONFIG_DEFAULT_DEVICE_TREE' > or build with 'DEVICE_TREE=<device_tree>' argument > > make[1]: *** [dts/Makefile:28: arch/arm/dts/imx6-apalis.dtb] Error 1 > make: *** [Makefile:1009: dts/dt.dtb] Error 2 > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > > arch/arm/dts/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index e261c5936b..7b7ccfd204 100644 > --- a/arch/arm/dts/Makefile > +++ b/arch/arm/dts/Makefile > @@ -481,6 +481,10 @@ dtb-$(CONFIG_MX6UL) += \ > > dtb-$(CONFIG_MX6ULL) += imx6ull-14x14-evk.dtb > > +dtb-$(CONFIG_ARCH_MX6) += \ > + imx6-apalis.dtb \ > + imx6-colibri.dtb > + > dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \ > imx7d-sdb-qspi.dtb > > -- > 2.20.1 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
Hi Igor On Thu, 2019-03-28 at 16:49 +0000, Igor Opaniuk wrote: > Hi Marcel, > > Could you please provide steps to reproduce this issue? I've double > checked on the latest master of u-boot-imx, and can sucessfully build > U-boot for Colibri iMX6DL (as an example). To be honest I don't remember exactly and can also no longer reproduce what happened. Just back when it happened this fixed it. However, at one point, I remember the discussion about having to add all device trees to the Makefile concluded in not requiring this. So we may also drop this patch then. > Thanks Thank you. Cheers Marcel > On Mon, Mar 25, 2019 at 6:38 PM Marcel Ziswiler <marcel@ziswiler.com> > wrote: > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > Add device trees to Makefile to avoid newly introduced error: > > > > Device Tree Source is not correctly specified. > > Please define 'CONFIG_DEFAULT_DEVICE_TREE' > > or build with 'DEVICE_TREE=<device_tree>' argument > > > > make[1]: *** [dts/Makefile:28: arch/arm/dts/imx6-apalis.dtb] Error > > 1 > > make: *** [Makefile:1009: dts/dt.dtb] Error 2 > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > --- > > > > arch/arm/dts/Makefile | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > > index e261c5936b..7b7ccfd204 100644 > > --- a/arch/arm/dts/Makefile > > +++ b/arch/arm/dts/Makefile > > @@ -481,6 +481,10 @@ dtb-$(CONFIG_MX6UL) += \ > > > > dtb-$(CONFIG_MX6ULL) += imx6ull-14x14-evk.dtb > > > > +dtb-$(CONFIG_ARCH_MX6) += \ > > + imx6-apalis.dtb \ > > + imx6-colibri.dtb > > + > > dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \ > > imx7d-sdb-qspi.dtb > > > > -- > > 2.20.1 > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index e261c5936b..7b7ccfd204 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -481,6 +481,10 @@ dtb-$(CONFIG_MX6UL) += \ dtb-$(CONFIG_MX6ULL) += imx6ull-14x14-evk.dtb +dtb-$(CONFIG_ARCH_MX6) += \ + imx6-apalis.dtb \ + imx6-colibri.dtb + dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \ imx7d-sdb-qspi.dtb