| Message ID | 20190323013002.27117-9-andre.przywara@arm.com |
|---|---|
| State | Accepted |
| Commit | 7b64a70a3a0113f9cd5356b3260d4740edb03265 |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | video/console: Fix various DM_VIDEO console issues | expand |
On Fri, 22 Mar 2019 at 19:32, Andre Przywara <andre.przywara@arm.com> wrote: > > In the sunxi-common.h config header we unconditionally define > CONFIG_SYS_WHITE_ON_BLACK, although it's actually a Kconfig option which > could be individually selected by a user. > Remove this #define from the header and let it default to "y" on sunxi > boards (like we do for other platforms). > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > drivers/video/Kconfig | 2 +- > include/configs/sunxi-common.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Sat, 23 Mar 2019 01:30:02 +0000 Andre Przywara andre.przywara@arm.com wrote: > In the sunxi-common.h config header we unconditionally define > CONFIG_SYS_WHITE_ON_BLACK, although it's actually a Kconfig option which > could be individually selected by a user. > Remove this #define from the header and let it default to "y" on sunxi > boards (like we do for other platforms). > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > drivers/video/Kconfig | 2 +- > include/configs/sunxi-common.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) Applied to u-boot-video/master, thanks! -- Anatolij
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 2eac4b6381..43412873c9 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -120,7 +120,7 @@ config CONSOLE_TRUETYPE_SIZE config SYS_WHITE_ON_BLACK bool "Display console as white on a black background" - default y if ARCH_AT91 || ARCH_EXYNOS || ARCH_ROCKCHIP || TEGRA || X86 + default y if ARCH_AT91 || ARCH_EXYNOS || ARCH_ROCKCHIP || TEGRA || X86 || ARCH_SUNXI help Normally the display is black on a white background, Enable this option to invert this, i.e. white on a black background. This can be diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index b01d1c3c84..ee18260be6 100644 --- a/include/configs/sunxi-common.h +++ b/include/configs/sunxi-common.h @@ -449,7 +449,6 @@ extern int soft_i2c_gpio_scl; "stdout=serial,vga\0" \ "stderr=serial,vga\0" #elif CONFIG_DM_VIDEO -#define CONFIG_SYS_WHITE_ON_BLACK #define CONSOLE_STDOUT_SETTINGS \ "stdout=serial,vidconsole\0" \ "stderr=serial,vidconsole\0"
In the sunxi-common.h config header we unconditionally define CONFIG_SYS_WHITE_ON_BLACK, although it's actually a Kconfig option which could be individually selected by a user. Remove this #define from the header and let it default to "y" on sunxi boards (like we do for other platforms). Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- drivers/video/Kconfig | 2 +- include/configs/sunxi-common.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)