diff mbox series

[U-Boot,v1,2/4] ARM: vf610: ddrmc: fix CR138 preprocessor define

Message ID 20181204101021.22817-3-stefan@agner.ch
State Accepted
Commit b77e368fa27631f13c06acdb0020fb64b59d4411
Delegated to: Stefano Babic
Headers show
Series ddr: vybrid: various fixes | expand

Commit Message

Stefan Agner Dec. 4, 2018, 10:10 a.m. UTC
From: Stefan Agner <stefan.agner@toradex.com>

According to the data sheet bits 10-8 are PHYDRAM_CK_EN. Fix mask
to allow setting PHYDRAM_CK_EN correctly.

Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---

 arch/arm/include/asm/arch-vf610/imx-regs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lukasz Majewski Dec. 4, 2018, 10:57 a.m. UTC | #1
Hi Stefan,

> From: Stefan Agner <stefan.agner@toradex.com>
> 
> According to the data sheet bits 10-8 are PHYDRAM_CK_EN. Fix mask
> to allow setting PHYDRAM_CK_EN correctly.
> 
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> 
>  arch/arm/include/asm/arch-vf610/imx-regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/arch-vf610/imx-regs.h
> b/arch/arm/include/asm/arch-vf610/imx-regs.h index
> 08ba8e94f8..b7374bfb8f 100644 ---
> a/arch/arm/include/asm/arch-vf610/imx-regs.h +++
> b/arch/arm/include/asm/arch-vf610/imx-regs.h @@ -239,7 +239,7 @@
>  #define DDRMC_CR132_RDLAT_ADJ(v)			((v) & 0x3f)
>  #define DDRMC_CR137_PHYCTL_DL(v)			(((v) & 0xf)
> << 16) #define DDRMC_CR138_PHY_WRLV_MXDL(v)
> (((v) & 0xffff) << 16) -#define
> DDRMC_CR138_PHYDRAM_CK_EN(v)			(((v) & 0x8) <<
> 8) +#define DDRMC_CR138_PHYDRAM_CK_EN(v)			(((v)
> & 0x7) << 8) #define
> DDRMC_CR139_PHY_WRLV_RESPLAT(v)			(((v) & 0xff)
> << 24) #define DDRMC_CR139_PHY_WRLV_LOAD(v)
> (((v) & 0xff) << 16) #define
> DDRMC_CR139_PHY_WRLV_DLL(v)			(((v) & 0xff) << 8)

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff mbox series

Patch

diff --git a/arch/arm/include/asm/arch-vf610/imx-regs.h b/arch/arm/include/asm/arch-vf610/imx-regs.h
index 08ba8e94f8..b7374bfb8f 100644
--- a/arch/arm/include/asm/arch-vf610/imx-regs.h
+++ b/arch/arm/include/asm/arch-vf610/imx-regs.h
@@ -239,7 +239,7 @@ 
 #define DDRMC_CR132_RDLAT_ADJ(v)			((v) & 0x3f)
 #define DDRMC_CR137_PHYCTL_DL(v)			(((v) & 0xf) << 16)
 #define DDRMC_CR138_PHY_WRLV_MXDL(v)			(((v) & 0xffff) << 16)
-#define DDRMC_CR138_PHYDRAM_CK_EN(v)			(((v) & 0x8) << 8)
+#define DDRMC_CR138_PHYDRAM_CK_EN(v)			(((v) & 0x7) << 8)
 #define DDRMC_CR139_PHY_WRLV_RESPLAT(v)			(((v) & 0xff) << 24)
 #define DDRMC_CR139_PHY_WRLV_LOAD(v)			(((v) & 0xff) << 16)
 #define DDRMC_CR139_PHY_WRLV_DLL(v)			(((v) & 0xff) << 8)