| Message ID | 20180818202207.10879-1-lukma@denx.de |
|---|---|
| State | Accepted |
| Commit | f008e2600841ff24986fd2b25a8d7498a41f0438 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] ARM: display5: config: Replace hardcoded size of kernel (0x2000) with variable (fitImg_fw_sz) | expand |
Hi Lukasz, On Sat, Aug 18, 2018 at 5:22 PM, Lukasz Majewski <lukma@denx.de> wrote: > This cosmetic change allow easy adjustment of the to-load kernel size if > needed. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Looks good: Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com> Only minor nit is that the Subject like looks excessively large. It could be something more succinct like: display5: Introduce fitImg_fw_sz variable
On Mon, Aug 20, 2018 at 12:57:26PM -0300, Fabio Estevam wrote: > Hi Lukasz, > > On Sat, Aug 18, 2018 at 5:22 PM, Lukasz Majewski <lukma@denx.de> wrote: > > This cosmetic change allow easy adjustment of the to-load kernel size if > > needed. > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > > Looks good: > > Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com> > > Only minor nit is that the Subject like looks excessively large. > > It could be something more succinct like: > > display5: Introduce fitImg_fw_sz variable No need to v2 this 'tho, since it's small and from the listed maintainer I grabbed it and am about to push (but I'll re-word to add the R-b tag).
On Sat, Aug 18, 2018 at 10:22:07PM +0200, Lukasz Majewski wrote: > This cosmetic change allow easy adjustment of the to-load kernel size if > needed. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Applied to u-boot/master, thanks!
diff --git a/include/configs/display5.h b/include/configs/display5.h index fc8261373a..514638f684 100644 --- a/include/configs/display5.h +++ b/include/configs/display5.h @@ -166,7 +166,7 @@ "rootwait rootfstype=ext4 rw; " \ "run set_kernel_part;" \ "part start mmc ${mmcdev} ${kernel_part} lba_start; " \ - "mmc read ${loadaddr} ${lba_start} 0x2000; " \ + "mmc read ${loadaddr} ${lba_start} ${fitImg_fw_sz}; " \ "setenv fdt_conf imx6q-${board}-${display}.dtb; " /* All the numbers are in LBAs */ @@ -273,6 +273,7 @@ "fdt_high=0xffffffff\0" \ "initrd_high=0xffffffff\0" \ "kernel_file=fitImage\0" \ + "fitImg_fw_sz=0x2200\0" \ "up=run tftp_sf_SPL; run tftp_sf_uboot\0" \ "download_kernel=" \ "tftpboot ${loadaddr} ${kernel_file};\0" \
This cosmetic change allow easy adjustment of the to-load kernel size if needed. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- include/configs/display5.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)