| Message ID | 20180727022039.11147-1-peng.fan@nxp.com |
|---|---|
| State | Superseded |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | [U-Boot,V2,1/4] power-domain: add dummy functions when CONFIG_POWER_DOMAIN not defined | expand |
On 26 July 2018 at 20:20, Peng Fan <peng.fan@nxp.com> wrote: > Add dummy functions when CONFIG_POWER_DOMAIN not defined. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > > V2: Use CONFIG_IS_ENABLED > > include/power-domain.h | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org>
Hi Simon, Jaehoon Would you pick up this patchset? https://patchwork.ozlabs.org/patch/949962/ https://patchwork.ozlabs.org/patch/949963/ https://patchwork.ozlabs.org/patch/949964/ https://patchwork.ozlabs.org/patch/949965/ Thanks, Peng. > -----Original Message----- > From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass > Sent: 2018年7月30日 21:27 > To: Peng Fan <peng.fan@nxp.com> > Cc: Jaehoon Chung <jh80.chung@samsung.com>; U-Boot Mailing List > <u-boot@lists.denx.de>; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V2 1/4] power-domain: add dummy functions when > CONFIG_POWER_DOMAIN not defined > > On 26 July 2018 at 20:20, Peng Fan <peng.fan@nxp.com> wrote: > > Add dummy functions when CONFIG_POWER_DOMAIN not defined. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > > > V2: Use CONFIG_IS_ENABLED > > > > include/power-domain.h | 28 ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > Reviewed-by: Simon Glass <sjg@chromium.org>
Hi Peng, On Fri, 27 Jul 2018 10:20:36 +0800 Peng Fan peng.fan@nxp.com wrote: > Add dummy functions when CONFIG_POWER_DOMAIN not defined. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > > V2: Use CONFIG_IS_ENABLED > > include/power-domain.h | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) Applied to u-boot-staging/agust@denx.de, thanks! -- Anatolij
On Mon, 6 Aug 2018 11:09:27 +0200
Anatolij Gustschin agust@denx.de wrote:
...
> Applied to u-boot-staging/agust@denx.de, thanks!
Dropped, it breaks building.
--
Anatolij
diff --git a/include/power-domain.h b/include/power-domain.h index aba8c0f65c..2029b17c6f 100644 --- a/include/power-domain.h +++ b/include/power-domain.h @@ -87,7 +87,14 @@ struct power_domain { * @power_domain A pointer to a power domain struct to initialize. * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_get(struct udevice *dev, struct power_domain *power_domain); +#else +int power_domain_get(struct udevice *dev, struct power_domain *power_domain) +{ + return -EINVAL; +} +#endif /** * power_domain_free - Free a previously requested power domain. @@ -96,7 +103,14 @@ int power_domain_get(struct udevice *dev, struct power_domain *power_domain); * requested by power_domain_get(). * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_free(struct power_domain *power_domain); +#else +int power_domain_free(struct power_domain *power_domain) +{ + return -EINVAL; +} +#endif /** * power_domain_on - Enable power to a power domain. @@ -105,7 +119,14 @@ int power_domain_free(struct power_domain *power_domain); * requested by power_domain_get(). * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_on(struct power_domain *power_domain); +#else +int power_domain_on(struct power_domain *power_domain) +{ + return -EINVAL; +} +#endif /** * power_domain_off - Disable power ot a power domain. @@ -114,6 +135,13 @@ int power_domain_on(struct power_domain *power_domain); * requested by power_domain_get(). * @return 0 if OK, or a negative error code. */ +#if CONFIG_IS_ENABLED(POWER_DOMAIN) int power_domain_off(struct power_domain *power_domain); +#else +int power_domain_off(struct power_domain *power_domain) +{ + return -EINVAL; +} +#endif #endif
Add dummy functions when CONFIG_POWER_DOMAIN not defined. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- V2: Use CONFIG_IS_ENABLED include/power-domain.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)