| Message ID | 20180605211355.6433-3-vagrant@debian.org |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
| Series | arm: odroid: Convert to distro_bootcmd. | expand |
Dear Vagrant Cascadian, 2018년 6월 6일 (수) 06:16, Vagrant Cascadian <vagrant@debian.org>님이 작성: > Adding distro_bootcmd support bumps the default environment size over > 4500. Increase to 16384 to allow for room to grow in the future. > > Signed-off-by: Vagrant Cascadian <vagrant@debian.org> > --- > > include/configs/odroid.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/odroid.h b/include/configs/odroid.h > index b7b75c0dc0..c795ee8c74 100644 > --- a/include/configs/odroid.h > +++ b/include/configs/odroid.h > @@ -50,7 +50,7 @@ > #define CONFIG_SYS_MONITOR_BASE 0x00000000 > > #define CONFIG_SYS_MMC_ENV_DEV CONFIG_MMC_DEFAULT_DEV > -#define CONFIG_ENV_SIZE 4096 > +#define CONFIG_ENV_SIZE 16384 > I think it's better to use SZ_16K. What do you think? #define CONFIG_ENV_OFFSET (SZ_1K * 1280) /* 1.25 MiB offset */ > #define CONFIG_ENV_OVERWRITE > > -- > 2.11.0 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot Thanks, Minkyu Kang.
On 2018-06-07, Minkyu Kang wrote: > 2018년 6월 6일 (수) 06:16, Vagrant Cascadian <vagrant@debian.org>님이 작성: > >> Adding distro_bootcmd support bumps the default environment size over >> 4500. Increase to 16384 to allow for room to grow in the future. >> >> Signed-off-by: Vagrant Cascadian <vagrant@debian.org> >> --- >> >> include/configs/odroid.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/configs/odroid.h b/include/configs/odroid.h >> index b7b75c0dc0..c795ee8c74 100644 >> --- a/include/configs/odroid.h >> +++ b/include/configs/odroid.h >> @@ -50,7 +50,7 @@ >> #define CONFIG_SYS_MONITOR_BASE 0x00000000 >> >> #define CONFIG_SYS_MMC_ENV_DEV CONFIG_MMC_DEFAULT_DEV >> -#define CONFIG_ENV_SIZE 4096 >> +#define CONFIG_ENV_SIZE 16384 >> > > I think it's better to use SZ_16K. > What do you think? No real opinion either way. live well, vagrant
diff --git a/include/configs/odroid.h b/include/configs/odroid.h index b7b75c0dc0..c795ee8c74 100644 --- a/include/configs/odroid.h +++ b/include/configs/odroid.h @@ -50,7 +50,7 @@ #define CONFIG_SYS_MONITOR_BASE 0x00000000 #define CONFIG_SYS_MMC_ENV_DEV CONFIG_MMC_DEFAULT_DEV -#define CONFIG_ENV_SIZE 4096 +#define CONFIG_ENV_SIZE 16384 #define CONFIG_ENV_OFFSET (SZ_1K * 1280) /* 1.25 MiB offset */ #define CONFIG_ENV_OVERWRITE
Adding distro_bootcmd support bumps the default environment size over 4500. Increase to 16384 to allow for room to grow in the future. Signed-off-by: Vagrant Cascadian <vagrant@debian.org> --- include/configs/odroid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)