| Message ID | 20180129182139.12719-1-lukma@denx.de |
|---|---|
| State | Accepted |
| Commit | b76965958c511065cd46ec4be88d862ab65cf06f |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/4] Kconfig: usb: Sort USB_FUNCTION_* entries | expand |
2018-01-30 3:21 GMT+09:00 Lukasz Majewski <lukma@denx.de>: > Lets provide alphabetical order for USB_FUNCTION_* entries of > USB_GADGET_DOWNLOAD > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > --- > > drivers/usb/gadget/Kconfig | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Nit: I want to see the subject prefix "Kconfig:" only for changes in scripts/kconfig/. This case, "usb:" will be preferred. For 2/4 and 3/4, too. > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index c387f5e49792..b1541bb67781 100644 > --- a/drivers/usb/gadget/Kconfig > +++ b/drivers/usb/gadget/Kconfig > @@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD > > if USB_GADGET_DOWNLOAD > > -config USB_FUNCTION_SDP > - bool "Enable USB SDP (Serial Download Protocol)" > - help > - Enable Serial Download Protocol (SDP) device support in U-Boot. This > - allows to download images into memory and execute (jump to) them > - using the same protocol as implemented by the i.MX family's boot ROM. > - > config USB_FUNCTION_ROCKUSB > bool "Enable USB rockusb gadget" > help > @@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB > the rockusb gadget.for more detail about Rockusb protocol, please see > doc/README.rockusb > > +config USB_FUNCTION_SDP > + bool "Enable USB SDP (Serial Download Protocol)" > + help > + Enable Serial Download Protocol (SDP) device support in U-Boot. This > + allows to download images into memory and execute (jump to) them > + using the same protocol as implemented by the i.MX family's boot ROM. > + > endif # USB_GADGET_DOWNLOAD > > config USB_ETHER > -- > 2.11.0 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
Hi Masahiro, > 2018-01-30 3:21 GMT+09:00 Lukasz Majewski <lukma@denx.de>: > > Lets provide alphabetical order for USB_FUNCTION_* entries of > > USB_GADGET_DOWNLOAD > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > > --- > > > > drivers/usb/gadget/Kconfig | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > Nit: > > I want to see the subject prefix "Kconfig:" > only for changes in scripts/kconfig/. > > This case, "usb:" will be preferred. > > For 2/4 and 3/4, too. I will change the topic when preparing v2. Thanks. > > > > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > > index c387f5e49792..b1541bb67781 100644 > > --- a/drivers/usb/gadget/Kconfig > > +++ b/drivers/usb/gadget/Kconfig > > @@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD > > > > if USB_GADGET_DOWNLOAD > > > > -config USB_FUNCTION_SDP > > - bool "Enable USB SDP (Serial Download Protocol)" > > - help > > - Enable Serial Download Protocol (SDP) device support in > > U-Boot. This > > - allows to download images into memory and execute (jump > > to) them > > - using the same protocol as implemented by the i.MX > > family's boot ROM. - > > config USB_FUNCTION_ROCKUSB > > bool "Enable USB rockusb gadget" > > help > > @@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB > > the rockusb gadget.for more detail about Rockusb > > protocol, please see doc/README.rockusb > > > > +config USB_FUNCTION_SDP > > + bool "Enable USB SDP (Serial Download Protocol)" > > + help > > + Enable Serial Download Protocol (SDP) device support in > > U-Boot. This > > + allows to download images into memory and execute (jump > > to) them > > + using the same protocol as implemented by the i.MX > > family's boot ROM. + > > endif # USB_GADGET_DOWNLOAD > > > > config USB_ETHER > > -- > > 2.11.0 > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > > > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
On Mon, Jan 29, 2018 at 07:21:39PM +0100, Lukasz Majewski wrote: > Lets provide alphabetical order for USB_FUNCTION_* entries of > USB_GADGET_DOWNLOAD > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Applied to u-boot/master, thanks!
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index c387f5e49792..b1541bb67781 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -127,13 +127,6 @@ config USB_GADGET_DOWNLOAD if USB_GADGET_DOWNLOAD -config USB_FUNCTION_SDP - bool "Enable USB SDP (Serial Download Protocol)" - help - Enable Serial Download Protocol (SDP) device support in U-Boot. This - allows to download images into memory and execute (jump to) them - using the same protocol as implemented by the i.MX family's boot ROM. - config USB_FUNCTION_ROCKUSB bool "Enable USB rockusb gadget" help @@ -142,6 +135,13 @@ config USB_FUNCTION_ROCKUSB the rockusb gadget.for more detail about Rockusb protocol, please see doc/README.rockusb +config USB_FUNCTION_SDP + bool "Enable USB SDP (Serial Download Protocol)" + help + Enable Serial Download Protocol (SDP) device support in U-Boot. This + allows to download images into memory and execute (jump to) them + using the same protocol as implemented by the i.MX family's boot ROM. + endif # USB_GADGET_DOWNLOAD config USB_ETHER
Lets provide alphabetical order for USB_FUNCTION_* entries of USB_GADGET_DOWNLOAD Signed-off-by: Lukasz Majewski <lukma@denx.de> --- drivers/usb/gadget/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)