| Message ID | 20170704193133.87092-12-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 8620f384098bcc33bbde74b41f37c364552f30c4 |
| Delegated to: | Jaehoon Chung |
| Headers | show |
Hi, On Tue, Jul 04, 2017 at 01:31:28PM -0600, Simon Glass wrote: > This is shown as active high in the schematics[1], so fix it. > > [1] https://patchwork.ozlabs.org/patch/777890/ > > Signed-off-by: Simon Glass <sjg@chromium.org> > Reported-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > > Changes in v2: > - Add new patch to correct polarity of MMC card detect on Linksprite_pcDuino3 > > arch/arm/dts/sun7i-a20-pcduino3.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/dts/sun7i-a20-pcduino3.dts b/arch/arm/dts/sun7i-a20-pcduino3.dts > index 1a8b39be1d..37b1e0ee9b 100644 > --- a/arch/arm/dts/sun7i-a20-pcduino3.dts > +++ b/arch/arm/dts/sun7i-a20-pcduino3.dts > @@ -164,7 +164,7 @@ > pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>; > vmmc-supply = <®_vcc3v3>; > bus-width = <4>; > - cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */ > + cd-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; /* PH1 */ Hmmm, are you sure? At least your commit log says otherwise :) Maxime
Hi Maxime, On 5 July 2017 at 08:43, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Tue, Jul 04, 2017 at 01:31:28PM -0600, Simon Glass wrote: >> This is shown as active high in the schematics[1], so fix it. >> >> [1] https://patchwork.ozlabs.org/patch/777890/ >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> Reported-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> --- >> >> Changes in v2: >> - Add new patch to correct polarity of MMC card detect on Linksprite_pcDuino3 >> >> arch/arm/dts/sun7i-a20-pcduino3.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/dts/sun7i-a20-pcduino3.dts b/arch/arm/dts/sun7i-a20-pcduino3.dts >> index 1a8b39be1d..37b1e0ee9b 100644 >> --- a/arch/arm/dts/sun7i-a20-pcduino3.dts >> +++ b/arch/arm/dts/sun7i-a20-pcduino3.dts >> @@ -164,7 +164,7 @@ >> pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>; >> vmmc-supply = <®_vcc3v3>; >> bus-width = <4>; >> - cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */ >> + cd-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; /* PH1 */ > > Hmmm, are you sure? At least your commit log says otherwise :) The commit message is wrong, unfortunately. The schematics suggest it is active low and it does seem to work with this setting. Regards, Simon
diff --git a/arch/arm/dts/sun7i-a20-pcduino3.dts b/arch/arm/dts/sun7i-a20-pcduino3.dts index 1a8b39be1d..37b1e0ee9b 100644 --- a/arch/arm/dts/sun7i-a20-pcduino3.dts +++ b/arch/arm/dts/sun7i-a20-pcduino3.dts @@ -164,7 +164,7 @@ pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_reference_design>; vmmc-supply = <®_vcc3v3>; bus-width = <4>; - cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */ + cd-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; /* PH1 */ cd-inverted; status = "okay"; };
This is shown as active high in the schematics[1], so fix it. [1] https://patchwork.ozlabs.org/patch/777890/ Signed-off-by: Simon Glass <sjg@chromium.org> Reported-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- Changes in v2: - Add new patch to correct polarity of MMC card detect on Linksprite_pcDuino3 arch/arm/dts/sun7i-a20-pcduino3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)