diff mbox

[U-Boot,1/2] omap3_pandora: Fix mmc loading of autoboot script to use correct syntax.

Message ID 20160829075606.1326-2-vagrant@debian.org
State Accepted
Commit f6eb836e8411daecfa68d410d69832f54f31a985
Delegated to: Tom Rini
Headers show

Commit Message

Vagrant Cascadian Aug. 29, 2016, 7:56 a.m. UTC
fatload/ext2load both require that the device and partition be
specified after specifying the device type. Specify the first
partition on mmc device 0, which is the only mmc device currently
configured on the pandora.

Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
---

 include/configs/omap3_pandora.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

GraÅžvydas Ignotas Aug. 29, 2016, 6:48 p.m. UTC | #1
On Mon, Aug 29, 2016 at 10:56 AM, Vagrant Cascadian <vagrant@debian.org> wrote:
> fatload/ext2load both require that the device and partition be
> specified after specifying the device type. Specify the first
> partition on mmc device 0, which is the only mmc device currently
> configured on the pandora.
>
> Signed-off-by: Vagrant Cascadian <vagrant@debian.org>

Acked-by: Grazvydas Ignotas <notasas@gmail.com>

> ---
>
>  include/configs/omap3_pandora.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/configs/omap3_pandora.h b/include/configs/omap3_pandora.h
> index 380ec12..6ff9375 100644
> --- a/include/configs/omap3_pandora.h
> +++ b/include/configs/omap3_pandora.h
> @@ -93,8 +93,8 @@
>         "mtdparts=" MTDPARTS_DEFAULT "\0" \
>
>  #define CONFIG_BOOTCOMMAND \
> -       "if mmc rescan && fatload mmc1 0 ${loadaddr} autoboot.scr || " \
> -                       "ext2load mmc1 0 ${loadaddr} autoboot.scr; then " \
> +       "if mmc rescan && fatload mmc 0:1 ${loadaddr} autoboot.scr || " \
> +                       "ext2load mmc 0:1 ${loadaddr} autoboot.scr; then " \
>                 "source ${loadaddr}; " \
>         "fi; " \
>         "ubi part boot && ubifsmount ubi:boot && " \
> --
> 2.9.3
>
Tom Rini Sept. 7, 2016, 5:59 p.m. UTC | #2
On Mon, Aug 29, 2016 at 12:56:05AM -0700, Vagrant Cascadian wrote:

> fatload/ext2load both require that the device and partition be
> specified after specifying the device type. Specify the first
> partition on mmc device 0, which is the only mmc device currently
> configured on the pandora.
> 
> Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
> Acked-by: Grazvydas Ignotas <notasas@gmail.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/include/configs/omap3_pandora.h b/include/configs/omap3_pandora.h
index 380ec12..6ff9375 100644
--- a/include/configs/omap3_pandora.h
+++ b/include/configs/omap3_pandora.h
@@ -93,8 +93,8 @@ 
 	"mtdparts=" MTDPARTS_DEFAULT "\0" \
 
 #define CONFIG_BOOTCOMMAND \
-	"if mmc rescan && fatload mmc1 0 ${loadaddr} autoboot.scr || " \
-			"ext2load mmc1 0 ${loadaddr} autoboot.scr; then " \
+	"if mmc rescan && fatload mmc 0:1 ${loadaddr} autoboot.scr || " \
+			"ext2load mmc 0:1 ${loadaddr} autoboot.scr; then " \
 		"source ${loadaddr}; " \
 	"fi; " \
 	"ubi part boot && ubifsmount ubi:boot && " \