diff mbox

[U-Boot,1/2] configs: ti_omap4_common: Include TWL6030 power and I2C support in SPL

Message ID 20160824144042.29354-1-contact@paulk.fr
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Paul Kocialkowski Aug. 24, 2016, 2:40 p.m. UTC
This includes the TWL6030 power driver in SPL, to allow powering up MMC
devices. This is especially relevant when the bootrom didn't power any
MMC device yet but U-Boot is to be loaded from MMC (e.g. after setting
boot mode from the SYS_BOOT pins in peripheral boot).

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 include/configs/ti_omap4_common.h | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Tom Rini Aug. 24, 2016, 3:22 p.m. UTC | #1
On Wed, Aug 24, 2016 at 04:40:41PM +0200, Paul Kocialkowski wrote:

> This includes the TWL6030 power driver in SPL, to allow powering up MMC
> devices. This is especially relevant when the bootrom didn't power any
> MMC device yet but U-Boot is to be loaded from MMC (e.g. after setting
> boot mode from the SYS_BOOT pins in peripheral boot).
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  include/configs/ti_omap4_common.h | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/include/configs/ti_omap4_common.h b/include/configs/ti_omap4_common.h
> index 5fad3c1..7e08887 100644
> --- a/include/configs/ti_omap4_common.h
> +++ b/include/configs/ti_omap4_common.h
> @@ -65,9 +65,7 @@
>  #define CONFIG_CONS_INDEX		3
>  
>  /* TWL6030 */
> -#ifndef CONFIG_SPL_BUILD
>  #define CONFIG_TWL6030_POWER		1
> -#endif
>  
>  /* USB */
>  #define CONFIG_USB_MUSB_UDC			1
> @@ -162,11 +160,4 @@
>  #define CONFIG_SPL_NAND_AM33XX_BCH	/* ELM support */
>  #endif
>  
> -#ifdef CONFIG_SPL_BUILD
> -/* No need for i2c in SPL mode as we will use SRI2C for PMIC access on OMAP4 */
> -#undef CONFIG_SYS_I2C
> -#undef CONFIG_SYS_I2C_OMAP24XX
> -#undef CONFIG_SPL_I2C_SUPPORT
> -#endif
> -
>  #endif /* __CONFIG_TI_OMAP4_COMMON_H */

If nothing calls these functions in SPL they should be gc'd away and we
won't get any size increase.  So in that case:

Reviewed-by: Tom Rini <trini@konsulko.com>
diff mbox

Patch

diff --git a/include/configs/ti_omap4_common.h b/include/configs/ti_omap4_common.h
index 5fad3c1..7e08887 100644
--- a/include/configs/ti_omap4_common.h
+++ b/include/configs/ti_omap4_common.h
@@ -65,9 +65,7 @@ 
 #define CONFIG_CONS_INDEX		3
 
 /* TWL6030 */
-#ifndef CONFIG_SPL_BUILD
 #define CONFIG_TWL6030_POWER		1
-#endif
 
 /* USB */
 #define CONFIG_USB_MUSB_UDC			1
@@ -162,11 +160,4 @@ 
 #define CONFIG_SPL_NAND_AM33XX_BCH	/* ELM support */
 #endif
 
-#ifdef CONFIG_SPL_BUILD
-/* No need for i2c in SPL mode as we will use SRI2C for PMIC access on OMAP4 */
-#undef CONFIG_SYS_I2C
-#undef CONFIG_SYS_I2C_OMAP24XX
-#undef CONFIG_SPL_I2C_SUPPORT
-#endif
-
 #endif /* __CONFIG_TI_OMAP4_COMMON_H */