[U-Boot] buildman: make-flags variables broken?

Hey,

In adding an env-flags section for buildman and trying to test out my
docs, I think I found that the following doesn't work today:
[make-flags]
mipsel-boards=1=2 2=3
qemu_mipsel=${mipsel-boards} 4=5

With a:

as the output.

Hi Tom,

On 22 August 2014 06:08, Tom Rini <trini@ti.com> wrote:
>
> Hey,
>
> In adding an env-flags section for buildman and trying to test out my
> docs, I think I found that the following doesn't work today:
> [make-flags]
> mipsel-boards=1=2 2=3
> qemu_mipsel=${mipsel-boards} 4=5
>
> With a:
> diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
> index 920752c..77118e4 100644
> --- a/tools/buildman/builderthread.py
> +++ b/tools/buildman/builderthread.py
> @@ -203,6 +203,7 @@ class BuilderThread(threading.Thread):
>                  config_args = ['%s_defconfig' % brd.target]
>                  config_out = ''
>                  args.extend(self.builder.toolchains.GetMakeArguments(brd))
> +                print args
>
> I get:
> ['O=build', '-s', '-j', '9', '${mipsel-boards}', '4=5']
>
> as the output.

I have a little list of buiidman/patman things so will add this. I
have not had much time this week and want to figure out the bootm
stuff first. But will get it to it in the next few days.

Regards,
Simon

Hi Tom,

On 22 August 2014 13:40, Simon Glass <sjg@chromium.org> wrote:
> Hi Tom,
>
> On 22 August 2014 06:08, Tom Rini <trini@ti.com> wrote:
>>
>> Hey,
>>
>> In adding an env-flags section for buildman and trying to test out my
>> docs, I think I found that the following doesn't work today:
>> [make-flags]
>> mipsel-boards=1=2 2=3
>> qemu_mipsel=${mipsel-boards} 4=5
>>
>> With a:
>> diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
>> index 920752c..77118e4 100644
>> --- a/tools/buildman/builderthread.py
>> +++ b/tools/buildman/builderthread.py
>> @@ -203,6 +203,7 @@ class BuilderThread(threading.Thread):
>>                  config_args = ['%s_defconfig' % brd.target]
>>                  config_out = ''
>>                  args.extend(self.builder.toolchains.GetMakeArguments(brd))
>> +                print args
>>
>> I get:
>> ['O=build', '-s', '-j', '9', '${mipsel-boards}', '4=5']
>>
>> as the output.
>
> I have a little list of buiidman/patman things so will add this. I
> have not had much time this week and want to figure out the bootm
> stuff first. But will get it to it in the next few days.

The problem is that buildman does not support - and _ in the
variables. I'll add this in a new patch.

Regards,
Simon

On Fri, Aug 22, 2014 at 07:41:03PM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On 22 August 2014 13:40, Simon Glass <sjg@chromium.org> wrote:
> > Hi Tom,
> >
> > On 22 August 2014 06:08, Tom Rini <trini@ti.com> wrote:
> >>
> >> Hey,
> >>
> >> In adding an env-flags section for buildman and trying to test out my
> >> docs, I think I found that the following doesn't work today:
> >> [make-flags]
> >> mipsel-boards=1=2 2=3
> >> qemu_mipsel=${mipsel-boards} 4=5
> >>
> >> With a:
> >> diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
> >> index 920752c..77118e4 100644
> >> --- a/tools/buildman/builderthread.py
> >> +++ b/tools/buildman/builderthread.py
> >> @@ -203,6 +203,7 @@ class BuilderThread(threading.Thread):
> >>                  config_args = ['%s_defconfig' % brd.target]
> >>                  config_out = ''
> >>                  args.extend(self.builder.toolchains.GetMakeArguments(brd))
> >> +                print args
> >>
> >> I get:
> >> ['O=build', '-s', '-j', '9', '${mipsel-boards}', '4=5']
> >>
> >> as the output.
> >
> > I have a little list of buiidman/patman things so will add this. I
> > have not had much time this week and want to figure out the bootm
> > stuff first. But will get it to it in the next few days.
> 
> The problem is that buildman does not support - and _ in the
> variables. I'll add this in a new patch.

Ah, OK.  I was just following the docs of course :)