| Message ID | 20140719215044.GA7150@amd.pavel.ucw.cz |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Hello Pavel, On 19-07-14 23:50, Pavel Machek wrote: > Whitespace cleanups. > > Signed-off-by: Pavel Machek <pavel@denx.de> > > diff --git a/disk/part.c b/disk/part.c > index baceb19..ecc5e7e 100644 > --- a/disk/part.c > +++ b/disk/part.c > @@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc) > > #endif /* any CONFIG_..._PARTITION */ > > -void print_part (block_dev_desc_t * dev_desc) > +void print_part(block_dev_desc_t * dev_desc) > { > > switch (dev_desc->part_type) { > @@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc) > checkpatch says: ;) ERROR: "foo * bar" should be "foo *bar" #26: FILE: disk/part.c:336: +void print_part(block_dev_desc_t * dev_desc) Regards, Jeroen
On Sun 2014-07-20 00:02:37, Jeroen Hofstee wrote: > Hello Pavel, > > On 19-07-14 23:50, Pavel Machek wrote: > >Whitespace cleanups. > > > >Signed-off-by: Pavel Machek <pavel@denx.de> > > > >diff --git a/disk/part.c b/disk/part.c > >index baceb19..ecc5e7e 100644 > >--- a/disk/part.c > >+++ b/disk/part.c > >@@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc) > > #endif /* any CONFIG_..._PARTITION */ > >-void print_part (block_dev_desc_t * dev_desc) > >+void print_part(block_dev_desc_t * dev_desc) > > { > > switch (dev_desc->part_type) { > >@@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc) > > checkpatch says: ;) > > ERROR: "foo * bar" should be "foo *bar" > #26: FILE: disk/part.c:336: > +void print_part(block_dev_desc_t * dev_desc) Yeah, I did not fix _all_ broken whitespace, just some. Note that I'm not adding the error. Pavel
Hello Pavel, On 20-07-14 00:13, Pavel Machek wrote: > On Sun 2014-07-20 00:02:37, Jeroen Hofstee wrote: >> Hello Pavel, >> >> On 19-07-14 23:50, Pavel Machek wrote: >>> Whitespace cleanups. >>> >>> Signed-off-by: Pavel Machek <pavel@denx.de> >>> >>> diff --git a/disk/part.c b/disk/part.c >>> index baceb19..ecc5e7e 100644 >>> --- a/disk/part.c >>> +++ b/disk/part.c >>> @@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc) >>> #endif /* any CONFIG_..._PARTITION */ >>> -void print_part (block_dev_desc_t * dev_desc) >>> +void print_part(block_dev_desc_t * dev_desc) >>> { >>> switch (dev_desc->part_type) { >>> @@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc) >> checkpatch says: ;) >> >> ERROR: "foo * bar" should be "foo *bar" >> #26: FILE: disk/part.c:336: >> +void print_part(block_dev_desc_t * dev_desc) > Yeah, I did not fix _all_ broken whitespace, just some. Note that I'm > not adding the error. > This is only about a line you touch. And patch submissions should be checked by checkpatch or at least mention why you don't comply. Regards, Jeroen
On Sat, Jul 19, 2014 at 11:50:44PM +0200, Pavel Machek wrote: > Whitespace cleanups. > > Signed-off-by: Pavel Machek <pavel@denx.de> Applied to u-boot/master, thanks!
diff --git a/disk/part.c b/disk/part.c index baceb19..ecc5e7e 100644 --- a/disk/part.c +++ b/disk/part.c @@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc) #endif /* any CONFIG_..._PARTITION */ -void print_part (block_dev_desc_t * dev_desc) +void print_part(block_dev_desc_t * dev_desc) { switch (dev_desc->part_type) { @@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc) #endif /* HAVE_BLOCK_DEVICE */ -int get_partition_info(block_dev_desc_t *dev_desc, int part - , disk_partition_t *info) +int get_partition_info(block_dev_desc_t *dev_desc, int part, + disk_partition_t *info) { #ifdef HAVE_BLOCK_DEVICE @@ -511,7 +511,7 @@ int get_device_and_partition(const char *ifname, const char *dev_part_str, disk_partition_t tmpinfo; /* - * Special-case a psuedo block device "hostfs", to allow access to the + * Special-case a pseudo block device "hostfs", to allow access to the * host's own filesystem. */ if (0 == strcmp(ifname, "hostfs")) { diff --git a/include/altera.h b/include/altera.h index 0327a1b..ae5f7ee 100644 --- a/include/altera.h +++ b/include/altera.h @@ -26,7 +26,7 @@ typedef enum { /* typedef Altera_Family */ min_altera_type, /* insert all new types after this */ Altera_ACEX1K, /* ACEX1K Family */ Altera_CYC2, /* CYCLONII Family */ - Altera_StratixII, /* StratixII Familiy */ + Altera_StratixII, /* StratixII Family */ /* Add new models here */ max_altera_type /* insert all new types before this */ } Altera_Family; /* end, typedef Altera_Family */
Whitespace cleanups. Signed-off-by: Pavel Machek <pavel@denx.de>