| Message ID | 20140506112932.22304a36@amdc2363 |
|---|---|
| State | Accepted |
| Delegated to: | Marek Vasut |
| Headers | show |
On Tuesday, May 06, 2014 at 11:29:32 AM, Lukasz Majewski wrote: > Hi Marek, > > The following changes since commit > af41d6b4cb1602abebaaa9c8774a9b0ece564796: > > common: fixed linker-list example (2014-05-05 10:24:13 +0200) > > are available in the git repository at: > > ssh://gu-dfu@git.denx.de/u-boot-dfu master > > for you to fetch changes up to c805776ce7079c7b7dd54c644b499e1b8f6296b1: > > ums: allow the user to specify the device type (2014-05-06 11:13:23 > +0200) > > ---------------------------------------------------------------- > Stephen Warren (9): > usb: ums: add error handling for failed registration > ums: support block devices not MMC devices > ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR > ums: remove error-checking of MMC device size > ums: remove ums_disk_init() > ums: move IO support code to common location > ums: use get_device() not find_mmc_device(); > ums: move all variable declarations to the start of the block > ums: allow the user to specify the device type This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or does it ... ? [1] http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=summary Best regards, Marek Vasut
Hi Marek, > On Tuesday, May 06, 2014 at 11:29:32 AM, Lukasz Majewski wrote: > > Hi Marek, > > > > The following changes since commit > > af41d6b4cb1602abebaaa9c8774a9b0ece564796: > > > > common: fixed linker-list example (2014-05-05 10:24:13 +0200) > > > > are available in the git repository at: > > > > ssh://gu-dfu@git.denx.de/u-boot-dfu master > > > > for you to fetch changes up to > > c805776ce7079c7b7dd54c644b499e1b8f6296b1: > > > > ums: allow the user to specify the device type (2014-05-06 > > 11:13:23 +0200) > > > > ---------------------------------------------------------------- > > Stephen Warren (9): > > usb: ums: add error handling for failed registration > > ums: support block devices not MMC devices > > ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR > > ums: remove error-checking of MMC device size > > ums: remove ums_disk_init() > > ums: move IO support code to common location > > ums: use get_device() not find_mmc_device(); > > ums: move all variable declarations to the start of the block > > ums: allow the user to specify the device type > > This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or > does it ... ? This PR seems outdated :-). I've also added to u-boot-dfu work done Rob Herring in the meantime. I will prepare new PR with those changes included. Thanks for pointing out. > > [1] http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=summary > > Best regards, > Marek Vasut
Hello Lukasz, Am 08.05.2014 08:30, schrieb Lukasz Majewski: > Hi Marek, > >> On Tuesday, May 06, 2014 at 11:29:32 AM, Lukasz Majewski wrote: >>> Hi Marek, >>> >>> The following changes since commit >>> af41d6b4cb1602abebaaa9c8774a9b0ece564796: >>> >>> common: fixed linker-list example (2014-05-05 10:24:13 +0200) >>> >>> are available in the git repository at: >>> >>> ssh://gu-dfu@git.denx.de/u-boot-dfu master >>> >>> for you to fetch changes up to >>> c805776ce7079c7b7dd54c644b499e1b8f6296b1: >>> >>> ums: allow the user to specify the device type (2014-05-06 >>> 11:13:23 +0200) >>> >>> ---------------------------------------------------------------- >>> Stephen Warren (9): >>> usb: ums: add error handling for failed registration >>> ums: support block devices not MMC devices >>> ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR >>> ums: remove error-checking of MMC device size >>> ums: remove ums_disk_init() >>> ums: move IO support code to common location >>> ums: use get_device() not find_mmc_device(); >>> ums: move all variable declarations to the start of the block >>> ums: allow the user to specify the device type >> >> This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or >> does it ... ? > > This PR seems outdated :-). > > I've also added to u-boot-dfu work done Rob Herring in the meantime. > > I will prepare new PR with those changes included. > Thanks for pointing out. Hmm, I have 2 patches pending ... [U-Boot,1/2] musb-new, dfu: first send request answer then call completions http://patchwork.ozlabs.org/patch/337982/ and [U-Boot,v2] dfu, nand: add medium specific polltimeout function http://patchwork.ozlabs.org/patch/338369/ Could you (or Marek) add them? Or are there some issues with them? Thanks! bye, Heiko
Hi Heiko, > Hello Lukasz, > > Am 08.05.2014 08:30, schrieb Lukasz Majewski: > > Hi Marek, > > > >> On Tuesday, May 06, 2014 at 11:29:32 AM, Lukasz Majewski wrote: > >>> Hi Marek, > >>> > >>> The following changes since commit > >>> af41d6b4cb1602abebaaa9c8774a9b0ece564796: > >>> > >>> common: fixed linker-list example (2014-05-05 10:24:13 +0200) > >>> > >>> are available in the git repository at: > >>> > >>> ssh://gu-dfu@git.denx.de/u-boot-dfu master > >>> > >>> for you to fetch changes up to > >>> c805776ce7079c7b7dd54c644b499e1b8f6296b1: > >>> > >>> ums: allow the user to specify the device type (2014-05-06 > >>> 11:13:23 +0200) > >>> > >>> ---------------------------------------------------------------- > >>> Stephen Warren (9): > >>> usb: ums: add error handling for failed registration > >>> ums: support block devices not MMC devices > >>> ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR > >>> ums: remove error-checking of MMC device size > >>> ums: remove ums_disk_init() > >>> ums: move IO support code to common location > >>> ums: use get_device() not find_mmc_device(); > >>> ums: move all variable declarations to the start of the > >>> block ums: allow the user to specify the device type > >> > >> This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or > >> does it ... ? > > > > This PR seems outdated :-). > > > > I've also added to u-boot-dfu work done Rob Herring in the meantime. > > > > I will prepare new PR with those changes included. > > Thanks for pointing out. > > Hmm, I have 2 patches pending ... > > [U-Boot,1/2] musb-new, dfu: first send request answer then call > completions http://patchwork.ozlabs.org/patch/337982/ > > and > > [U-Boot,v2] dfu, nand: add medium specific polltimeout function > http://patchwork.ozlabs.org/patch/338369/ > > Could you (or Marek) add them? Or are there some issues with them? I will test them and if no regressions appear I will add them to u-boot-dfu tree. > > Thanks! > > bye, > Heiko
On Thursday, May 08, 2014 at 09:08:24 AM, Lukasz Majewski wrote: > Hi Heiko, > > > Hello Lukasz, > > > > Am 08.05.2014 08:30, schrieb Lukasz Majewski: > > > Hi Marek, > > > > > >> On Tuesday, May 06, 2014 at 11:29:32 AM, Lukasz Majewski wrote: > > >>> Hi Marek, > > >>> > > >>> The following changes since commit > > >>> > > >>> af41d6b4cb1602abebaaa9c8774a9b0ece564796: > > >>> common: fixed linker-list example (2014-05-05 10:24:13 +0200) > > >>> > > >>> are available in the git repository at: > > >>> ssh://gu-dfu@git.denx.de/u-boot-dfu master > > >>> > > >>> for you to fetch changes up to > > >>> > > >>> c805776ce7079c7b7dd54c644b499e1b8f6296b1: > > >>> ums: allow the user to specify the device type (2014-05-06 > > >>> > > >>> 11:13:23 +0200) > > >>> > > >>> ---------------------------------------------------------------- > > >>> > > >>> Stephen Warren (9): > > >>> usb: ums: add error handling for failed registration > > >>> ums: support block devices not MMC devices > > >>> ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR > > >>> ums: remove error-checking of MMC device size > > >>> ums: remove ums_disk_init() > > >>> ums: move IO support code to common location > > >>> ums: use get_device() not find_mmc_device(); > > >>> ums: move all variable declarations to the start of the > > >>> > > >>> block ums: allow the user to specify the device type > > >> > > >> This doesn't match what's in U-Boot-dfu.git/master [1] it seems. Or > > >> does it ... ? > > > > > > This PR seems outdated :-). > > > > > > I've also added to u-boot-dfu work done Rob Herring in the meantime. > > > > > > I will prepare new PR with those changes included. > > > Thanks for pointing out. > > > > Hmm, I have 2 patches pending ... > > > > [U-Boot,1/2] musb-new, dfu: first send request answer then call > > completions http://patchwork.ozlabs.org/patch/337982/ > > > > and > > > > [U-Boot,v2] dfu, nand: add medium specific polltimeout function > > http://patchwork.ozlabs.org/patch/338369/ > > > > Could you (or Marek) add them? Or are there some issues with them? > > I will test them and if no regressions appear I will add them to > u-boot-dfu tree. Thanks. Best regards, Marek Vasut
Hi Marek, The following changes since commit af41d6b4cb1602abebaaa9c8774a9b0ece564796: common: fixed linker-list example (2014-05-05 10:24:13 +0200) are available in the git repository at: ssh://gu-dfu@git.denx.de/u-boot-dfu master for you to fetch changes up to c805776ce7079c7b7dd54c644b499e1b8f6296b1: ums: allow the user to specify the device type (2014-05-06 11:13:23 +0200) ---------------------------------------------------------------- Stephen Warren (9): usb: ums: add error handling for failed registration ums: support block devices not MMC devices ums: remove UMS_{NUM,START}_SECTORS + UMS_START_SECTOR ums: remove error-checking of MMC device size ums: remove ums_disk_init() ums: move IO support code to common location ums: use get_device() not find_mmc_device(); ums: move all variable declarations to the start of the block ums: allow the user to specify the device type board/samsung/common/Makefile | 1 - board/samsung/common/ums.c | 74 -------------------------------------------------------------------------- common/cmd_usb_mass_storage.c | 91 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------ include/usb_mass_storage.h | 13 ++----------- 4 files changed, 81 insertions(+), 98 deletions(-) delete mode 100644 board/samsung/common/ums.c