mbox series

Pull request for efi-2022-04-rc2

Message ID 16896751-4b7a-501e-1a24-9aa56bbb4c8d@gmx.de
State Changes Requested
Delegated to: Tom Rini
Headers show
Series Pull request for efi-2022-04-rc2 | expand

Pull-request

https://source.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2022-04-rc2

Message

Heinrich Schuchardt Feb. 5, 2022, 1:52 p.m. UTC 
Dear Tom,

The following changes since commit 3aaabfe9ff4bbcd11096513b1b28d1fb0a40800f:

   Merge branch 'master' of
https://source.denx.de/u-boot/custodians/u-boot-sunxi (2022-02-03
23:24:31 -0500)

are available in the Git repository at:

   https://source.denx.de/u-boot/custodians/u-boot-efi.git
tags/efi-2022-04-rc2

for you to fetch changes up to 8296548fe924678d9ac19ea3f69dca2fff879ab5:

   test/py: efi_capsule: check the results in case of
CAPSULE_AUTHENTICATE (2022-02-05 10:35:32 +0100)

Gitlab CI showed no issues:

https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/10864

----------------------------------------------------------------
Pull request for efi-2022-04-rc2

Documentation:

* man-page for mkeficapsule

UEFI

* add UEFI firmware image signing to mkeficapsule
* provide firmware image authentication test
* add unit test for RISCV_EFI_BOOT_PROTOCOL
* disable UEFI for Colibri VF610
* add handle for UART
* fix printing of Unicode strings
* simplify enumeration of block devices

----------------------------------------------------------------
AKASHI Takahiro (9):
       tools: build mkeficapsule with tools-only_defconfig
       tools: mkeficapsule: add firmware image signing
       tools: mkeficapsule: add man page
       doc: update UEFI document for usage of mkeficapsule
       test/py: efi_capsule: add image authentication test
       tools: mkeficapsule: allow for specifying GUID explicitly
       test/py: efi_capsule: align with the syntax change of mkeficapsule
       test/py: efi_capsule: add a test for "--guid" option
       test/py: efi_capsule: check the results in case of
CAPSULE_AUTHENTICATE

Heinrich Schuchardt (9):
       configs: disable UEFI for Colibri VF610
       efi_selftest: merge FDT and RISC-V tests
       lib: fix snprintf() for UTF-16 strings
       test: test UTF-16 truncation in snprintf()
       efi_loader: fix device path to text protocol
       efi_loader: use %zu not %zd to print efi_uintn_t
       efi_loader: use %zu to print efi_uintn_t in FMP driver
       efi_loader: fix text output for Uart() DP nodes
       efi_loader: add handle for UART

Simon Glass (3):
       efi: Add debugging to efi_set_bootdev()
       efi: Use device_get_uclass_id() where appropriate
       efi: Drop unnecessary calls to blk_find_device()

Sunil V L (1):
       efi_selftest: unit test for RISCV_EFI_BOOT_PROTOCOL

  MAINTAINERS                                        |   1 +
  cmd/bootefi.c                                      |  32 +-
  configs/colibri_vf_defconfig                       |   2 +-
  configs/tools-only_defconfig                       |   1 +
  doc/develop/uefi/uefi.rst                          | 147 +++----
  doc/mkeficapsule.1                                 | 111 +++++
  include/efi_loader.h                               |   1 +
  lib/efi_loader/efi_boottime.c                      |   6 +-
  lib/efi_loader/efi_console.c                       |  52 ++-
  lib/efi_loader/efi_device_path.c                   |  24 +-
  lib/efi_loader/efi_device_path_to_text.c           |  45 +-
  lib/efi_loader/efi_firmware.c                      |   4 +-
  lib/efi_selftest/efi_selftest_fdt.c                |  72 +++-
  lib/vsprintf.c                                     |  14 +-
  test/py/tests/test_efi_capsule/capsule_defs.py     |   5 +
  test/py/tests/test_efi_capsule/conftest.py         |  59 ++-
  test/py/tests/test_efi_capsule/signature.dts       |  10 +
  .../test_efi_capsule/test_capsule_firmware.py      |  91 +++-
  .../test_capsule_firmware_signed.py                | 254 ++++++++++++
  test/unicode_ut.c                                  |  31 ++
  tools/Kconfig                                      |   8 +
  tools/Makefile                                     |   4 +-
  tools/eficapsule.h                                 | 115 ++++++
  tools/mkeficapsule.c                               | 459
++++++++++++++++++---
  24 files changed, 1320 insertions(+), 228 deletions(-)
  create mode 100644 doc/mkeficapsule.1
  create mode 100644 test/py/tests/test_efi_capsule/signature.dts
  create mode 100644
test/py/tests/test_efi_capsule/test_capsule_firmware_signed.py
  create mode 100644 tools/eficapsule.h

Comments

Tom Rini Feb. 5, 2022, 4:50 p.m. UTC | #1 
On Sat, Feb 05, 2022 at 02:52:17PM +0100, Heinrich Schuchardt wrote:

> Dear Tom,
> 
> The following changes since commit 3aaabfe9ff4bbcd11096513b1b28d1fb0a40800f:
> 
>   Merge branch 'master' of
> https://source.denx.de/u-boot/custodians/u-boot-sunxi (2022-02-03
> 23:24:31 -0500)
> 
> are available in the Git repository at:
> 
>   https://source.denx.de/u-boot/custodians/u-boot-efi.git
> tags/efi-2022-04-rc2
> 
> for you to fetch changes up to 8296548fe924678d9ac19ea3f69dca2fff879ab5:
> 
>   test/py: efi_capsule: check the results in case of
> CAPSULE_AUTHENTICATE (2022-02-05 10:35:32 +0100)
> 
> Gitlab CI showed no issues:
> 
> https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/10864
> 

NAK, this breaks host tools on Windows and macOS:
https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3589&view=results
Heinrich Schuchardt Feb. 5, 2022, 7:07 p.m. UTC | #2 
On 2/5/22 17:50, Tom Rini wrote:
> On Sat, Feb 05, 2022 at 02:52:17PM +0100, Heinrich Schuchardt wrote:
>
>> Dear Tom,
>>
>> The following changes since commit 3aaabfe9ff4bbcd11096513b1b28d1fb0a40800f:
>>
>>    Merge branch 'master' of
>> https://source.denx.de/u-boot/custodians/u-boot-sunxi (2022-02-03
>> 23:24:31 -0500)
>>
>> are available in the Git repository at:
>>
>>    https://source.denx.de/u-boot/custodians/u-boot-efi.git
>> tags/efi-2022-04-rc2
>>
>> for you to fetch changes up to 8296548fe924678d9ac19ea3f69dca2fff879ab5:
>>
>>    test/py: efi_capsule: check the results in case of
>> CAPSULE_AUTHENTICATE (2022-02-05 10:35:32 +0100)
>>
>> Gitlab CI showed no issues:
>>
>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/10864
>>
>
> NAK, this breaks host tools on Windows and macOS:
> https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3589&view=results
>

I will create a new pull request without the mkeficapsule.c changes.

@Takahiro:
Please, address the issues.

https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/3589/logs/128:

2022-02-05T16:53:55.9574749Z   HOSTCC  tools/mkeficapsule
2022-02-05T16:53:56.1341775Z tools/mkeficapsule.c:18:10: fatal error:
uuid/uuid.h: No such file or directory
2022-02-05T16:53:56.1343964Z    18 | #include <uuid/uuid.h>
2022-02-05T16:53:56.1344702Z       |          ^~~~~~~~~~~~~
2022-02-05T16:53:56.1347501Z compilation terminated.
2022-02-05T16:53:56.1392680Z make[2]: *** [scripts/Makefile.host:95:
tools/mkeficapsule] Error 1

Instead of adding a dependency on uuid-dev it might be better to write
your own uuid_parse() function.

https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/3589/logs/122

Please, do not include malloc.h. The function malloc() is declared via
stdlib.h.

Best regards

Heinrich
Heinrich Schuchardt Feb. 5, 2022, 7:29 p.m. UTC | #3 
On 2/5/22 20:07, Heinrich Schuchardt wrote:
> On 2/5/22 17:50, Tom Rini wrote:
>> On Sat, Feb 05, 2022 at 02:52:17PM +0100, Heinrich Schuchardt wrote:
>>
>>> Dear Tom,
>>>
>>> The following changes since commit
>>> 3aaabfe9ff4bbcd11096513b1b28d1fb0a40800f:
>>>
>>>    Merge branch 'master' of
>>> https://source.denx.de/u-boot/custodians/u-boot-sunxi (2022-02-03
>>> 23:24:31 -0500)
>>>
>>> are available in the Git repository at:
>>>
>>>    https://source.denx.de/u-boot/custodians/u-boot-efi.git
>>> tags/efi-2022-04-rc2
>>>
>>> for you to fetch changes up to 8296548fe924678d9ac19ea3f69dca2fff879ab5:
>>>
>>>    test/py: efi_capsule: check the results in case of
>>> CAPSULE_AUTHENTICATE (2022-02-05 10:35:32 +0100)
>>>
>>> Gitlab CI showed no issues:
>>>
>>> https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/10864
>>>
>>
>> NAK, this breaks host tools on Windows and macOS:
>> https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3589&view=results
>>
>>
>
> I will create a new pull request without the mkeficapsule.c changes.
>
> @Takahiro:
> Please, address the issues.
>
> https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/3589/logs/128:
>
>
> 2022-02-05T16:53:55.9574749Z   HOSTCC  tools/mkeficapsule
> 2022-02-05T16:53:56.1341775Z tools/mkeficapsule.c:18:10: fatal error:
> uuid/uuid.h: No such file or directory
> 2022-02-05T16:53:56.1343964Z    18 | #include <uuid/uuid.h>
> 2022-02-05T16:53:56.1344702Z       |          ^~~~~~~~~~~~~
> 2022-02-05T16:53:56.1347501Z compilation terminated.
> 2022-02-05T16:53:56.1392680Z make[2]: *** [scripts/Makefile.host:95:
> tools/mkeficapsule] Error 1
>
> Instead of adding a dependency on uuid-dev it might be better to write
> your own uuid_parse() function.
>
> https://dev.azure.com/u-boot/a1096300-2999-4ec4-a21a-4c22075e3771/_apis/build/builds/3589/logs/122
>
>
> Please, do not include malloc.h. The function malloc() is declared via
> stdlib.h.
>
> Best regards
>
> Heinrich

https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html
describes how to trigger the Azure pipelines using a pull request on Github.

Please, trigger the test before resubmitting.

Best regards

Heinrich