| Message ID | 1584612256-1679-1-git-send-email-kuldeep.singh@nxp.com |
|---|---|
| State | Accepted |
| Commit | 206f37547e2c0f6d9bb2c37bc51d71f87e965bae |
| Delegated to: | Priyanka Jain |
| Headers | show |
| Series | configs: ls2088ardb: Correct DEFAULT_DEVICE_TREE value | expand |
>-----Original Message----- >From: Kuldeep Singh <kuldeep.singh@nxp.com> >Sent: Thursday, March 19, 2020 3:34 PM >To: u-boot@lists.denx.de >Cc: Priyanka Jain <priyanka.jain@nxp.com>; Kuldeep Singh ><kuldeep.singh@nxp.com> >Subject: [PATCH] configs: ls2088ardb: Correct DEFAULT_DEVICE_TREE value > >LS2088A-RDB has CONFIG_DEFAULT_DEVICE_TREE value correctly set as "fsl- >ls2088a-rdb-qspi" for QSPI secure/non-secure boot and TFA non-secure boot >mode. > For ls2088ardb, default boot source is NOR, why we want to change it to QSPI? Infact, LS2088A-RDB should also use CONFIG_DEFAULT_DEVICE_TREE "fsl-ls2080a-rdb" Priyanka >Fix the value for TFA secure boot mode. > >Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> >--- > configs/ls2088ardb_tfa_SECURE_BOOT_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig >b/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig >index c0d0a99..7039cf5 100644 >--- a/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig >+++ b/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig >@@ -31,7 +31,7 @@ CONFIG_CMD_USB=y > CONFIG_CMD_CACHE=y > CONFIG_MP=y > CONFIG_OF_CONTROL=y >-CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2080a-rdb" >+CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2088a-rdb-qspi" > CONFIG_NET_RANDOM_ETHADDR=y > CONFIG_DM=y > CONFIG_SATA_CEVA=y >-- >2.7.4
> -----Original Message----- > From: Priyanka Jain <priyanka.jain@nxp.com> > Sent: Friday, April 17, 2020 2:38 PM > To: Kuldeep Singh <kuldeep.singh@nxp.com>; u-boot@lists.denx.de; Wasim > Khan <wasim.khan@nxp.com> > Cc: Kuldeep Singh <kuldeep.singh@nxp.com> > Subject: RE: [PATCH] configs: ls2088ardb: Correct DEFAULT_DEVICE_TREE value > > >-----Original Message----- > >From: Kuldeep Singh <kuldeep.singh@nxp.com> > >Sent: Thursday, March 19, 2020 3:34 PM > >To: u-boot@lists.denx.de > >Cc: Priyanka Jain <priyanka.jain@nxp.com>; Kuldeep Singh > ><kuldeep.singh@nxp.com> > >Subject: [PATCH] configs: ls2088ardb: Correct DEFAULT_DEVICE_TREE value > > > >LS2088A-RDB has CONFIG_DEFAULT_DEVICE_TREE value correctly set as "fsl- > >ls2088a-rdb-qspi" for QSPI secure/non-secure boot and TFA non-secure > >boot mode. > > > For ls2088ardb, default boot source is NOR, why we want to change it to QSPI? > Infact, LS2088A-RDB should also use CONFIG_DEFAULT_DEVICE_TREE "fsl- > ls2080a-rdb" > > Priyanka It does not impact the NOR boot case and fsl-ls2088a-rdb-qspi.dts provides additional nodes for qspi flash and i2c. Reviewed . > >Fix the value for TFA secure boot mode. > > > >Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> > >--- > > configs/ls2088ardb_tfa_SECURE_BOOT_defconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig > >b/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig > >index c0d0a99..7039cf5 100644 > >--- a/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig > >+++ b/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig > >@@ -31,7 +31,7 @@ CONFIG_CMD_USB=y > > CONFIG_CMD_CACHE=y > > CONFIG_MP=y > > CONFIG_OF_CONTROL=y > >-CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2080a-rdb" > >+CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2088a-rdb-qspi" > > CONFIG_NET_RANDOM_ETHADDR=y > > CONFIG_DM=y > > CONFIG_SATA_CEVA=y > >-- > >2.7.4
[...] > It does not impact the NOR boot case and fsl-ls2088a-rdb-qspi.dts provides > additional nodes for qspi flash and i2c. > Reviewed . Priyanka, Since Wasim has reviewed the patch maybe we can proceed with his "reviewed-by" tag. -Kuldeep
>-----Original Message----- >From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Kuldeep Singh >Sent: Thursday, March 19, 2020 3:34 PM >To: u-boot@lists.denx.de >Cc: Priyanka Jain <priyanka.jain@nxp.com>; Kuldeep Singh ><kuldeep.singh@nxp.com> >Subject: [PATCH] configs: ls2088ardb: Correct DEFAULT_DEVICE_TREE value > >LS2088A-RDB has CONFIG_DEFAULT_DEVICE_TREE value correctly set as "fsl- >ls2088a-rdb-qspi" for QSPI secure/non-secure boot and TFA non-secure boot >mode. > >Fix the value for TFA secure boot mode. > >Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> >--- Applied to fsl-qoriq. Awaiting upstream Thanks Priyanka
diff --git a/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig b/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig index c0d0a99..7039cf5 100644 --- a/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig +++ b/configs/ls2088ardb_tfa_SECURE_BOOT_defconfig @@ -31,7 +31,7 @@ CONFIG_CMD_USB=y CONFIG_CMD_CACHE=y CONFIG_MP=y CONFIG_OF_CONTROL=y -CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2080a-rdb" +CONFIG_DEFAULT_DEVICE_TREE="fsl-ls2088a-rdb-qspi" CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y CONFIG_SATA_CEVA=y
LS2088A-RDB has CONFIG_DEFAULT_DEVICE_TREE value correctly set as "fsl-ls2088a-rdb-qspi" for QSPI secure/non-secure boot and TFA non-secure boot mode. Fix the value for TFA secure boot mode. Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com> --- configs/ls2088ardb_tfa_SECURE_BOOT_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)