| Message ID | 1547065524-30336-1-git-send-email-praneeth@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] arm: ti: boot: Fix am57xx evm fdtfile name | expand |
On 1/10/2019 1:55 AM, Praneeth Bajjuri wrote: > am57xx evm uses am57xx-evm-reva3.dtb. > update findfdt to pick the correct default dtb > > Signed-off-by: Praneeth Bajjuri <praneeth@ti.com> > --- > include/environment/ti/boot.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h > index 86ff6d3ea7c6..c9ad3046acaa 100644 > --- a/include/environment/ti/boot.h > +++ b/include/environment/ti/boot.h > @@ -125,7 +125,7 @@ > "if test $board_name = am57xx_evm; then " \ > "setenv fdtfile am57xx-beagle-x15.dtb; fi;" \ > "if test $board_name = am57xx_evm_reva3; then " \ > - "setenv fdtfile am57xx-beagle-x15.dtb; fi;" \ > + "setenv fdtfile am57xx-evm-reva3.dtb; fi;" \ I do not see this dts in kernel. Either it is not upstream or we are suposed to use overlays in this case. Thanks and regards, Lokesh > "if test $board_name = am571x_idk; then " \ > "setenv fdtfile am571x-idk.dtb; fi;" \ > "if test $fdtfile = undefined; then " \ >
Hi Lokesh, On Thu, Jan 10, 2019 at 4:47 AM Lokesh Vutla <lokeshvutla@ti.com> wrote: > > > > On 1/10/2019 1:55 AM, Praneeth Bajjuri wrote: > > am57xx evm uses am57xx-evm-reva3.dtb. > > update findfdt to pick the correct default dtb > > > > Signed-off-by: Praneeth Bajjuri <praneeth@ti.com> > > --- > > include/environment/ti/boot.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h > > index 86ff6d3ea7c6..c9ad3046acaa 100644 > > --- a/include/environment/ti/boot.h > > +++ b/include/environment/ti/boot.h > > @@ -125,7 +125,7 @@ > > "if test $board_name = am57xx_evm; then " \ > > "setenv fdtfile am57xx-beagle-x15.dtb; fi;" \ > > "if test $board_name = am57xx_evm_reva3; then " \ > > - "setenv fdtfile am57xx-beagle-x15.dtb; fi;" \ > > + "setenv fdtfile am57xx-evm-reva3.dtb; fi;" \ > > I do not see this dts in kernel. Either it is not upstream or we are > suposed to use overlays in this case. > Agreed. We should target upstream kernel in upstream U-Boot. So we should either: 1. Add corresponding dtb/dtbo files for AM57x EVM in upstream kernel first 2. Or drop this patch and continue using X15 dtb for EVM. As I understand, (1) is not going to happen any time soon (though I would prefer this solution, as EVM already happened and being used). So we should probably stick to (2). > Thanks and regards, > Lokesh > > > "if test $board_name = am571x_idk; then " \ > > "setenv fdtfile am571x-idk.dtb; fi;" \ > > "if test $fdtfile = undefined; then " \ > >
diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h index 86ff6d3ea7c6..c9ad3046acaa 100644 --- a/include/environment/ti/boot.h +++ b/include/environment/ti/boot.h @@ -125,7 +125,7 @@ "if test $board_name = am57xx_evm; then " \ "setenv fdtfile am57xx-beagle-x15.dtb; fi;" \ "if test $board_name = am57xx_evm_reva3; then " \ - "setenv fdtfile am57xx-beagle-x15.dtb; fi;" \ + "setenv fdtfile am57xx-evm-reva3.dtb; fi;" \ "if test $board_name = am571x_idk; then " \ "setenv fdtfile am571x-idk.dtb; fi;" \ "if test $fdtfile = undefined; then " \
am57xx evm uses am57xx-evm-reva3.dtb. update findfdt to pick the correct default dtb Signed-off-by: Praneeth Bajjuri <praneeth@ti.com> --- include/environment/ti/boot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)