| Message ID | 1544012976.2465.3.camel@denx.de |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [U-Boot] pcm058: fix NAND flash not using badblock table | expand |
On 05/12/18 13:29, Harald Seiler wrote: > Without setting this flag, U-Boot will silently use a memory > only badblock table. This is not only bad because it means badblock > info is ignored, but also leads to other issues if a driver ontop > then tries to read the badblock table as filesystem info (eg. UBI). > Comment is not consistent and does not really explain what happens - can you formulate it again ? Thanks ! Best regards, Stefano Babic > Signed-off-by: Harald Seiler <hws@denx.de> > --- > include/configs/pcm058.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/pcm058.h b/include/configs/pcm058.h > index 49048c163f..b9bc08b388 100644 > --- a/include/configs/pcm058.h > +++ b/include/configs/pcm058.h > @@ -55,6 +55,7 @@ > #define CONFIG_SYS_NAND_BASE 0x40000000 > #define CONFIG_SYS_NAND_5_ADDR_CYCLE > #define CONFIG_SYS_NAND_ONFI_DETECTION > +#define CONFIG_SYS_NAND_USE_FLASH_BBT > #endif > > /* DMA stuff, needed for GPMI/MXS NAND support */ >
diff --git a/include/configs/pcm058.h b/include/configs/pcm058.h index 49048c163f..b9bc08b388 100644 --- a/include/configs/pcm058.h +++ b/include/configs/pcm058.h @@ -55,6 +55,7 @@ #define CONFIG_SYS_NAND_BASE 0x40000000 #define CONFIG_SYS_NAND_5_ADDR_CYCLE #define CONFIG_SYS_NAND_ONFI_DETECTION +#define CONFIG_SYS_NAND_USE_FLASH_BBT #endif /* DMA stuff, needed for GPMI/MXS NAND support */
Without setting this flag, U-Boot will silently use a memory only badblock table. This is not only bad because it means badblock info is ignored, but also leads to other issues if a driver ontop then tries to read the badblock table as filesystem info (eg. UBI). Signed-off-by: Harald Seiler <hws@denx.de> --- include/configs/pcm058.h | 1 + 1 file changed, 1 insertion(+)