diff mbox series

[U-Boot,v2,5/5] x86: cpu: add docstring to scu_ipc_command()

Message ID 1536071645-25229-6-git-send-email-georgii.staroselskii@emlid.com
State Superseded
Delegated to: Bin Meng
Headers show
Series Add a pinctrl driver for Merrifield to pinmux I2C#6 | expand

Commit Message

Georgii Staroselskii Sept. 4, 2018, 2:34 p.m. UTC
These comments were copied from the Linux kernel driver in
drivers/platform/x86/intel_scu_ipc.c

Signed-off-by: Georgii Staroselskii <georgii.staroselskii@emlid.com>
---
 arch/x86/lib/scu.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Andy Shevchenko Sept. 4, 2018, 2:58 p.m. UTC | #1
On Tue, Sep 4, 2018 at 5:37 PM Georgii Staroselskii
<georgii.staroselskii@emlid.com> wrote:
>
> These comments were copied from the Linux kernel driver in
> drivers/platform/x86/intel_scu_ipc.c
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Georgii Staroselskii <georgii.staroselskii@emlid.com>
> ---
>  arch/x86/lib/scu.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/x86/lib/scu.c b/arch/x86/lib/scu.c
> index 4054838..ab945d2 100644
> --- a/arch/x86/lib/scu.c
> +++ b/arch/x86/lib/scu.c
> @@ -180,6 +180,17 @@ int scu_ipc_simple_command(u32 cmd, u32 sub)
>         return scu_ipc_check_status(scu->regs);
>  }
>
> +/**
> + *  scu_ipc_command   -   command with data
> + *  @cmd: command
> + *  @sub: sub type
> + *  @in: input data
> + *  @inlen: input length in dwords
> + *  @out: output data
> + *  @outlen: output length in dwords
> + *
> + *  Issue a command to the SCU which involves data transfers.
> + */
>  int scu_ipc_command(u32 cmd, u32 sub, u32 *in, int inlen, u32 *out, int outlen)
>  {
>         struct scu *scu;
> --
> 2.7.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
diff mbox series

Patch

diff --git a/arch/x86/lib/scu.c b/arch/x86/lib/scu.c
index 4054838..ab945d2 100644
--- a/arch/x86/lib/scu.c
+++ b/arch/x86/lib/scu.c
@@ -180,6 +180,17 @@  int scu_ipc_simple_command(u32 cmd, u32 sub)
 	return scu_ipc_check_status(scu->regs);
 }
 
+/**
+ *  scu_ipc_command   -   command with data
+ *  @cmd: command
+ *  @sub: sub type
+ *  @in: input data
+ *  @inlen: input length in dwords
+ *  @out: output data
+ *  @outlen: output length in dwords
+ *
+ *  Issue a command to the SCU which involves data transfers.
+ */
 int scu_ipc_command(u32 cmd, u32 sub, u32 *in, int inlen, u32 *out, int outlen)
 {
 	struct scu *scu;