| Message ID | 1532422712-15107-3-git-send-email-patrick.delaunay@st.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | dm: led: remove auto probe in binding function | expand |
On 24 July 2018 at 02:58, Patrick Delaunay <patrick.delaunay@st.com> wrote: > > This reverts commit bc882f5d5c7b4d6ed5e927bf838863af43c786e7. > because this patch adds the probe of LED driver during the > binding phasis. It is not allowed in driver model because > the drivers (clock, pincontrol) needed by the LED driver can > be also probed before the binding of all the device and > it is a source of problems. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > Changes in v3: > - add motivation in revert commit > > Changes in v2: None > > drivers/led/led_gpio.c | 9 --------- > 1 file changed, 9 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/drivers/led/led_gpio.c b/drivers/led/led_gpio.c index a36942b..533587d 100644 --- a/drivers/led/led_gpio.c +++ b/drivers/led/led_gpio.c @@ -10,7 +10,6 @@ #include <led.h> #include <asm/gpio.h> #include <dm/lists.h> -#include <dm/uclass-internal.h> struct led_gpio_priv { struct gpio_desc gpio; @@ -118,14 +117,6 @@ static int led_gpio_bind(struct udevice *parent) return ret; uc_plat = dev_get_uclass_platdata(dev); uc_plat->label = label; - - if (ofnode_read_bool(node, "default-state")) { - struct udevice *devp; - - ret = uclass_get_device_tail(dev, 0, &devp); - if (ret) - return ret; - } } return 0;
This reverts commit bc882f5d5c7b4d6ed5e927bf838863af43c786e7. because this patch adds the probe of LED driver during the binding phasis. It is not allowed in driver model because the drivers (clock, pincontrol) needed by the LED driver can be also probed before the binding of all the device and it is a source of problems. Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- Changes in v3: - add motivation in revert commit Changes in v2: None drivers/led/led_gpio.c | 9 --------- 1 file changed, 9 deletions(-)