diff mbox series

[U-Boot] mtd: nand: add new enum for storing ECC algorithm

Message ID 1531216088-2449-1-git-send-email-philippe.reynes@softathome.com
State Accepted
Commit 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784
Delegated to: Tom Rini
Headers show
Series [U-Boot] mtd: nand: add new enum for storing ECC algorithm | expand

Commit Message

Philippe REYNES July 10, 2018, 9:48 a.m. UTC 
From: Rafał Miłecki <zajec5@gmail.com>

Our nand_ecc_modes_t is already a bit abused by value NAND_ECC_SOFT_BCH.
This enum should store ECC mode only and putting algorithm details there
is a bad idea. It would result in too many values impossible to support
in a sane way.

To solve this problem let's add a new enum. We'll have to modify all
drivers to set it properly but once it's done it'll be possible to drop
NAND_ECC_SOFT_BCH. That will result in a cleaner design and more
possibilities like setting ECC algorithm for hardware ECC mode.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
[Linux commit: b0fcd8ab7b3c89b5da7fff5224d06ed73e7a33cc]
[Philippe Reynes: adapt code to u-boot]
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
 include/linux/mtd/rawnand.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Tom Rini July 24, 2018, 12:39 p.m. UTC | #1 
On Tue, Jul 10, 2018 at 11:48:08AM +0200, Philippe Reynes wrote:

> From: Rafał Miłecki <zajec5@gmail.com>
> 
> Our nand_ecc_modes_t is already a bit abused by value NAND_ECC_SOFT_BCH.
> This enum should store ECC mode only and putting algorithm details there
> is a bad idea. It would result in too many values impossible to support
> in a sane way.
> 
> To solve this problem let's add a new enum. We'll have to modify all
> drivers to set it properly but once it's done it'll be possible to drop
> NAND_ECC_SOFT_BCH. That will result in a cleaner design and more
> possibilities like setting ECC algorithm for hardware ECC mode.
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> [Linux commit: b0fcd8ab7b3c89b5da7fff5224d06ed73e7a33cc]
> [Philippe Reynes: adapt code to u-boot]
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index cdad7b8..9f5dc81 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -143,6 +143,12 @@  typedef enum {
 	NAND_ECC_SOFT_BCH,
 } nand_ecc_modes_t;
 
+enum nand_ecc_algo {
+	NAND_ECC_UNKNOWN,
+	NAND_ECC_HAMMING,
+	NAND_ECC_BCH,
+};
+
 /*
  * Constants for Hardware ECC
  */
@@ -533,6 +539,7 @@  static const struct nand_ecc_caps __name = {			\
 /**
  * struct nand_ecc_ctrl - Control structure for ECC
  * @mode:	ECC mode
+ * @algo:	ECC algorithm
  * @steps:	number of ECC steps per page
  * @size:	data bytes per ECC step
  * @bytes:	ECC bytes per step
@@ -583,6 +590,7 @@  static const struct nand_ecc_caps __name = {			\
  */
 struct nand_ecc_ctrl {
 	nand_ecc_modes_t mode;
+	enum nand_ecc_algo algo;
 	int steps;
 	int size;
 	int bytes;