diff mbox series

[U-Boot] configs: Disable 4k erase sector size for spansion "s25fs512s" flash

Message ID 1529922650-22542-1-git-send-email-Ashish.Kumar@nxp.com
State Superseded
Delegated to: York Sun
Headers show
Series [U-Boot] configs: Disable 4k erase sector size for spansion "s25fs512s" flash | expand

Commit Message

Ashish Kumar June 25, 2018, 10:30 a.m. UTC
4K erase size is used only in case of hydrid mode which is not
supported on any NXP platform with flash "s25fs512s".
Supported mode is uniform sector, with erase size 256kiB.

Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
---
 configs/ls1046aqds_qspi_defconfig                    | 1 +
 configs/ls1046aqds_sdcard_qspi_defconfig             | 1 +
 configs/ls1046ardb_qspi_SECURE_BOOT_defconfig        | 1 +
 configs/ls1046ardb_qspi_defconfig                    | 1 +
 configs/ls1088aqds_qspi_SECURE_BOOT_defconfig        | 1 +
 configs/ls1088aqds_qspi_defconfig                    | 1 +
 configs/ls1088aqds_sdcard_qspi_defconfig             | 1 +
 configs/ls1088ardb_qspi_SECURE_BOOT_defconfig        | 1 +
 configs/ls1088ardb_qspi_defconfig                    | 1 +
 configs/ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig | 1 +
 configs/ls1088ardb_sdcard_qspi_defconfig             | 1 +
 configs/ls2080aqds_qspi_defconfig                    | 1 +
 configs/ls2088ardb_qspi_SECURE_BOOT_defconfig        | 1 +
 configs/ls2088ardb_qspi_defconfig                    | 1 +
 14 files changed, 14 insertions(+)

Comments

York Sun June 25, 2018, 3:34 p.m. UTC | #1
On 06/25/2018 03:31 AM, Ashish Kumar wrote:
> 4K erase size is used only in case of hydrid mode which is not
> supported on any NXP platform with flash "s25fs512s".
> Supported mode is uniform sector, with erase size 256kiB.
> 
> Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> ---
>  configs/ls1046aqds_qspi_defconfig                    | 1 +
>  configs/ls1046aqds_sdcard_qspi_defconfig             | 1 +
>  configs/ls1046ardb_qspi_SECURE_BOOT_defconfig        | 1 +
>  configs/ls1046ardb_qspi_defconfig                    | 1 +
>  configs/ls1088aqds_qspi_SECURE_BOOT_defconfig        | 1 +
>  configs/ls1088aqds_qspi_defconfig                    | 1 +
>  configs/ls1088aqds_sdcard_qspi_defconfig             | 1 +
>  configs/ls1088ardb_qspi_SECURE_BOOT_defconfig        | 1 +
>  configs/ls1088ardb_qspi_defconfig                    | 1 +
>  configs/ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig | 1 +
>  configs/ls1088ardb_sdcard_qspi_defconfig             | 1 +
>  configs/ls2080aqds_qspi_defconfig                    | 1 +
>  configs/ls2088ardb_qspi_SECURE_BOOT_defconfig        | 1 +
>  configs/ls2088ardb_qspi_defconfig                    | 1 +
>  14 files changed, 14 insertions(+)
> 
> diff --git a/configs/ls1046aqds_qspi_defconfig b/configs/ls1046aqds_qspi_defconfig
> index 4f3290c..a770039 100644
> --- a/configs/ls1046aqds_qspi_defconfig
> +++ b/configs/ls1046aqds_qspi_defconfig
> @@ -41,6 +41,7 @@ CONFIG_SPI=y
>  CONFIG_DM_SPI=y
>  CONFIG_FSL_DSPI=y
>  CONFIG_FSL_QSPI=y
> +CONFIG_SPI_FLASH_USE_4K_SECTORS=n

Ashish,

Did you get the defconfig by "savedefconfig"? I think the correct setting is

# CONFIG_SPI_FLASH_USE_4K_SECTORS is not set

York
Ashish Kumar June 26, 2018, 7:47 a.m. UTC | #2
> -----Original Message-----
> From: York Sun
> Sent: Monday, June 25, 2018 9:05 PM
> To: Ashish Kumar <ashish.kumar@nxp.com>; u-boot@lists.denx.de
> Cc: Udit Agarwal <udit.agarwal@nxp.com>; Priyanka Jain
> <priyanka.jain@nxp.com>; Vinitha V Pillai <vinitha.pillai@nxp.com>; Prabhakar
> Kushwaha <prabhakar.kushwaha@nxp.com>; Mingkai Hu
> <mingkai.hu@nxp.com>; york.sun@nxp.com.com; Ruchika Gupta
> <ruchika.gupta@nxp.com>
> Subject: Re: [u-boot-release] [PATCH] configs: Disable 4k erase sector size for
> spansion "s25fs512s" flash
> 
> On 06/25/2018 03:31 AM, Ashish Kumar wrote:
> > 4K erase size is used only in case of hydrid mode which is not
> > supported on any NXP platform with flash "s25fs512s".
> > Supported mode is uniform sector, with erase size 256kiB.
> >
> > Signed-off-by: Ashish Kumar <Ashish.Kumar@nxp.com>
> > ---
> >  configs/ls1046aqds_qspi_defconfig                    | 1 +
> >  configs/ls1046aqds_sdcard_qspi_defconfig             | 1 +
> >  configs/ls1046ardb_qspi_SECURE_BOOT_defconfig        | 1 +
> >  configs/ls1046ardb_qspi_defconfig                    | 1 +
> >  configs/ls1088aqds_qspi_SECURE_BOOT_defconfig        | 1 +
> >  configs/ls1088aqds_qspi_defconfig                    | 1 +
> >  configs/ls1088aqds_sdcard_qspi_defconfig             | 1 +
> >  configs/ls1088ardb_qspi_SECURE_BOOT_defconfig        | 1 +
> >  configs/ls1088ardb_qspi_defconfig                    | 1 +
> >  configs/ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig | 1 +
> >  configs/ls1088ardb_sdcard_qspi_defconfig             | 1 +
> >  configs/ls2080aqds_qspi_defconfig                    | 1 +
> >  configs/ls2088ardb_qspi_SECURE_BOOT_defconfig        | 1 +
> >  configs/ls2088ardb_qspi_defconfig                    | 1 +
> >  14 files changed, 14 insertions(+)
> >
> > diff --git a/configs/ls1046aqds_qspi_defconfig
> > b/configs/ls1046aqds_qspi_defconfig
> > index 4f3290c..a770039 100644
> > --- a/configs/ls1046aqds_qspi_defconfig
> > +++ b/configs/ls1046aqds_qspi_defconfig
> > @@ -41,6 +41,7 @@ CONFIG_SPI=y
> >  CONFIG_DM_SPI=y
> >  CONFIG_FSL_DSPI=y
> >  CONFIG_FSL_QSPI=y
> > +CONFIG_SPI_FLASH_USE_4K_SECTORS=n
> 
> Ashish,
> 
> Did you get the defconfig by "savedefconfig"? I think the correct setting is
> 
> # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
Thanks York,

I will use savedefconfig method

Regards
Ashish
> 
> York
diff mbox series

Patch

diff --git a/configs/ls1046aqds_qspi_defconfig b/configs/ls1046aqds_qspi_defconfig
index 4f3290c..a770039 100644
--- a/configs/ls1046aqds_qspi_defconfig
+++ b/configs/ls1046aqds_qspi_defconfig
@@ -41,6 +41,7 @@  CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_FSL_DSPI=y
 CONFIG_FSL_QSPI=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
diff --git a/configs/ls1046aqds_sdcard_qspi_defconfig b/configs/ls1046aqds_sdcard_qspi_defconfig
index 45d80b9..79b1d04 100644
--- a/configs/ls1046aqds_sdcard_qspi_defconfig
+++ b/configs/ls1046aqds_sdcard_qspi_defconfig
@@ -48,6 +48,7 @@  CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_FSL_DSPI=y
 CONFIG_FSL_QSPI=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
diff --git a/configs/ls1046ardb_qspi_SECURE_BOOT_defconfig b/configs/ls1046ardb_qspi_SECURE_BOOT_defconfig
index adc5db3..3c18913 100644
--- a/configs/ls1046ardb_qspi_SECURE_BOOT_defconfig
+++ b/configs/ls1046ardb_qspi_SECURE_BOOT_defconfig
@@ -37,6 +37,7 @@  CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_FSL_QSPI=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
diff --git a/configs/ls1046ardb_qspi_defconfig b/configs/ls1046ardb_qspi_defconfig
index c87fe97..b375572 100644
--- a/configs/ls1046ardb_qspi_defconfig
+++ b/configs/ls1046ardb_qspi_defconfig
@@ -38,6 +38,7 @@  CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_FSL_QSPI=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
diff --git a/configs/ls1088aqds_qspi_SECURE_BOOT_defconfig b/configs/ls1088aqds_qspi_SECURE_BOOT_defconfig
index 20376be..f95f30f 100644
--- a/configs/ls1088aqds_qspi_SECURE_BOOT_defconfig
+++ b/configs/ls1088aqds_qspi_SECURE_BOOT_defconfig
@@ -31,6 +31,7 @@  CONFIG_FSL_ESDHC=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_PCI=y
diff --git a/configs/ls1088aqds_qspi_defconfig b/configs/ls1088aqds_qspi_defconfig
index cf2b4e3..aca13ee 100644
--- a/configs/ls1088aqds_qspi_defconfig
+++ b/configs/ls1088aqds_qspi_defconfig
@@ -31,6 +31,7 @@  CONFIG_FSL_ESDHC=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_PCI=y
diff --git a/configs/ls1088aqds_sdcard_qspi_defconfig b/configs/ls1088aqds_sdcard_qspi_defconfig
index 8d854da..7a7ab43 100644
--- a/configs/ls1088aqds_sdcard_qspi_defconfig
+++ b/configs/ls1088aqds_sdcard_qspi_defconfig
@@ -41,6 +41,7 @@  CONFIG_FSL_ESDHC=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_PCI=y
diff --git a/configs/ls1088ardb_qspi_SECURE_BOOT_defconfig b/configs/ls1088ardb_qspi_SECURE_BOOT_defconfig
index db95289..908488a 100644
--- a/configs/ls1088ardb_qspi_SECURE_BOOT_defconfig
+++ b/configs/ls1088ardb_qspi_SECURE_BOOT_defconfig
@@ -31,6 +31,7 @@  CONFIG_FSL_ESDHC=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_PCI=y
diff --git a/configs/ls1088ardb_qspi_defconfig b/configs/ls1088ardb_qspi_defconfig
index fbb75df..b8cd7e8 100644
--- a/configs/ls1088ardb_qspi_defconfig
+++ b/configs/ls1088ardb_qspi_defconfig
@@ -31,6 +31,7 @@  CONFIG_FSL_ESDHC=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_PCI=y
diff --git a/configs/ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig b/configs/ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig
index e4f0068..297f215 100644
--- a/configs/ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig
+++ b/configs/ls1088ardb_sdcard_qspi_SECURE_BOOT_defconfig
@@ -44,6 +44,7 @@  CONFIG_FSL_ESDHC=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_SYS_NS16550=y
diff --git a/configs/ls1088ardb_sdcard_qspi_defconfig b/configs/ls1088ardb_sdcard_qspi_defconfig
index 26966aa..fd2a660 100644
--- a/configs/ls1088ardb_sdcard_qspi_defconfig
+++ b/configs/ls1088ardb_sdcard_qspi_defconfig
@@ -41,6 +41,7 @@  CONFIG_FSL_ESDHC=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_SPANSION=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_PCI=y
diff --git a/configs/ls2080aqds_qspi_defconfig b/configs/ls2080aqds_qspi_defconfig
index b708790..b371d99 100644
--- a/configs/ls2080aqds_qspi_defconfig
+++ b/configs/ls2080aqds_qspi_defconfig
@@ -45,6 +45,7 @@  CONFIG_SYS_NS16550=y
 CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_FSL_QSPI=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
diff --git a/configs/ls2088ardb_qspi_SECURE_BOOT_defconfig b/configs/ls2088ardb_qspi_SECURE_BOOT_defconfig
index 7c50834..f9de03f 100644
--- a/configs/ls2088ardb_qspi_SECURE_BOOT_defconfig
+++ b/configs/ls2088ardb_qspi_SECURE_BOOT_defconfig
@@ -39,6 +39,7 @@  CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_FSL_DSPI=y
 CONFIG_FSL_QSPI=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y
diff --git a/configs/ls2088ardb_qspi_defconfig b/configs/ls2088ardb_qspi_defconfig
index d9ba7b7..9aa1aa6 100644
--- a/configs/ls2088ardb_qspi_defconfig
+++ b/configs/ls2088ardb_qspi_defconfig
@@ -43,6 +43,7 @@  CONFIG_SPI=y
 CONFIG_DM_SPI=y
 CONFIG_FSL_DSPI=y
 CONFIG_FSL_QSPI=y
+CONFIG_SPI_FLASH_USE_4K_SECTORS=n
 CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_XHCI_HCD=y