| Message ID | 1528969736-44037-3-git-send-email-j.hagemann@phytec.de |
|---|---|
| State | Superseded |
| Delegated to: | Philipp Tomsich |
| Headers | show |
| Series | [U-Boot,01/12] arch: arm: mach-rockchip: rk3288: Enable regulators in board_init | expand |
On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann <j.hagemann@phytec.de> wrote: > We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of > RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() > to enable the RX delay. > The MASK was used in a wrong way. > > Signed-off-by: Janine Hagemann <j.hagemann@phytec.de> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> On 14 Jun 2018, at 19:39, Joe Hershberger <joe.hershberger@ni.com> wrote: > > On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann <j.hagemann@phytec.de> wrote: >> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of >> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() >> to enable the RX delay. >> The MASK was used in a wrong way. >> >> Signed-off-by: Janine Hagemann <j.hagemann@phytec.de> > > Acked-by: Joe Hershberger <joe.hershberger@ni.com> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
On Thu, Jun 14, 2018 at 1:12 PM, Dr. Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > >> On 14 Jun 2018, at 19:39, Joe Hershberger <joe.hershberger@ni.com> wrote: >> >> On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann <j.hagemann@phytec.de> wrote: >>> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of >>> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() >>> to enable the RX delay. >>> The MASK was used in a wrong way. >>> >>> Signed-off-by: Janine Hagemann <j.hagemann@phytec.de> >> >> Acked-by: Joe Hershberger <joe.hershberger@ni.com> > > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> I assume I should take this series? Or would you prefer to? -Joe
Joe, > On 14 Jun 2018, at 20:26, Joe Hershberger <joe.hershberger@ni.com> wrote: > > On Thu, Jun 14, 2018 at 1:12 PM, Dr. Philipp Tomsich > <philipp.tomsich@theobroma-systems.com> wrote: >> >>> On 14 Jun 2018, at 19:39, Joe Hershberger <joe.hershberger@ni.com> wrote: >>> >>> On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann <j.hagemann@phytec.de> wrote: >>>> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of >>>> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() >>>> to enable the RX delay. >>>> The MASK was used in a wrong way. >>>> >>>> Signed-off-by: Janine Hagemann <j.hagemann@phytec.de> >>> >>> Acked-by: Joe Hershberger <joe.hershberger@ni.com> >> >> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > > I assume I should take this series? Or would you prefer to? I’ll take these as part of the larger series. Thanks, Philipp.
diff --git a/drivers/net/gmac_rockchip.c b/drivers/net/gmac_rockchip.c index 30a24d1..0f91731 100644 --- a/drivers/net/gmac_rockchip.c +++ b/drivers/net/gmac_rockchip.c @@ -350,7 +350,7 @@ static void rk3328_gmac_set_to_rgmii(struct gmac_rockchip_platdata *pdata) RK3328_RXCLK_DLY_ENA_GMAC_MASK | RK3328_TXCLK_DLY_ENA_GMAC_MASK, RK3328_GMAC_PHY_INTF_SEL_RGMII | - RK3328_RXCLK_DLY_ENA_GMAC_MASK | + RK3328_RXCLK_DLY_ENA_GMAC_ENABLE | RK3328_TXCLK_DLY_ENA_GMAC_ENABLE); rk_clrsetreg(&grf->mac_con[0],
We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() to enable the RX delay. The MASK was used in a wrong way. Signed-off-by: Janine Hagemann <j.hagemann@phytec.de> --- drivers/net/gmac_rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)