diff mbox series

[U-Boot,v2,4/5] test/py: gpt: test start LBA for sub-command rename and swap

Message ID 1508170655-17707-5-git-send-email-patrick.delaunay@st.com
State Superseded
Delegated to: Tom Rini
Headers show
Series solve issues in gpt management | expand

Commit Message

Patrick DELAUNAY Oct. 16, 2017, 4:17 p.m. UTC 
Add test of first and last LBA in gpt for rename and swap.
Only the name is expected to change, so test 3 columns
for part command
1: first LBA (start)
2: last LBA (end)
3: partition name

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---
WARNING: the last LBA are invalid after rename

before rename
0x00000800  0x00000a00      ""
0x00001000  0x00001200      ""

after rename, the last LBA change
=> 7ff for first = invalid (<start)
=> 17ff for second (size increase)

0x00000800	0x000007ff "first"
0x00001000	0x000017ff	"second"

the issue is corrected in next commit of the patchset


Changes in v2: None

 test/py/tests/test_gpt.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Stephen Warren Oct. 16, 2017, 5 p.m. UTC | #1 
On 10/16/2017 10:17 AM, Patrick Delaunay wrote:
> Add test of first and last LBA in gpt for rename and swap.
> Only the name is expected to change, so test 3 columns
> for part command
> 1: first LBA (start)
> 2: last LBA (end)
> 3: partition name
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> WARNING: the last LBA are invalid after rename
> 
> before rename
> 0x00000800  0x00000a00      ""
> 0x00001000  0x00001200      ""
> 
> after rename, the last LBA change
> => 7ff for first = invalid (<start)
> => 17ff for second (size increase)
> 
> 0x00000800	0x000007ff "first"
> 0x00001000	0x000017ff	"second"
> 
> the issue is corrected in next commit of the patchset

That issue should be described in the commit description, and also as a 
comment in the code.
diff mbox series

Patch

diff --git a/test/py/tests/test_gpt.py b/test/py/tests/test_gpt.py
index 8d5980c..2554f1f 100644
--- a/test/py/tests/test_gpt.py
+++ b/test/py/tests/test_gpt.py
@@ -117,6 +117,7 @@  def test_gpt_save_guid(state_disk_image, u_boot_console):
 @pytest.mark.boardspec('sandbox')
 @pytest.mark.buildconfigspec('cmd_gpt')
 @pytest.mark.buildconfigspec('cmd_gpt_rename')
+@pytest.mark.buildconfigspec('cmd_part')
 @pytest.mark.requiredtool('sgdisk')
 def test_gpt_rename_partition(state_disk_image, u_boot_console):
     """Test the gpt rename command to write partition names."""
@@ -128,6 +129,9 @@  def test_gpt_rename_partition(state_disk_image, u_boot_console):
     u_boot_console.run_command('gpt rename host 0 2 second')
     output = u_boot_console.run_command('gpt read host 0')
     assert 'name second' in output
+    output = u_boot_console.run_command('part list host 0')
+    assert '0x00000800	0x000007ff	"first"' in output
+    assert '0x00001000	0x000017ff	"second"' in output
 
 @pytest.mark.boardspec('sandbox')
 @pytest.mark.buildconfigspec('cmd_gpt')
@@ -139,12 +143,12 @@  def test_gpt_swap_partitions(state_disk_image, u_boot_console):
 
     u_boot_console.run_command('host bind 0 ' + state_disk_image.path)
     output = u_boot_console.run_command('part list host 0')
-    assert '0x000007ff	"first"' in output
-    assert '0x000017ff	"second"' in output
+    assert '0x00000800	0x000007ff	"first"' in output
+    assert '0x00001000	0x000017ff	"second"' in output
     u_boot_console.run_command('gpt swap host 0 first second')
     output = u_boot_console.run_command('part list host 0')
-    assert '0x000007ff	"second"' in output
-    assert '0x000017ff	"first"' in output
+    assert '0x00000800	0x000007ff	"second"' in output
+    assert '0x00001000	0x000017ff	"first"' in output
 
 @pytest.mark.boardspec('sandbox')
 @pytest.mark.buildconfigspec('cmd_gpt')