| Message ID | 1504555943-12893-4-git-send-email-pantelis.antoniou@konsulko.com |
|---|---|
| State | Accepted |
| Commit | 81ecc5d92badfcf1415a6052b5896a62271a94dc |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | uboot overlays, FIT image & unittest | expand |
On 4 September 2017 at 14:12, Pantelis Antoniou <pantelis.antoniou@konsulko.com> wrote: > The verbose overlay application method prints out more helpful > messages, so switch to it. > > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > --- > cmd/fdt.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Acked-by: Simon Glass <sjg@chromium.org>
On 8 September 2017 at 22:53, Simon Glass <sjg@chromium.org> wrote: > On 4 September 2017 at 14:12, Pantelis Antoniou > <pantelis.antoniou@konsulko.com> wrote: >> The verbose overlay application method prints out more helpful >> messages, so switch to it. >> >> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> >> --- >> cmd/fdt.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) > > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot-fdt, thanks!
diff --git a/cmd/fdt.c b/cmd/fdt.c index 118613f..362a621 100644 --- a/cmd/fdt.c +++ b/cmd/fdt.c @@ -669,11 +669,10 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) if (!fdt_valid(&blob)) return CMD_RET_FAILURE; - ret = fdt_overlay_apply(working_fdt, blob); - if (ret) { - printf("fdt_overlay_apply(): %s\n", fdt_strerror(ret)); + /* apply method prints messages on error */ + ret = fdt_overlay_apply_verbose(working_fdt, blob); + if (ret) return CMD_RET_FAILURE; - } } #endif /* resize the fdt */
The verbose overlay application method prints out more helpful messages, so switch to it. Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com> --- cmd/fdt.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)