diff mbox

[U-Boot,v2] rockchip: rk3399: enable SPL_SERIAL_SUPPORT and SPL_DRIVERS_MISC_SUPPORT via Kconfig

Message ID 1501064941-46933-1-git-send-email-philipp.tomsich@theobroma-systems.com
State Accepted
Commit c0508e427f7e01a20f9c23f5084cb32a0c9ba3bb
Delegated to: Philipp Tomsich
Headers show

Commit Message

Philipp Tomsich July 26, 2017, 10:29 a.m. UTC
SPL_SERIAL_SUPPORT and SPL_DRIVERS_MISC_SUPPORT were previously
enabled through rk3399_common.h.  This change implies these options
through Kconfig.

These need to always be active for the RK3399, as follows:
 - SPL_SERIAL_SUPPORT is needed to pass the SPL build
 - SPL_DRIVERS_MISC_SUPPORT is needed to pass the SPL build

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

---

Changes in v2:
- fixes the naming of SPL_DRIVERS_MISC_SUPPORT (shortened to
  SPL_DRIVERS_MISC in v1 of this patch)

 arch/arm/mach-rockchip/Kconfig  | 2 ++
 include/configs/rk3399_common.h | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Philipp Tomsich July 26, 2017, 11:11 a.m. UTC | #1
> SPL_SERIAL_SUPPORT and SPL_DRIVERS_MISC_SUPPORT were previously
> enabled through rk3399_common.h.  This change implies these options
> through Kconfig.
> 
> These need to always be active for the RK3399, as follows:
>  - SPL_SERIAL_SUPPORT is needed to pass the SPL build
>  - SPL_DRIVERS_MISC_SUPPORT is needed to pass the SPL build
> 
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2:
> - fixes the naming of SPL_DRIVERS_MISC_SUPPORT (shortened to
>   SPL_DRIVERS_MISC in v1 of this patch)
> 
>  arch/arm/mach-rockchip/Kconfig  | 2 ++
>  include/configs/rk3399_common.h | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich July 27, 2017, 11:20 a.m. UTC | #2
> SPL_SERIAL_SUPPORT and SPL_DRIVERS_MISC_SUPPORT were previously
> enabled through rk3399_common.h.  This change implies these options
> through Kconfig.
> 
> These need to always be active for the RK3399, as follows:
>  - SPL_SERIAL_SUPPORT is needed to pass the SPL build
>  - SPL_DRIVERS_MISC_SUPPORT is needed to pass the SPL build
> 
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2:
> - fixes the naming of SPL_DRIVERS_MISC_SUPPORT (shortened to
>   SPL_DRIVERS_MISC in v1 of this patch)
> 
>  arch/arm/mach-rockchip/Kconfig  | 2 ++
>  include/configs/rk3399_common.h | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Applied to u-boot-rockchip, thanks!
diff mbox

Patch

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index fd08897..8406e33 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -92,6 +92,8 @@  config ROCKCHIP_RK3399
 	select SUPPORT_SPL
 	select SPL
 	select SPL_SEPARATE_BSS
+	select SPL_SERIAL_SUPPORT
+	select SPL_DRIVERS_MISC_SUPPORT
 	select ENABLE_ARM_SOC_BOOT0_HOOK
 	select DEBUG_UART_BOARD_INIT
 	help
diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
index 54ea97b..6c9d760 100644
--- a/include/configs/rk3399_common.h
+++ b/include/configs/rk3399_common.h
@@ -16,8 +16,6 @@ 
 #define CONFIG_SYS_CBSIZE		1024
 #define CONFIG_SKIP_LOWLEVEL_INIT
 #define CONFIG_SPL_FRAMEWORK
-#define CONFIG_SPL_DRIVERS_MISC_SUPPORT
-#define CONFIG_SPL_SERIAL_SUPPORT
 #if defined(CONFIG_SPL_SPI_SUPPORT)
 #define CONFIG_SPL_SPI_LOAD
 #endif