| Message ID | 1469635835-2063-2-git-send-email-hdegoede@redhat.com |
|---|---|
| State | Accepted |
| Commit | 97322c3e074d49b1e2c6d98c7e69e5da3093636f |
| Delegated to: | Hans de Goede |
| Headers | show |
On Wed, 2016-07-27 at 18:10 +0200, Hans de Goede wrote: > On 2 of my H3 boards bytes 13-15 of the SID are all 0 leading to > the NIC specific bytes of the mac all being 0, which leads to the > boards not getting an ipv6 address from the dhcp server. > > This commits adds a check to ensure this does not happen. > > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Corentin LABBE <clabbe.montjoie@gmail.com> > Cc: Amit Singh Tomar <amittomer25@gmail.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Ian Campbell <ijc@hellion.org.uk>
diff --git a/board/sunxi/board.c b/board/sunxi/board.c index 36cf963..ef3fe26 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -623,6 +623,10 @@ static void setup_environment(const void *fdt) ret = sunxi_get_sid(sid); if (ret == 0 && sid[0] != 0 && sid[3] != 0) { + /* Ensure the NIC specific bytes of the mac are not all 0 */ + if ((sid[3] & 0xffffff) == 0) + sid[3] |= 0x800000; + for (i = 0; i < 4; i++) { sprintf(ethaddr, "ethernet%d", i); if (!fdt_get_alias(fdt, ethaddr))
On 2 of my H3 boards bytes 13-15 of the SID are all 0 leading to the NIC specific bytes of the mac all being 0, which leads to the boards not getting an ipv6 address from the dhcp server. This commits adds a check to ensure this does not happen. Cc: Chen-Yu Tsai <wens@csie.org> Cc: Corentin LABBE <clabbe.montjoie@gmail.com> Cc: Amit Singh Tomar <amittomer25@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- board/sunxi/board.c | 4 ++++ 1 file changed, 4 insertions(+)