diff mbox

[U-Boot,1/4] mx7dsabresd: Fix LCD_PWR_EN output setting

Message ID 1465971519-22344-1-git-send-email-peng.fan@nxp.com
State Accepted
Commit 0fcb85cc0cdf898019680a09200677a0beef27d9
Delegated to: Stefano Babic
Headers show

Commit Message

Peng Fan June 15, 2016, 6:18 a.m. UTC 
From: Ye Li <ye.li@nxp.com>

LCD_PWR_EN controls the G pin of Q13 PMOS which needs low voltage to connect
D to S for outputting LCD 3.3V. If LCD_PWR_EN is high, we measured the LCD 3v3
is actually 1.2V.

Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
---
 board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam June 15, 2016, 10:38 a.m. UTC | #1 
On Wed, Jun 15, 2016 at 3:18 AM, Peng Fan <van.freenix@gmail.com> wrote:
> From: Ye Li <ye.li@nxp.com>
>
> LCD_PWR_EN controls the G pin of Q13 PMOS which needs low voltage to connect
> D to S for outputting LCD 3.3V. If LCD_PWR_EN is high, we measured the LCD 3v3
> is actually 1.2V.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Stefano Babic June 18, 2016, 8:31 a.m. UTC | #2 
On 15/06/2016 08:18, Peng Fan wrote:
> From: Ye Li <ye.li@nxp.com>
> 
> LCD_PWR_EN controls the G pin of Q13 PMOS which needs low voltage to connect
> D to S for outputting LCD 3.3V. If LCD_PWR_EN is high, we measured the LCD 3v3
> is actually 1.2V.
> 
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
> index c3062f1..1f4fc03 100644
> --- a/board/freescale/mx7dsabresd/mx7dsabresd.c
> +++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
> @@ -171,7 +171,7 @@ static enum qn_level seq[3][2] = {
>  
>  static enum qn_func qn_output[8] = {
>  	qn_disable, qn_reset, qn_reset, qn_reset, qn_reset, qn_reset, qn_enable,
> -	qn_enable
> +	qn_disable
>  };
>  
>  static void iox74lv_init(void)
> 

Applied to master (bug fix), thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
index c3062f1..1f4fc03 100644
--- a/board/freescale/mx7dsabresd/mx7dsabresd.c
+++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
@@ -171,7 +171,7 @@  static enum qn_level seq[3][2] = {
 
 static enum qn_func qn_output[8] = {
 	qn_disable, qn_reset, qn_reset, qn_reset, qn_reset, qn_reset, qn_enable,
-	qn_enable
+	qn_disable
 };
 
 static void iox74lv_init(void)