diff mbox

[U-Boot,v3,09/12] mmc: omap_hsmmc: enable 8bit interface for eMMC for AM33xx

Message ID 1465281085-10481-10-git-send-email-hs@denx.de
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Heiko Schocher June 7, 2016, 6:31 a.m. UTC 
Enable 8bit interface on HSMMC2 for am33xx to support 8bit eMMC chips.

Signed-off-by: Heiko Schocher <hs@denx.de>
Reviewed-by: Tom Rini <trini@konsulko.com>

---

Changes in v3: None
Changes in v2:
- add Reviewed-by from Tom Rini

 drivers/mmc/omap_hsmmc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Igor Grinberg June 8, 2016, 8:53 a.m. UTC | #1 
Hi Heiko,

On 06/07/2016 09:31 AM, Heiko Schocher wrote:
> Enable 8bit interface on HSMMC2 for am33xx to support 8bit eMMC chips.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 
> ---
> 
> Changes in v3: None
> Changes in v2:
> - add Reviewed-by from Tom Rini
> 
>  drivers/mmc/omap_hsmmc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
> index be34057..d007b56 100644
> --- a/drivers/mmc/omap_hsmmc.c
> +++ b/drivers/mmc/omap_hsmmc.c
> @@ -701,6 +701,7 @@ int omap_mmc_init(int dev_index, uint host_caps_mask, uint f_max, int cd_gpio,
>  		priv_data->base_addr = (struct hsmmc *)OMAP_HSMMC2_BASE;
>  #if (defined(CONFIG_OMAP44XX) || defined(CONFIG_OMAP54XX) || \
>  	defined(CONFIG_DRA7XX) || defined(CONFIG_AM57XX) || \
> +	defined(CONFIG_AM33XX) || \
>  	defined(CONFIG_AM43XX) || defined(CONFIG_SOC_KEYSTONE)) && \
>  		defined(CONFIG_HSMMC2_8BIT)

Don't you find the above habit terrible - adding more and more SoCs
to the ifdef...

Don't get me wrong, I'm not trying to prevent this patch - please merge it.
But I think, we should do something about the above (and I can see also other
cases in the same function).

>  		/* Enable 8-bit interface for eMMC on OMAP4/5 or DRA7XX */
>
Tom Rini June 9, 2016, 6:03 p.m. UTC | #2 
On Tue, Jun 07, 2016 at 08:31:22AM +0200, Heiko Schocher wrote:

> Enable 8bit interface on HSMMC2 for am33xx to support 8bit eMMC chips.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
index be34057..d007b56 100644
--- a/drivers/mmc/omap_hsmmc.c
+++ b/drivers/mmc/omap_hsmmc.c
@@ -701,6 +701,7 @@  int omap_mmc_init(int dev_index, uint host_caps_mask, uint f_max, int cd_gpio,
 		priv_data->base_addr = (struct hsmmc *)OMAP_HSMMC2_BASE;
 #if (defined(CONFIG_OMAP44XX) || defined(CONFIG_OMAP54XX) || \
 	defined(CONFIG_DRA7XX) || defined(CONFIG_AM57XX) || \
+	defined(CONFIG_AM33XX) || \
 	defined(CONFIG_AM43XX) || defined(CONFIG_SOC_KEYSTONE)) && \
 		defined(CONFIG_HSMMC2_8BIT)
 		/* Enable 8-bit interface for eMMC on OMAP4/5 or DRA7XX */