diff mbox

[U-Boot] sunxi: Enable support for the eMMC found on the orangepi plus

Message ID 1458480073-22121-1-git-send-email-hdegoede@redhat.com
State Accepted
Commit 9284f3b452faa328fcc7e948c091598926d792ff
Delegated to: Hans de Goede
Headers show

Commit Message

Hans de Goede March 20, 2016, 1:21 p.m. UTC
This enables support for the eMMC found on the orangepi plus.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 configs/orangepi_plus_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chen-Yu Tsai March 21, 2016, 6:05 a.m. UTC | #1
Hi,

On Sun, Mar 20, 2016 at 9:21 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> This enables support for the eMMC found on the orangepi plus.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  configs/orangepi_plus_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/configs/orangepi_plus_defconfig b/configs/orangepi_plus_defconfig
> index c4885f4..770bd98 100644
> --- a/configs/orangepi_plus_defconfig
> +++ b/configs/orangepi_plus_defconfig
> @@ -4,6 +4,8 @@ CONFIG_MACH_SUN8I_H3=y
>  CONFIG_DRAM_CLK=672
>  CONFIG_DRAM_ZQ=3881979
>  CONFIG_DRAM_ODT_EN=y
> +CONFIG_MMC0_CD_PIN="PF6"
> +CONFIG_MMC_SUNXI_SLOT_EXTRA=2

Does CONFIG_MMC2_PINS also need to be set?

ChenYu

>  # CONFIG_VIDEO is not set
>  CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-plus"
>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
> --
> 2.7.3
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Hans de Goede March 21, 2016, 9:46 p.m. UTC | #2
Hi,

On 21-03-16 07:05, Chen-Yu Tsai wrote:
> Hi,
>
> On Sun, Mar 20, 2016 at 9:21 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> This enables support for the eMMC found on the orangepi plus.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   configs/orangepi_plus_defconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/configs/orangepi_plus_defconfig b/configs/orangepi_plus_defconfig
>> index c4885f4..770bd98 100644
>> --- a/configs/orangepi_plus_defconfig
>> +++ b/configs/orangepi_plus_defconfig
>> @@ -4,6 +4,8 @@ CONFIG_MACH_SUN8I_H3=y
>>   CONFIG_DRAM_CLK=672
>>   CONFIG_DRAM_ZQ=3881979
>>   CONFIG_DRAM_ODT_EN=y
>> +CONFIG_MMC0_CD_PIN="PF6"
>> +CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>
> Does CONFIG_MMC2_PINS also need to be set?

No there only is one pinmux option for MMC2 on H8, so there is no
need to set this.

Regards,

Hans
Ian Campbell March 22, 2016, 9:48 p.m. UTC | #3
On Mon, 2016-03-21 at 22:46 +0100, Hans de Goede wrote:
> Hi,
> 
> On 21-03-16 07:05, Chen-Yu Tsai wrote:
> > Hi,
> >
> > On Sun, Mar 20, 2016 at 9:21 PM, Hans de Goede <hdegoede@redhat.com
> > wrote:
> >> This enables support for the eMMC found on the orangepi plus.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >> ---
> >>   configs/orangepi_plus_defconfig | 2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >> diff --git a/configs/orangepi_plus_defconfig
> b/configs/orangepi_plus_defconfig
> >> index c4885f4..770bd98 100644
> >> --- a/configs/orangepi_plus_defconfig
> >> +++ b/configs/orangepi_plus_defconfig
> >> @@ -4,6 +4,8 @@ CONFIG_MACH_SUN8I_H3=y
> >>   CONFIG_DRAM_CLK=672
> >>   CONFIG_DRAM_ZQ=3881979
> >>   CONFIG_DRAM_ODT_EN=y
> >> +CONFIG_MMC0_CD_PIN="PF6"
> >> +CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> >
> > Does CONFIG_MMC2_PINS also need to be set?
> 
> No there only is one pinmux option for MMC2 on H8, so there is no
> need to set this.

Acked-by: Ian Campbell <ijc@hellion.org.uk>
diff mbox

Patch

diff --git a/configs/orangepi_plus_defconfig b/configs/orangepi_plus_defconfig
index c4885f4..770bd98 100644
--- a/configs/orangepi_plus_defconfig
+++ b/configs/orangepi_plus_defconfig
@@ -4,6 +4,8 @@  CONFIG_MACH_SUN8I_H3=y
 CONFIG_DRAM_CLK=672
 CONFIG_DRAM_ZQ=3881979
 CONFIG_DRAM_ODT_EN=y
+CONFIG_MMC0_CD_PIN="PF6"
+CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 # CONFIG_VIDEO is not set
 CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-plus"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set