[U-Boot,v3,2/4] drivers: musb-new: remove writes{bwlq} and reads{bwlq}.

Moved definition of writes{bwlq} and reads{bwlq} into arch.
There is no need of having arch specific wrapper in driver.

Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
---

Changes in v3: None
Changes in v2: None

 drivers/usb/musb-new/linux-compat.h | 7 -------
 1 file changed, 7 deletions(-)

On 03/15/2016 01:44 PM, Purna Chandra Mandal wrote:
> Moved definition of writes{bwlq} and reads{bwlq} into arch.
> There is no need of having arch specific wrapper in driver.

And so the patch does ... what exactly ? I cannot figure it out just by
reading the commit message, sorry.

The patch itself is fine of course, but please fix the commit message.

> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  drivers/usb/musb-new/linux-compat.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/usb/musb-new/linux-compat.h b/drivers/usb/musb-new/linux-compat.h
> index 46f83d9..526f4f2 100644
> --- a/drivers/usb/musb-new/linux-compat.h
> +++ b/drivers/usb/musb-new/linux-compat.h
> @@ -13,13 +13,6 @@
>  		printf(fmt, ##args);		\
>  	ret_warn; })
>  
> -#define writesl(a, d, s) __raw_writesl((unsigned long)a, d, s)
> -#define readsl(a, d, s) __raw_readsl((unsigned long)a, d, s)
> -#define writesw(a, d, s) __raw_writesw((unsigned long)a, d, s)
> -#define readsw(a, d, s) __raw_readsw((unsigned long)a, d, s)
> -#define writesb(a, d, s) __raw_writesb((unsigned long)a, d, s)
> -#define readsb(a, d, s) __raw_readsb((unsigned long)a, d, s)
> -
>  #define device_init_wakeup(dev, a) do {} while (0)
>  
>  #define platform_data device_data
>

On 03/15/2016 11:40 PM, Marek Vasut wrote:

> On 03/15/2016 01:44 PM, Purna Chandra Mandal wrote:
>> Moved definition of writes{bwlq} and reads{bwlq} into arch.
>> There is no need of having arch specific wrapper in driver.
> And so the patch does ... what exactly ? I cannot figure it out just by
> reading the commit message, sorry.
>
> The patch itself is fine of course, but please fix the commit message.

I hope new commit message will do.
"Definition of writes{bwlq}, reads{bwlq} are now added into arch specific asm/io.h.
 So removing them from driver to fix re-definition error.
"

>> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
>> ---
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>>  drivers/usb/musb-new/linux-compat.h | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/usb/musb-new/linux-compat.h b/drivers/usb/musb-new/linux-compat.h
>> index 46f83d9..526f4f2 100644
>> --- a/drivers/usb/musb-new/linux-compat.h
>> +++ b/drivers/usb/musb-new/linux-compat.h
>> @@ -13,13 +13,6 @@
>>  		printf(fmt, ##args);		\
>>  	ret_warn; })
>>  
>> -#define writesl(a, d, s) __raw_writesl((unsigned long)a, d, s)
>> -#define readsl(a, d, s) __raw_readsl((unsigned long)a, d, s)
>> -#define writesw(a, d, s) __raw_writesw((unsigned long)a, d, s)
>> -#define readsw(a, d, s) __raw_readsw((unsigned long)a, d, s)
>> -#define writesb(a, d, s) __raw_writesb((unsigned long)a, d, s)
>> -#define readsb(a, d, s) __raw_readsb((unsigned long)a, d, s)
>> -
>>  #define device_init_wakeup(dev, a) do {} while (0)
>>  
>>  #define platform_data device_data
>>
>

On 03/16/2016 07:36 AM, Purna Chandra Mandal wrote:
> On 03/15/2016 11:40 PM, Marek Vasut wrote:
> 
>> On 03/15/2016 01:44 PM, Purna Chandra Mandal wrote:
>>> Moved definition of writes{bwlq} and reads{bwlq} into arch.
>>> There is no need of having arch specific wrapper in driver.
>> And so the patch does ... what exactly ? I cannot figure it out just by
>> reading the commit message, sorry.
>>
>> The patch itself is fine of course, but please fix the commit message.
> 
> I hope new commit message will do.
> "Definition of writes{bwlq}, reads{bwlq} are now added into arch specific asm/io.h.
>  So removing them from driver to fix re-definition error.
> "

Yes please :)