| Message ID | 1448591271-2165-1-git-send-email-clsee@altera.com |
|---|---|
| State | Superseded |
| Delegated to: | Marek Vasut |
| Headers | show |
On 27.11.2015 03:27, Chin Liang See wrote: > Remove fsloadcmd / ext2load as we are using load command > which use the corresponding latest file system command. > > Signed-off-by: Chin Liang See <clsee@altera.com> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > Cc: Dinh Nguyen <dinh.linux@gmail.com> > Cc: Pavel Machek <pavel@denx.de> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefan Roese <sr@denx.de> > --- > include/configs/socfpga_arria5_socdk.h | 1 - > include/configs/socfpga_cyclone5_socdk.h | 1 - > include/configs/socfpga_de0_nano_soc.h | 1 - > include/configs/socfpga_sockit.h | 1 - > include/configs/socfpga_socrates.h | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/include/configs/socfpga_arria5_socdk.h b/include/configs/socfpga_arria5_socdk.h > index 0506336..9337a58 100644 > --- a/include/configs/socfpga_arria5_socdk.h > +++ b/include/configs/socfpga_arria5_socdk.h > @@ -81,7 +81,6 @@ > "fdt_addr=100\0" \ > "fdtimage=socfpga.dtb\0" \ > "fdtimagesize=0x7000\0" \ > - "fsloadcmd=ext2load\0" \ > "bootm ${loadaddr} - ${fdt_addr}\0" \ > "mmcroot=/dev/mmcblk0p2\0" \ > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > diff --git a/include/configs/socfpga_cyclone5_socdk.h b/include/configs/socfpga_cyclone5_socdk.h > index d7369ee..3b2cfb0 100644 > --- a/include/configs/socfpga_cyclone5_socdk.h > +++ b/include/configs/socfpga_cyclone5_socdk.h > @@ -81,7 +81,6 @@ > "fdt_addr=100\0" \ > "fdtimage=socfpga.dtb\0" \ > "fdtimagesize=0x7000\0" \ > - "fsloadcmd=ext2load\0" \ > "bootm ${loadaddr} - ${fdt_addr}\0" \ > "mmcroot=/dev/mmcblk0p2\0" \ > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > diff --git a/include/configs/socfpga_de0_nano_soc.h b/include/configs/socfpga_de0_nano_soc.h > index b371a9b..16e146c 100644 > --- a/include/configs/socfpga_de0_nano_soc.h > +++ b/include/configs/socfpga_de0_nano_soc.h > @@ -74,7 +74,6 @@ > "bootimage=zImage\0" \ > "fdt_addr=100\0" \ > "fdtimage=socfpga.dtb\0" \ > - "fsloadcmd=ext2load\0" \ > "bootm ${loadaddr} - ${fdt_addr}\0" \ > "mmcroot=/dev/mmcblk0p2\0" \ > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > diff --git a/include/configs/socfpga_sockit.h b/include/configs/socfpga_sockit.h > index d26f53d..5bcee05 100644 > --- a/include/configs/socfpga_sockit.h > +++ b/include/configs/socfpga_sockit.h > @@ -79,7 +79,6 @@ > "bootimage=zImage\0" \ > "fdt_addr=100\0" \ > "fdtimage=socfpga.dtb\0" \ > - "fsloadcmd=ext2load\0" \ > "bootm ${loadaddr} - ${fdt_addr}\0" \ > "mmcroot=/dev/mmcblk0p2\0" \ > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > diff --git a/include/configs/socfpga_socrates.h b/include/configs/socfpga_socrates.h > index 6331251..16a2a86 100644 > --- a/include/configs/socfpga_socrates.h > +++ b/include/configs/socfpga_socrates.h > @@ -75,7 +75,6 @@ > "bootimage=zImage\0" \ > "fdt_addr=100\0" \ > "fdtimage=socfpga.dtb\0" \ > - "fsloadcmd=ext2load\0" \ > "bootm ${loadaddr} - ${fdt_addr}\0" \ > "mmcroot=/dev/mmcblk0p2\0" \ > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan
On Friday, November 27, 2015 at 03:27:51 AM, Chin Liang See wrote: > Remove fsloadcmd / ext2load as we are using load command > which use the corresponding latest file system command. > > Signed-off-by: Chin Liang See <clsee@altera.com> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > Cc: Dinh Nguyen <dinh.linux@gmail.com> > Cc: Pavel Machek <pavel@denx.de> > Cc: Marek Vasut <marex@denx.de> > Cc: Stefan Roese <sr@denx.de> > --- > include/configs/socfpga_arria5_socdk.h | 1 - > include/configs/socfpga_cyclone5_socdk.h | 1 - > include/configs/socfpga_de0_nano_soc.h | 1 - > include/configs/socfpga_sockit.h | 1 - > include/configs/socfpga_socrates.h | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/include/configs/socfpga_arria5_socdk.h > b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 100644 > --- a/include/configs/socfpga_arria5_socdk.h > +++ b/include/configs/socfpga_arria5_socdk.h > @@ -81,7 +81,6 @@ > "fdt_addr=100\0" \ > "fdtimage=socfpga.dtb\0" \ > "fdtimagesize=0x7000\0" \ > - "fsloadcmd=ext2load\0" \ > "bootm ${loadaddr} - ${fdt_addr}\0" \ > "mmcroot=/dev/mmcblk0p2\0" \ > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ This doesn't apply to u-boot-socfpga/master . Any idea why ? Best regards, Marek Vasut
On Fri, 2015-11-27 at 11:35 +0100, Marek Vasut wrote: > On Friday, November 27, 2015 at 03:27:51 AM, Chin Liang See wrote: > > Remove fsloadcmd / ext2load as we are using load command > > which use the corresponding latest file system command. > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > Cc: Pavel Machek <pavel@denx.de> > > Cc: Marek Vasut <marex@denx.de> > > Cc: Stefan Roese <sr@denx.de> > > --- > > include/configs/socfpga_arria5_socdk.h | 1 - > > include/configs/socfpga_cyclone5_socdk.h | 1 - > > include/configs/socfpga_de0_nano_soc.h | 1 - > > include/configs/socfpga_sockit.h | 1 - > > include/configs/socfpga_socrates.h | 1 - > > 5 files changed, 5 deletions(-) > > > > diff --git a/include/configs/socfpga_arria5_socdk.h > > b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 > > 100644 > > --- a/include/configs/socfpga_arria5_socdk.h > > +++ b/include/configs/socfpga_arria5_socdk.h > > @@ -81,7 +81,6 @@ > > "fdt_addr=100\0" \ > > "fdtimage=socfpga.dtb\0" \ > > "fdtimagesize=0x7000\0" \ > > - "fsloadcmd=ext2load\0" \ > > "bootm ${loadaddr} - ${fdt_addr}\0" \ > > "mmcroot=/dev/mmcblk0p2\0" \ > > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > > This doesn't apply to u-boot-socfpga/master . Any idea why ? Oh, this patch was on top of the QSPI patch. As that patch is acked, I am thinking that will be applied first than this (if acked). Thanks Chin Liang > > Best regards, > Marek Vasut
On Friday, November 27, 2015 at 01:10:21 PM, Chin Liang See wrote: > On Fri, 2015-11-27 at 11:35 +0100, Marek Vasut wrote: > > On Friday, November 27, 2015 at 03:27:51 AM, Chin Liang See wrote: > > > Remove fsloadcmd / ext2load as we are using load command > > > which use the corresponding latest file system command. > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > Cc: Pavel Machek <pavel@denx.de> > > > Cc: Marek Vasut <marex@denx.de> > > > Cc: Stefan Roese <sr@denx.de> > > > --- > > > > > > include/configs/socfpga_arria5_socdk.h | 1 - > > > include/configs/socfpga_cyclone5_socdk.h | 1 - > > > include/configs/socfpga_de0_nano_soc.h | 1 - > > > include/configs/socfpga_sockit.h | 1 - > > > include/configs/socfpga_socrates.h | 1 - > > > 5 files changed, 5 deletions(-) > > > > > > diff --git a/include/configs/socfpga_arria5_socdk.h > > > b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 > > > 100644 > > > --- a/include/configs/socfpga_arria5_socdk.h > > > +++ b/include/configs/socfpga_arria5_socdk.h > > > @@ -81,7 +81,6 @@ > > > > > > "fdt_addr=100\0" \ > > > "fdtimage=socfpga.dtb\0" \ > > > "fdtimagesize=0x7000\0" \ > > > > > > - "fsloadcmd=ext2load\0" \ > > > > > > "bootm ${loadaddr} - ${fdt_addr}\0" \ > > > "mmcroot=/dev/mmcblk0p2\0" \ > > > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > > > > This doesn't apply to u-boot-socfpga/master . Any idea why ? > > Oh, this patch was on top of the QSPI patch. As that patch is acked, I > am thinking that will be applied first than this (if acked). Um, what did I smoke what I acked that patch ? :O btw. if you have some inter-patch deps, it'd be real nice if you could put a note about that somewhere next time. Best regards, Marek Vasut
On Fri, 2015-11-27 at 13:14 +0100, Marek Vasut wrote: > On Friday, November 27, 2015 at 01:10:21 PM, Chin Liang See wrote: > > On Fri, 2015-11-27 at 11:35 +0100, Marek Vasut wrote: > > > On Friday, November 27, 2015 at 03:27:51 AM, Chin Liang See > > > wrote: > > > > Remove fsloadcmd / ext2load as we are using load command > > > > which use the corresponding latest file system command. > > > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > > Cc: Pavel Machek <pavel@denx.de> > > > > Cc: Marek Vasut <marex@denx.de> > > > > Cc: Stefan Roese <sr@denx.de> > > > > --- > > > > > > > > include/configs/socfpga_arria5_socdk.h | 1 - > > > > include/configs/socfpga_cyclone5_socdk.h | 1 - > > > > include/configs/socfpga_de0_nano_soc.h | 1 - > > > > include/configs/socfpga_sockit.h | 1 - > > > > include/configs/socfpga_socrates.h | 1 - > > > > 5 files changed, 5 deletions(-) > > > > > > > > diff --git a/include/configs/socfpga_arria5_socdk.h > > > > b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 > > > > 100644 > > > > --- a/include/configs/socfpga_arria5_socdk.h > > > > +++ b/include/configs/socfpga_arria5_socdk.h > > > > @@ -81,7 +81,6 @@ > > > > > > > > "fdt_addr=100\0" \ > > > > "fdtimage=socfpga.dtb\0" \ > > > > "fdtimagesize=0x7000\0" \ > > > > > > > > - "fsloadcmd=ext2load\0" \ > > > > > > > > "bootm ${loadaddr} - ${fdt_addr}\0" \ > > > > "mmcroot=/dev/mmcblk0p2\0" \ > > > > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > > > > > > This doesn't apply to u-boot-socfpga/master . Any idea why ? > > > > Oh, this patch was on top of the QSPI patch. As that patch is > > acked, I > > am thinking that will be applied first than this (if acked). > > Um, what did I smoke what I acked that patch ? :O > Oh its actually acked by Pavel. But let me know if you want me to let this patch go first than QSPI. > btw. if you have some inter-patch deps, it'd be real nice if you > could > put a note about that somewhere next time. > Noted. Thanks Chin Liang > Best regards, > Marek Vasut
On Friday, November 27, 2015 at 01:10:21 PM, Chin Liang See wrote: > On Fri, 2015-11-27 at 11:35 +0100, Marek Vasut wrote: > > On Friday, November 27, 2015 at 03:27:51 AM, Chin Liang See wrote: > > > Remove fsloadcmd / ext2load as we are using load command > > > which use the corresponding latest file system command. > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > Cc: Pavel Machek <pavel@denx.de> > > > Cc: Marek Vasut <marex@denx.de> > > > Cc: Stefan Roese <sr@denx.de> > > > --- > > > > > > include/configs/socfpga_arria5_socdk.h | 1 - > > > include/configs/socfpga_cyclone5_socdk.h | 1 - > > > include/configs/socfpga_de0_nano_soc.h | 1 - > > > include/configs/socfpga_sockit.h | 1 - > > > include/configs/socfpga_socrates.h | 1 - > > > 5 files changed, 5 deletions(-) > > > > > > diff --git a/include/configs/socfpga_arria5_socdk.h > > > b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 > > > 100644 > > > --- a/include/configs/socfpga_arria5_socdk.h > > > +++ b/include/configs/socfpga_arria5_socdk.h > > > @@ -81,7 +81,6 @@ > > > > > > "fdt_addr=100\0" \ > > > "fdtimage=socfpga.dtb\0" \ > > > "fdtimagesize=0x7000\0" \ > > > > > > - "fsloadcmd=ext2load\0" \ > > > > > > "bootm ${loadaddr} - ${fdt_addr}\0" \ > > > "mmcroot=/dev/mmcblk0p2\0" \ > > > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > > > > This doesn't apply to u-boot-socfpga/master . Any idea why ? > > Oh, this patch was on top of the QSPI patch. As that patch is acked, I > am thinking that will be applied first than this (if acked). I'm inclined to pick this one up early and what for the QSPI situation to pan out. Can you resubmit this one on top of u-boot-socfpga/master ? I can fix the patch myself too tho... Best regards, Marek Vasut
On Fri, 2015-11-27 at 13:52 +0100, Marek Vasut wrote: > On Friday, November 27, 2015 at 01:10:21 PM, Chin Liang See wrote: > > On Fri, 2015-11-27 at 11:35 +0100, Marek Vasut wrote: > > > On Friday, November 27, 2015 at 03:27:51 AM, Chin Liang See > > > wrote: > > > > Remove fsloadcmd / ext2load as we are using load command > > > > which use the corresponding latest file system command. > > > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > > Cc: Pavel Machek <pavel@denx.de> > > > > Cc: Marek Vasut <marex@denx.de> > > > > Cc: Stefan Roese <sr@denx.de> > > > > --- > > > > > > > > include/configs/socfpga_arria5_socdk.h | 1 - > > > > include/configs/socfpga_cyclone5_socdk.h | 1 - > > > > include/configs/socfpga_de0_nano_soc.h | 1 - > > > > include/configs/socfpga_sockit.h | 1 - > > > > include/configs/socfpga_socrates.h | 1 - > > > > 5 files changed, 5 deletions(-) > > > > > > > > diff --git a/include/configs/socfpga_arria5_socdk.h > > > > b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 > > > > 100644 > > > > --- a/include/configs/socfpga_arria5_socdk.h > > > > +++ b/include/configs/socfpga_arria5_socdk.h > > > > @@ -81,7 +81,6 @@ > > > > > > > > "fdt_addr=100\0" \ > > > > "fdtimage=socfpga.dtb\0" \ > > > > "fdtimagesize=0x7000\0" \ > > > > > > > > - "fsloadcmd=ext2load\0" \ > > > > > > > > "bootm ${loadaddr} - ${fdt_addr}\0" \ > > > > "mmcroot=/dev/mmcblk0p2\0" \ > > > > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > > > > > > This doesn't apply to u-boot-socfpga/master . Any idea why ? > > > > Oh, this patch was on top of the QSPI patch. As that patch is > > acked, I > > am thinking that will be applied first than this (if acked). > > I'm inclined to pick this one up early and what for the QSPI > situation to pan > out. Can you resubmit this one on top of u-boot-socfpga/master ? I > can fix the > patch myself too tho... > Sure, let me do that as its a quick one :) Thanks Chin Liang > Best regards, > Marek Vasut
On Friday, November 27, 2015 at 02:09:29 PM, Chin Liang See wrote: > On Fri, 2015-11-27 at 13:52 +0100, Marek Vasut wrote: > > On Friday, November 27, 2015 at 01:10:21 PM, Chin Liang See wrote: > > > On Fri, 2015-11-27 at 11:35 +0100, Marek Vasut wrote: > > > > On Friday, November 27, 2015 at 03:27:51 AM, Chin Liang See > > > > > > > > wrote: > > > > > Remove fsloadcmd / ext2load as we are using load command > > > > > which use the corresponding latest file system command. > > > > > > > > > > Signed-off-by: Chin Liang See <clsee@altera.com> > > > > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com> > > > > > Cc: Dinh Nguyen <dinh.linux@gmail.com> > > > > > Cc: Pavel Machek <pavel@denx.de> > > > > > Cc: Marek Vasut <marex@denx.de> > > > > > Cc: Stefan Roese <sr@denx.de> > > > > > --- > > > > > > > > > > include/configs/socfpga_arria5_socdk.h | 1 - > > > > > include/configs/socfpga_cyclone5_socdk.h | 1 - > > > > > include/configs/socfpga_de0_nano_soc.h | 1 - > > > > > include/configs/socfpga_sockit.h | 1 - > > > > > include/configs/socfpga_socrates.h | 1 - > > > > > 5 files changed, 5 deletions(-) > > > > > > > > > > diff --git a/include/configs/socfpga_arria5_socdk.h > > > > > b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 > > > > > 100644 > > > > > --- a/include/configs/socfpga_arria5_socdk.h > > > > > +++ b/include/configs/socfpga_arria5_socdk.h > > > > > @@ -81,7 +81,6 @@ > > > > > > > > > > "fdt_addr=100\0" \ > > > > > "fdtimage=socfpga.dtb\0" \ > > > > > "fdtimagesize=0x7000\0" \ > > > > > > > > > > - "fsloadcmd=ext2load\0" \ > > > > > > > > > > "bootm ${loadaddr} - ${fdt_addr}\0" \ > > > > > "mmcroot=/dev/mmcblk0p2\0" \ > > > > > "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ > > > > > > > > This doesn't apply to u-boot-socfpga/master . Any idea why ? > > > > > > Oh, this patch was on top of the QSPI patch. As that patch is > > > acked, I > > > am thinking that will be applied first than this (if acked). > > > > I'm inclined to pick this one up early and what for the QSPI > > situation to pan > > out. Can you resubmit this one on top of u-boot-socfpga/master ? I > > can fix the > > patch myself too tho... > > Sure, let me do that as its a quick one :) Thanks :) Best regards, Marek Vasut
diff --git a/include/configs/socfpga_arria5_socdk.h b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 100644 --- a/include/configs/socfpga_arria5_socdk.h +++ b/include/configs/socfpga_arria5_socdk.h @@ -81,7 +81,6 @@ "fdt_addr=100\0" \ "fdtimage=socfpga.dtb\0" \ "fdtimagesize=0x7000\0" \ - "fsloadcmd=ext2load\0" \ "bootm ${loadaddr} - ${fdt_addr}\0" \ "mmcroot=/dev/mmcblk0p2\0" \ "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ diff --git a/include/configs/socfpga_cyclone5_socdk.h b/include/configs/socfpga_cyclone5_socdk.h index d7369ee..3b2cfb0 100644 --- a/include/configs/socfpga_cyclone5_socdk.h +++ b/include/configs/socfpga_cyclone5_socdk.h @@ -81,7 +81,6 @@ "fdt_addr=100\0" \ "fdtimage=socfpga.dtb\0" \ "fdtimagesize=0x7000\0" \ - "fsloadcmd=ext2load\0" \ "bootm ${loadaddr} - ${fdt_addr}\0" \ "mmcroot=/dev/mmcblk0p2\0" \ "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ diff --git a/include/configs/socfpga_de0_nano_soc.h b/include/configs/socfpga_de0_nano_soc.h index b371a9b..16e146c 100644 --- a/include/configs/socfpga_de0_nano_soc.h +++ b/include/configs/socfpga_de0_nano_soc.h @@ -74,7 +74,6 @@ "bootimage=zImage\0" \ "fdt_addr=100\0" \ "fdtimage=socfpga.dtb\0" \ - "fsloadcmd=ext2load\0" \ "bootm ${loadaddr} - ${fdt_addr}\0" \ "mmcroot=/dev/mmcblk0p2\0" \ "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ diff --git a/include/configs/socfpga_sockit.h b/include/configs/socfpga_sockit.h index d26f53d..5bcee05 100644 --- a/include/configs/socfpga_sockit.h +++ b/include/configs/socfpga_sockit.h @@ -79,7 +79,6 @@ "bootimage=zImage\0" \ "fdt_addr=100\0" \ "fdtimage=socfpga.dtb\0" \ - "fsloadcmd=ext2load\0" \ "bootm ${loadaddr} - ${fdt_addr}\0" \ "mmcroot=/dev/mmcblk0p2\0" \ "mmcboot=setenv bootargs " CONFIG_BOOTARGS \ diff --git a/include/configs/socfpga_socrates.h b/include/configs/socfpga_socrates.h index 6331251..16a2a86 100644 --- a/include/configs/socfpga_socrates.h +++ b/include/configs/socfpga_socrates.h @@ -75,7 +75,6 @@ "bootimage=zImage\0" \ "fdt_addr=100\0" \ "fdtimage=socfpga.dtb\0" \ - "fsloadcmd=ext2load\0" \ "bootm ${loadaddr} - ${fdt_addr}\0" \ "mmcroot=/dev/mmcblk0p2\0" \ "mmcboot=setenv bootargs " CONFIG_BOOTARGS \
Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command. Signed-off-by: Chin Liang See <clsee@altera.com> Cc: Dinh Nguyen <dinguyen@opensource.altera.com> Cc: Dinh Nguyen <dinh.linux@gmail.com> Cc: Pavel Machek <pavel@denx.de> Cc: Marek Vasut <marex@denx.de> Cc: Stefan Roese <sr@denx.de> --- include/configs/socfpga_arria5_socdk.h | 1 - include/configs/socfpga_cyclone5_socdk.h | 1 - include/configs/socfpga_de0_nano_soc.h | 1 - include/configs/socfpga_sockit.h | 1 - include/configs/socfpga_socrates.h | 1 - 5 files changed, 5 deletions(-)