| Message ID | 1444330107-15923-2-git-send-email-grinberg@compulab.co.il |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Igor, On 8 October 2015 at 19:48, Igor Grinberg <grinberg@compulab.co.il> wrote: > Add CONFIG_CMD_BOOTZ to the Kconfig. > Since the CONFIG_CMD_BOOTZ cannot live without the CONFIG_CMD_BOOTM, > make it select the CONFIG_CMD_BOOTM. > > Signed-off-by: Igor Grinberg <grinberg@compulab.co.il> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: Simon Glass <sjg@chromium.org> > --- > common/Kconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/common/Kconfig b/common/Kconfig > index 2c42b8e..d98eb19 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -148,6 +148,12 @@ config CMD_BOOTM > help > Boot an application image from the memory. > > +config CMD_BOOTZ > + bool "bootz" > + select CMD_BOOTM Do we need this, or can it be 'depends on CMD_BOOTM'? > + help > + Boot a Linux kernel zImage from the memory. > + Could you add a brief description of what a zImage is and how it gets created? It would be good to be a bit more descriptive in these help messages. > config CMD_GO > bool "go" > default y > -- > 2.4.9 > Regards, Simon
Hi Simon, On 10/09/15 12:36, Simon Glass wrote: > Hi Igor, > > On 8 October 2015 at 19:48, Igor Grinberg <grinberg@compulab.co.il> wrote: >> Add CONFIG_CMD_BOOTZ to the Kconfig. >> Since the CONFIG_CMD_BOOTZ cannot live without the CONFIG_CMD_BOOTM, >> make it select the CONFIG_CMD_BOOTM. >> >> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il> >> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> >> Cc: Simon Glass <sjg@chromium.org> >> --- >> common/Kconfig | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/common/Kconfig b/common/Kconfig >> index 2c42b8e..d98eb19 100644 >> --- a/common/Kconfig >> +++ b/common/Kconfig >> @@ -148,6 +148,12 @@ config CMD_BOOTM >> help >> Boot an application image from the memory. >> >> +config CMD_BOOTZ >> + bool "bootz" >> + select CMD_BOOTM > > Do we need this, or can it be 'depends on CMD_BOOTM'? Well, the way I see it is that today (with the multi-platform support in the kernel) you do not need the bootm command (historically happened that it represents the uImage) and you just want the bootz command. If we make it "depend" on bootm, the bootz entry will not show up until you enable the bootm command. That might be not trivial for the "regular" user who just want to adjust the configuration and build a new binary... Well of course it can be argued, but I really like how it works with "select" and I see bootz as an independent command and technically it happens that they share the same code for the most of it. > >> + help >> + Boot a Linux kernel zImage from the memory. >> + > > Could you add a brief description of what a zImage is and how it gets > created? It would be good to be a bit more descriptive in these help > messages. Yes that is a great idea, and of course it went through my head, but the problem is that I'm completely out of time and I've seen the other commands have that simple one liners, so I just did the same thing. I will try to figure out something more descriptive, but I'm "overbooked" with work (I've actually used my conferences time to prepare/send the patches). > >> config CMD_GO >> bool "go" >> default y >> -- >> 2.4.9 >> > > Regards, > Simon >
diff --git a/common/Kconfig b/common/Kconfig index 2c42b8e..d98eb19 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -148,6 +148,12 @@ config CMD_BOOTM help Boot an application image from the memory. +config CMD_BOOTZ + bool "bootz" + select CMD_BOOTM + help + Boot a Linux kernel zImage from the memory. + config CMD_GO bool "go" default y
Add CONFIG_CMD_BOOTZ to the Kconfig. Since the CONFIG_CMD_BOOTZ cannot live without the CONFIG_CMD_BOOTM, make it select the CONFIG_CMD_BOOTM. Signed-off-by: Igor Grinberg <grinberg@compulab.co.il> Cc: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Simon Glass <sjg@chromium.org> --- common/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+)