diff mbox

[U-Boot,v3,2/9] dm: eth: Do not print misleading "Net Initialization Skipped"

Message ID 1440739559-16225-2-git-send-email-bmeng.cn@gmail.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Bin Meng Aug. 28, 2015, 5:25 a.m. UTC 
With driver model, board_eth_init() or cpu_eth_init() is not a must.
Thus we don't need print a misleading "Net Initialization Skipped".

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>

---

Changes in v3: None
Changes in v2:
- Change to only comment out "Net Initialization Skipped" printf

 net/eth.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Glass Sept. 1, 2015, 12:32 a.m. UTC | #1 
On 27 August 2015 at 23:25, Bin Meng <bmeng.cn@gmail.com> wrote:
> With driver model, board_eth_init() or cpu_eth_init() is not a must.
> Thus we don't need print a misleading "Net Initialization Skipped".
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Change to only comment out "Net Initialization Skipped" printf
>
>  net/eth.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied to u-boot-x86, thanks!
diff mbox

Patch

diff --git a/net/eth.c b/net/eth.c
index d3ec8d6..c46a8c3 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -107,7 +107,9 @@  static void eth_common_init(void)
 		if (cpu_eth_init(gd->bd) < 0)
 			printf("CPU Net Initialization Failed\n");
 	} else {
+#ifndef CONFIG_DM_ETH
 		printf("Net Initialization Skipped\n");
+#endif
 	}
 }