| Message ID | 1440697034-28698-1-git-send-email-contact@paulk.fr |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Hi, Le jeudi 27 août 2015 à 19:37 +0200, Paul Kocialkowski a écrit : > This introduces a common definition for omap_die_id, that aims at > providing a > common interface for accessing omap platform's die id bits. It has been a week since I sent this series for review. Any comments? > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > --- > arch/arm/cpu/armv7/omap-common/utils.c | 5 +++++ > arch/arm/include/asm/omap_common.h | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/arch/arm/cpu/armv7/omap-common/utils.c > b/arch/arm/cpu/armv7/omap-common/utils.c > index df5f817..acff16b 100644 > --- a/arch/arm/cpu/armv7/omap-common/utils.c > +++ b/arch/arm/cpu/armv7/omap-common/utils.c > @@ -41,6 +41,11 @@ void cancel_out(u32 *num, u32 *den, u32 den_limit) > } > } > > +__weak void omap_die_id(unsigned int *die_id) > +{ > + die_id[0] = die_id[1] = die_id[2] = die_id[3] = 0; > +} > + > void __weak usb_fake_mac_from_die_id(u32 *id) > { > uint8_t device_mac[6]; > diff --git a/arch/arm/include/asm/omap_common.h > b/arch/arm/include/asm/omap_common.h > index b67d4b6..b46e467 100644 > --- a/arch/arm/include/asm/omap_common.h > +++ b/arch/arm/include/asm/omap_common.h > @@ -605,6 +605,8 @@ void omap_smc1(u32 service, u32 val); > void enable_edma3_clocks(void); > void disable_edma3_clocks(void); > > +void omap_die_id(unsigned int *die_id); > + > /* ABB */ > #define OMAP_ABB_NOMINAL_OPP 0 > #define OMAP_ABB_FAST_OPP 1
On Thu, Aug 27, 2015 at 07:37:08PM +0200, Paul Kocialkowski wrote: > This introduces a common definition for omap_die_id, that aims at providing a > common interface for accessing omap platform's die id bits. > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> Reviewed-by: Tom Rini <trini@konsulko.com>
Hi, Le vendredi 04 septembre 2015 à 14:14 -0400, Tom Rini a écrit : > On Thu, Aug 27, 2015 at 07:37:08PM +0200, Paul Kocialkowski wrote: > > > This introduces a common definition for omap_die_id, that aims at providing a > > common interface for accessing omap platform's die id bits. > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > Reviewed-by: Tom Rini <trini@konsulko.com> These patches have been laying around for some time now, would you agree to merge them? Thanks!
On Sun, Sep 20, 2015 at 12:42:26PM +0200, Paul Kocialkowski wrote: > Hi, > > Le vendredi 04 septembre 2015 à 14:14 -0400, Tom Rini a écrit : > > On Thu, Aug 27, 2015 at 07:37:08PM +0200, Paul Kocialkowski wrote: > > > > > This introduces a common definition for omap_die_id, that aims at providing a > > > common interface for accessing omap platform's die id bits. > > > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > > > Reviewed-by: Tom Rini <trini@konsulko.com> > > These patches have been laying around for some time now, would you agree > to merge them? I think that since this falls under cleanup I'm holding it until the next release is out. I took the earlier series so that the 'sniper' board works, yes? Thanks!
Le mardi 22 septembre 2015 à 09:06 -0400, Tom Rini a écrit : > On Sun, Sep 20, 2015 at 12:42:26PM +0200, Paul Kocialkowski wrote: > > Hi, > > > > Le vendredi 04 septembre 2015 à 14:14 -0400, Tom Rini a écrit : > > > On Thu, Aug 27, 2015 at 07:37:08PM +0200, Paul Kocialkowski wrote: > > > > > > > This introduces a common definition for omap_die_id, that aims at providing a > > > > common interface for accessing omap platform's die id bits. > > > > > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > > > > > Reviewed-by: Tom Rini <trini@konsulko.com> > > > > These patches have been laying around for some time now, would you agree > > to merge them? > > I think that since this falls under cleanup I'm holding it until the > next release is out. I took the earlier series so that the 'sniper' > board works, yes? Thanks! Sure, that's fine with me, sniper support is there and it doesn't require these pathces indeed. Thanks!
On Thu, Aug 27, 2015 at 07:37:08PM +0200, Paul Kocialkowski wrote: > This introduces a common definition for omap_die_id, that aims at providing a > common interface for accessing omap platform's die id bits. > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/arch/arm/cpu/armv7/omap-common/utils.c b/arch/arm/cpu/armv7/omap-common/utils.c index df5f817..acff16b 100644 --- a/arch/arm/cpu/armv7/omap-common/utils.c +++ b/arch/arm/cpu/armv7/omap-common/utils.c @@ -41,6 +41,11 @@ void cancel_out(u32 *num, u32 *den, u32 den_limit) } } +__weak void omap_die_id(unsigned int *die_id) +{ + die_id[0] = die_id[1] = die_id[2] = die_id[3] = 0; +} + void __weak usb_fake_mac_from_die_id(u32 *id) { uint8_t device_mac[6]; diff --git a/arch/arm/include/asm/omap_common.h b/arch/arm/include/asm/omap_common.h index b67d4b6..b46e467 100644 --- a/arch/arm/include/asm/omap_common.h +++ b/arch/arm/include/asm/omap_common.h @@ -605,6 +605,8 @@ void omap_smc1(u32 service, u32 val); void enable_edma3_clocks(void); void disable_edma3_clocks(void); +void omap_die_id(unsigned int *die_id); + /* ABB */ #define OMAP_ABB_NOMINAL_OPP 0 #define OMAP_ABB_FAST_OPP 1
This introduces a common definition for omap_die_id, that aims at providing a common interface for accessing omap platform's die id bits. Signed-off-by: Paul Kocialkowski <contact@paulk.fr> --- arch/arm/cpu/armv7/omap-common/utils.c | 5 +++++ arch/arm/include/asm/omap_common.h | 2 ++ 2 files changed, 7 insertions(+)