| Message ID | 1430174911-27538-2-git-send-email-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
On Tue, Apr 28, 2015 at 6:48 AM, Simon Glass <sjg@chromium.org> wrote: > Try to make it a little clearer. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > common/board_f.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/common/board_f.c b/common/board_f.c > index 322e070..fbbad1b 100644 > --- a/common/board_f.c > +++ b/common/board_f.c > @@ -73,7 +73,7 @@ DECLARE_GLOBAL_DATA_PTR; > #endif > > /* > - * sjg: IMO this code should be > + * TODO(sjg@chromium.org): IMO this code should be > * refactored to a single function, something like: > * > * void led_set_state(enum led_colour_t colour, int on); > @@ -300,7 +300,7 @@ __weak ulong board_get_usable_ram_top(ulong total_size) > { > #ifdef CONFIG_SYS_SDRAM_BASE > /* > - * Detect whether we have so much RAM it goes past the end of our > + * Detect whether we have so much RAM that it goes past the end of our > * 32-bit address space. If so, clip the usable RAM so it doesn't. > */ > if (gd->ram_top < CONFIG_SYS_SDRAM_BASE) > @@ -507,7 +507,7 @@ static int reserve_global_data(void) > static int reserve_fdt(void) > { > /* > - * If the device tree is sitting immediate above our image then we > + * If the device tree is sitting immediately above our image then we > * must relocate it. If it is embedded in the data section, then it > * will be relocated with other data. > */ > @@ -535,7 +535,7 @@ static int reserve_stacks(void) > gd->start_addr_sp &= ~0xf; > > /* > - * let the architecture specific code tailor gd->start_addr_sp and > + * let the architecture-specific code tailor gd->start_addr_sp and > * gd->irq_sp > */ > return arch_reserve_stacks(); > @@ -556,7 +556,6 @@ static int setup_board_part1(void) > /* > * Save local variables to board info struct > */ > - > bd->bi_memstart = CONFIG_SYS_SDRAM_BASE; /* start of memory */ > bd->bi_memsize = gd->ram_size; /* size in bytes */ > > -- Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/common/board_f.c b/common/board_f.c index 322e070..fbbad1b 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -73,7 +73,7 @@ DECLARE_GLOBAL_DATA_PTR; #endif /* - * sjg: IMO this code should be + * TODO(sjg@chromium.org): IMO this code should be * refactored to a single function, something like: * * void led_set_state(enum led_colour_t colour, int on); @@ -300,7 +300,7 @@ __weak ulong board_get_usable_ram_top(ulong total_size) { #ifdef CONFIG_SYS_SDRAM_BASE /* - * Detect whether we have so much RAM it goes past the end of our + * Detect whether we have so much RAM that it goes past the end of our * 32-bit address space. If so, clip the usable RAM so it doesn't. */ if (gd->ram_top < CONFIG_SYS_SDRAM_BASE) @@ -507,7 +507,7 @@ static int reserve_global_data(void) static int reserve_fdt(void) { /* - * If the device tree is sitting immediate above our image then we + * If the device tree is sitting immediately above our image then we * must relocate it. If it is embedded in the data section, then it * will be relocated with other data. */ @@ -535,7 +535,7 @@ static int reserve_stacks(void) gd->start_addr_sp &= ~0xf; /* - * let the architecture specific code tailor gd->start_addr_sp and + * let the architecture-specific code tailor gd->start_addr_sp and * gd->irq_sp */ return arch_reserve_stacks(); @@ -556,7 +556,6 @@ static int setup_board_part1(void) /* * Save local variables to board info struct */ - bd->bi_memstart = CONFIG_SYS_SDRAM_BASE; /* start of memory */ bd->bi_memsize = gd->ram_size; /* size in bytes */
Try to make it a little clearer. Signed-off-by: Simon Glass <sjg@chromium.org> --- common/board_f.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)