diff mbox

[U-Boot,2/4,v2] x86: minnowmax: add GPIO banks in the device tree

Message ID 1429993017-10433-1-git-send-email-contact@huau-gabriel.fr
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Gabriel Huau April 25, 2015, 8:16 p.m. UTC
There are 6 banks:
    4 banks for CORE: available in S0 mode
    2 banks for SUS (Suspend): available in S0-S5 mode

Signed-off-by: Gabriel Huau <contact@huau-gabriel.fr>
---
Changes for v2:
	- Fix typo in the commit message

 arch/x86/dts/minnowmax.dts | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

Comments

Bin Meng April 26, 2015, 1:54 p.m. UTC | #1
On Sun, Apr 26, 2015 at 4:16 AM, Gabriel Huau <contact@huau-gabriel.fr> wrote:
> There are 6 banks:
>     4 banks for CORE: available in S0 mode
>     2 banks for SUS (Suspend): available in S0-S5 mode
>
> Signed-off-by: Gabriel Huau <contact@huau-gabriel.fr>
> ---
> Changes for v2:
>         - Fix typo in the commit message
>
>  arch/x86/dts/minnowmax.dts | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/arch/x86/dts/minnowmax.dts b/arch/x86/dts/minnowmax.dts
> index 8f34369..c73e421 100644
> --- a/arch/x86/dts/minnowmax.dts
> +++ b/arch/x86/dts/minnowmax.dts
> @@ -21,6 +21,48 @@
>                 silent_console = <0>;
>         };
>
> +       gpioa {
> +               compatible = "intel,ich6-gpio";
> +               u-boot,dm-pre-reloc;
> +               reg = <0 0x20>;
> +               bank-name = "A";
> +       };
> +
> +       gpiob {
> +               compatible = "intel,ich6-gpio";
> +               u-boot,dm-pre-reloc;
> +               reg = <0x20 0x20>;
> +               bank-name = "B";
> +       };
> +
> +       gpioc {
> +               compatible = "intel,ich6-gpio";
> +               u-boot,dm-pre-reloc;
> +               reg = <0x40 0x20>;
> +               bank-name = "C";
> +       };
> +
> +       gpiod {
> +               compatible = "intel,ich6-gpio";
> +               u-boot,dm-pre-reloc;
> +               reg = <0x60 0x20>;
> +               bank-name = "D";
> +       };
> +
> +       gpioe {
> +               compatible = "intel,ich6-gpio";
> +               u-boot,dm-pre-reloc;
> +               reg = <0x80 0x20>;
> +               bank-name = "E";
> +       };
> +
> +       gpiof {
> +               compatible = "intel,ich6-gpio";
> +               u-boot,dm-pre-reloc;
> +               reg = <0xA0 0x20>;
> +               bank-name = "F";
> +       };
> +
>         chosen {
>                 stdout-path = "/serial";
>         };
> --

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Simon Glass April 28, 2015, 1:53 p.m. UTC | #2
On 26 April 2015 at 07:54, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Sun, Apr 26, 2015 at 4:16 AM, Gabriel Huau <contact@huau-gabriel.fr> wrote:
>> There are 6 banks:
>>     4 banks for CORE: available in S0 mode
>>     2 banks for SUS (Suspend): available in S0-S5 mode
>>
>> Signed-off-by: Gabriel Huau <contact@huau-gabriel.fr>
>> ---
>> Changes for v2:
>>         - Fix typo in the commit message
>>
>>  arch/x86/dts/minnowmax.dts | 42 ++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 42 insertions(+)
>>
>> diff --git a/arch/x86/dts/minnowmax.dts b/arch/x86/dts/minnowmax.dts
>> index 8f34369..c73e421 100644
>> --- a/arch/x86/dts/minnowmax.dts
>> +++ b/arch/x86/dts/minnowmax.dts
>> @@ -21,6 +21,48 @@
>>                 silent_console = <0>;
>>         };
>>
>> +       gpioa {
>> +               compatible = "intel,ich6-gpio";
>> +               u-boot,dm-pre-reloc;
>> +               reg = <0 0x20>;
>> +               bank-name = "A";
>> +       };
>> +
>> +       gpiob {
>> +               compatible = "intel,ich6-gpio";
>> +               u-boot,dm-pre-reloc;
>> +               reg = <0x20 0x20>;
>> +               bank-name = "B";
>> +       };
>> +
>> +       gpioc {
>> +               compatible = "intel,ich6-gpio";
>> +               u-boot,dm-pre-reloc;
>> +               reg = <0x40 0x20>;
>> +               bank-name = "C";
>> +       };
>> +
>> +       gpiod {
>> +               compatible = "intel,ich6-gpio";
>> +               u-boot,dm-pre-reloc;
>> +               reg = <0x60 0x20>;
>> +               bank-name = "D";
>> +       };
>> +
>> +       gpioe {
>> +               compatible = "intel,ich6-gpio";
>> +               u-boot,dm-pre-reloc;
>> +               reg = <0x80 0x20>;
>> +               bank-name = "E";
>> +       };
>> +
>> +       gpiof {
>> +               compatible = "intel,ich6-gpio";
>> +               u-boot,dm-pre-reloc;
>> +               reg = <0xA0 0x20>;
>> +               bank-name = "F";
>> +       };
>> +
>>         chosen {
>>                 stdout-path = "/serial";
>>         };
>> --
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Acked-by: Simon Glass <sjg@chromium.org>
Simon Glass April 28, 2015, 3:39 p.m. UTC | #3
On 28 April 2015 at 07:53, Simon Glass <sjg@chromium.org> wrote:
> On 26 April 2015 at 07:54, Bin Meng <bmeng.cn@gmail.com> wrote:
>> On Sun, Apr 26, 2015 at 4:16 AM, Gabriel Huau <contact@huau-gabriel.fr> wrote:
>>> There are 6 banks:
>>>     4 banks for CORE: available in S0 mode
>>>     2 banks for SUS (Suspend): available in S0-S5 mode
>>>
>>> Signed-off-by: Gabriel Huau <contact@huau-gabriel.fr>
>>> ---
>>> Changes for v2:
>>>         - Fix typo in the commit message
>>>
>>>  arch/x86/dts/minnowmax.dts | 42 ++++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 42 insertions(+)

Applied to u-boot-x86, thanks!

>>>
>>> diff --git a/arch/x86/dts/minnowmax.dts b/arch/x86/dts/minnowmax.dts
>>> index 8f34369..c73e421 100644
>>> --- a/arch/x86/dts/minnowmax.dts
>>> +++ b/arch/x86/dts/minnowmax.dts
>>> @@ -21,6 +21,48 @@
>>>                 silent_console = <0>;
>>>         };
>>>
>>> +       gpioa {
>>> +               compatible = "intel,ich6-gpio";
>>> +               u-boot,dm-pre-reloc;
>>> +               reg = <0 0x20>;
>>> +               bank-name = "A";
>>> +       };
>>> +
>>> +       gpiob {
>>> +               compatible = "intel,ich6-gpio";
>>> +               u-boot,dm-pre-reloc;
>>> +               reg = <0x20 0x20>;
>>> +               bank-name = "B";
>>> +       };
>>> +
>>> +       gpioc {
>>> +               compatible = "intel,ich6-gpio";
>>> +               u-boot,dm-pre-reloc;
>>> +               reg = <0x40 0x20>;
>>> +               bank-name = "C";
>>> +       };
>>> +
>>> +       gpiod {
>>> +               compatible = "intel,ich6-gpio";
>>> +               u-boot,dm-pre-reloc;
>>> +               reg = <0x60 0x20>;
>>> +               bank-name = "D";
>>> +       };
>>> +
>>> +       gpioe {
>>> +               compatible = "intel,ich6-gpio";
>>> +               u-boot,dm-pre-reloc;
>>> +               reg = <0x80 0x20>;
>>> +               bank-name = "E";
>>> +       };
>>> +
>>> +       gpiof {
>>> +               compatible = "intel,ich6-gpio";
>>> +               u-boot,dm-pre-reloc;
>>> +               reg = <0xA0 0x20>;
>>> +               bank-name = "F";
>>> +       };
>>> +
>>>         chosen {
>>>                 stdout-path = "/serial";
>>>         };
>>> --
>>
>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/arch/x86/dts/minnowmax.dts b/arch/x86/dts/minnowmax.dts
index 8f34369..c73e421 100644
--- a/arch/x86/dts/minnowmax.dts
+++ b/arch/x86/dts/minnowmax.dts
@@ -21,6 +21,48 @@ 
 		silent_console = <0>;
 	};
 
+	gpioa {
+		compatible = "intel,ich6-gpio";
+		u-boot,dm-pre-reloc;
+		reg = <0 0x20>;
+		bank-name = "A";
+	};
+
+	gpiob {
+		compatible = "intel,ich6-gpio";
+		u-boot,dm-pre-reloc;
+		reg = <0x20 0x20>;
+		bank-name = "B";
+	};
+
+	gpioc {
+		compatible = "intel,ich6-gpio";
+		u-boot,dm-pre-reloc;
+		reg = <0x40 0x20>;
+		bank-name = "C";
+	};
+
+	gpiod {
+		compatible = "intel,ich6-gpio";
+		u-boot,dm-pre-reloc;
+		reg = <0x60 0x20>;
+		bank-name = "D";
+	};
+
+	gpioe {
+		compatible = "intel,ich6-gpio";
+		u-boot,dm-pre-reloc;
+		reg = <0x80 0x20>;
+		bank-name = "E";
+	};
+
+	gpiof {
+		compatible = "intel,ich6-gpio";
+		u-boot,dm-pre-reloc;
+		reg = <0xA0 0x20>;
+		bank-name = "F";
+	};
+
 	chosen {
 		stdout-path = "/serial";
 	};