| Message ID | 1425316478-17059-7-git-send-email-fabio.estevam@freescale.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi On 2 March 2015 at 18:14, Fabio Estevam <fabio.estevam@freescale.com> wrote: > Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into > the console and hitting enter afterwards, causes a hang in the system because > CONFIG_SYS_PBSIZE is not capable of storing the extra characters of the error > message: > "Unknown command '' - try 'help'". > > Use the default CONFIG_SYS_PBSIZE definition from config_fallbacks.h to solve > this problem. > > Cc: Magnus Lilja <lilja.magnus@gmail.com> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > include/configs/mx31pdk.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h > index 2a3e53c..1282a6e 100644 > --- a/include/configs/mx31pdk.h > +++ b/include/configs/mx31pdk.h > @@ -121,9 +121,6 @@ > */ > #define CONFIG_SYS_LONGHELP /* undef to save memory */ > #define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ > -/* Print Buffer Size */ > -#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ > - sizeof(CONFIG_SYS_PROMPT)+16) > /* max number of command args */ > #define CONFIG_SYS_MAXARGS 16 > /* Boot Argument Buffer Size */ > -- Looks ok to me. Acked-by: Magnus Lilja <lilja.magnus@gmail.com> /Magnus
diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h index 2a3e53c..1282a6e 100644 --- a/include/configs/mx31pdk.h +++ b/include/configs/mx31pdk.h @@ -121,9 +121,6 @@ */ #define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ -/* Print Buffer Size */ -#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ - sizeof(CONFIG_SYS_PROMPT)+16) /* max number of command args */ #define CONFIG_SYS_MAXARGS 16 /* Boot Argument Buffer Size */
Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into the console and hitting enter afterwards, causes a hang in the system because CONFIG_SYS_PBSIZE is not capable of storing the extra characters of the error message: "Unknown command '' - try 'help'". Use the default CONFIG_SYS_PBSIZE definition from config_fallbacks.h to solve this problem. Cc: Magnus Lilja <lilja.magnus@gmail.com> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- include/configs/mx31pdk.h | 3 --- 1 file changed, 3 deletions(-)