| Message ID | 1424822552-4366-9-git-send-email-joe.hershberger@ni.com |
|---|---|
| State | RFC |
| Delegated to: | Simon Glass |
| Headers | show |
On 24 February 2015 at 17:02, Joe Hershberger <joe.hershberger@ni.com> wrote: > On some archs masking the parameter is inefficient, so don't use u8. > > Signed-off-by: Joe Hershberger <joe.hershberger@ni.com> > Reported-by: Simon Glass <sjg@chromium.org> > > --- > > Changes in v4: > -New to v4 > > Changes in v3: None > Changes in v2: None > > include/net.h | 2 +- > net/eth.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/include/net.h b/include/net.h index 4cef00c..ad20145 100644 --- a/include/net.h +++ b/include/net.h @@ -178,7 +178,7 @@ void eth_halt(void); /* stop SCC */ const char *eth_get_name(void); /* get name of current device */ #ifdef CONFIG_MCAST_TFTP -int eth_mcast_join(IPaddr_t mcast_addr, u8 join); +int eth_mcast_join(IPaddr_t mcast_addr, int join); u32 ether_crc(size_t len, unsigned char const *p); #endif diff --git a/net/eth.c b/net/eth.c index 214375b..484b995 100644 --- a/net/eth.c +++ b/net/eth.c @@ -319,7 +319,7 @@ int eth_initialize(bd_t *bis) * mcast_addr: multicast ipaddr from which multicast Mac is made * join: 1=join, 0=leave. */ -int eth_mcast_join(IPaddr_t mcast_ip, u8 join) +int eth_mcast_join(IPaddr_t mcast_ip, int join) { u8 mcast_mac[6]; if (!eth_current || !eth_current->mcast)
On some archs masking the parameter is inefficient, so don't use u8. Signed-off-by: Joe Hershberger <joe.hershberger@ni.com> Reported-by: Simon Glass <sjg@chromium.org> --- Changes in v4: -New to v4 Changes in v3: None Changes in v2: None include/net.h | 2 +- net/eth.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)