diff mbox

[U-Boot,08/33] WIP: x86: Drop u-boot.srec from the Makefile

Message ID 1415751501-23407-9-git-send-email-sjg@chromium.org
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass Nov. 12, 2014, 12:17 a.m. UTC
This is not needed on x86 and creates a 4GB file due to the addressing used
on x86.

This needs to be investigated.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Bin Meng Nov. 12, 2014, 6:35 a.m. UTC | #1
Hi Simon,

On Wed, Nov 12, 2014 at 8:17 AM, Simon Glass <sjg@chromium.org> wrote:
> This is not needed on x86 and creates a 4GB file due to the addressing used
> on x86.
>
> This needs to be investigated.
>

This is due to your patch "[09/33] x86: Factor out common values in
the link script" (see http://patchwork.ozlabs.org/patch/409725/) that
changes the AT value of .start16/.resetvec to the real mode address
instead of 0xffff_xxxx which will cause a 4GB file creation by
objcopy.

> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  Makefile | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index fb72c29..c54a2f1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -722,7 +722,10 @@ DO_STATIC_RELA =
>  endif
>
>  # Always append ALL so that arch config.mk's can add custom ones
> -ALL-y += u-boot.srec u-boot.bin System.map binary_size_check
> +ALL-y += u-boot.bin System.map binary_size_check
> +ifeq ($(CONFIG_X86),)
> +ALL-y += u-boot.srec
> +endif
>
>  ALL-$(CONFIG_ONENAND_U_BOOT) += u-boot-onenand.bin
>  ifeq ($(CONFIG_SPL_FSL_PBL),y)
> --

Regards,
Bin
diff mbox

Patch

diff --git a/Makefile b/Makefile
index fb72c29..c54a2f1 100644
--- a/Makefile
+++ b/Makefile
@@ -722,7 +722,10 @@  DO_STATIC_RELA =
 endif
 
 # Always append ALL so that arch config.mk's can add custom ones
-ALL-y += u-boot.srec u-boot.bin System.map binary_size_check
+ALL-y += u-boot.bin System.map binary_size_check
+ifeq ($(CONFIG_X86),)
+ALL-y += u-boot.srec
+endif
 
 ALL-$(CONFIG_ONENAND_U_BOOT) += u-boot-onenand.bin
 ifeq ($(CONFIG_SPL_FSL_PBL),y)