| Message ID | 1413817185-32636-2-git-send-email-andrew.ruder@elecsyscorp.com |
|---|---|
| State | Deferred |
| Delegated to: | Tom Rini |
| Headers | show |
On Mon, Oct 20, 2014 at 09:59:43AM -0500, Andrew Ruder wrote: > dump_regs() is a handy function to keep around for bringing up a new > dm9000-based board, but defining CONFIG_DM9000_DEBUG only adds the > function - nowhere currently uses it. Rather than remove a potentially > useful function, let's just tell gcc to not emit a warning when it is > unused. > > Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com> > Cc: Joe Hershberger <joe.hershberger@gmail.com> > --- > drivers/net/dm9000x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c > index 4de9d41..50a36f3 100644 > --- a/drivers/net/dm9000x.c > +++ b/drivers/net/dm9000x.c > @@ -126,7 +126,7 @@ static void DM9000_iow(int reg, u8 value); > > #ifdef CONFIG_DM9000_DEBUG > static void > -dump_regs(void) > +dump_regs(void) __attribute__ ((unused)) > { > DM9000_DBG("\n"); > DM9000_DBG("NCR (0x00): %02x\n", DM9000_ior(0)); Please make sure we have <linux/compiler.h> and use __unused (or __maybe_unused?) here, thanks!
diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c index 4de9d41..50a36f3 100644 --- a/drivers/net/dm9000x.c +++ b/drivers/net/dm9000x.c @@ -126,7 +126,7 @@ static void DM9000_iow(int reg, u8 value); #ifdef CONFIG_DM9000_DEBUG static void -dump_regs(void) +dump_regs(void) __attribute__ ((unused)) { DM9000_DBG("\n"); DM9000_DBG("NCR (0x00): %02x\n", DM9000_ior(0));
dump_regs() is a handy function to keep around for bringing up a new dm9000-based board, but defining CONFIG_DM9000_DEBUG only adds the function - nowhere currently uses it. Rather than remove a potentially useful function, let's just tell gcc to not emit a warning when it is unused. Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com> Cc: Joe Hershberger <joe.hershberger@gmail.com> --- drivers/net/dm9000x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)