diff mbox

[U-Boot] generic-board: make compile-time noise for non-generic boards

Message ID 1413740790-5784-1-git-send-email-yamada.m@jp.panasonic.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Oct. 19, 2014, 5:46 p.m. UTC
Commit 0f605c1501f6 (Start the deprecation process for generic board)
added a run-time warning message.  Let's be noisier for non-generic
boards to inform the dead line of the conversion.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Tom Rini <trini@ti.com>
Cc: Simon Glass <sjg@chromium.org>
---

 Makefile | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Marek Vasut Oct. 19, 2014, 5:53 p.m. UTC | #1
On Sunday, October 19, 2014 at 07:46:30 PM, Masahiro Yamada wrote:
> Commit 0f605c1501f6 (Start the deprecation process for generic board)
> added a run-time warning message.  Let's be noisier for non-generic
> boards to inform the dead line of the conversion.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Tom Rini <trini@ti.com>
> Cc: Simon Glass <sjg@chromium.org>

By all means,

Acked-by: Marek Vasut <marex@denx.de>

I hope you enjoyed your stay in Germany and had fun. It was really nice
meeting you again :)

Best regards,
Marek Vasut
Vagrant Cascadian Oct. 19, 2014, 11:19 p.m. UTC | #2
On 2014-10-19, Masahiro Yamada wrote:
> Commit 0f605c1501f6 (Start the deprecation process for generic board)
> added a run-time warning message.  Let's be noisier for non-generic
> boards to inform the dead line of the conversion.
...
> diff --git a/Makefile b/Makefile
> index 99097e1..f439d82 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -775,6 +775,12 @@ quiet_cmd_pad_cat = CAT     $@
>  cmd_pad_cat = $(cmd_objcopy) && $(append) || rm -f $@
>  
>  all:		$(ALL-y)
> +ifneq ($(CONFIG_SYS_GENERIC_BOARD),y)
> +	@echo >&2 "==================== WARNING ====================="
> +	@echo >&2 "Please convert this board to generic board."
> +	@echo >&2 "Otherwise it will be removed by the end of 2014."
> +	@echo >&2 "=================================================="
> +endif
>  
>  PHONY += dtbs
>  dtbs dts/dt.dtb: checkdtc u-boot

Maybe it should also mention doc/README.generic-board in the warning, or
some other indication where to find more information?

live well,
  vagrant
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 99097e1..f439d82 100644
--- a/Makefile
+++ b/Makefile
@@ -775,6 +775,12 @@  quiet_cmd_pad_cat = CAT     $@
 cmd_pad_cat = $(cmd_objcopy) && $(append) || rm -f $@
 
 all:		$(ALL-y)
+ifneq ($(CONFIG_SYS_GENERIC_BOARD),y)
+	@echo >&2 "==================== WARNING ====================="
+	@echo >&2 "Please convert this board to generic board."
+	@echo >&2 "Otherwise it will be removed by the end of 2014."
+	@echo >&2 "=================================================="
+endif
 
 PHONY += dtbs
 dtbs dts/dt.dtb: checkdtc u-boot